devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board
@ 2019-07-30 15:05 Lukasz Majewski
  2019-07-30 15:19 ` Fabio Estevam
  0 siblings, 1 reply; 5+ messages in thread
From: Lukasz Majewski @ 2019-07-30 15:05 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Fabio Estevam, Sascha Hauer, Stefan Agner, Rob Herring,
	Mark Rutland, linux-arm-kernel, devicetree, linux-kernel,
	Lukasz Majewski

Before this change the device tree description of qspi node for
second memory on BK4 board was wrong (applicable to old, in-house
tunned fsl-quadspi.c driver).

As a result this memory was not recognized correctly when used
with the new spi-fsl-qspi.c driver.

>From the dt-bindings:

"Required SPI slave node properties:
  - reg: There are two buses (A and B) with two chip selects each.
This encodes to which bus and CS the flash is connected:
<0>: Bus A, CS 0
<1>: Bus A, CS 1
<2>: Bus B, CS 0
<3>: Bus B, CS 1"

According to above with new driver the second SPI-NOR memory shall
have reg=<2> as it is connected to Bus B, CS 0.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 arch/arm/boot/dts/vf610-bk4.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/vf610-bk4.dts b/arch/arm/boot/dts/vf610-bk4.dts
index 3fa0cbe456db..0f3870d3b099 100644
--- a/arch/arm/boot/dts/vf610-bk4.dts
+++ b/arch/arm/boot/dts/vf610-bk4.dts
@@ -246,13 +246,13 @@
 		reg = <0>;
 	};
 
-	n25q128a13_2: flash@1 {
+	n25q128a13_2: flash@2 {
 		compatible = "n25q128a13", "jedec,spi-nor";
 		#address-cells = <1>;
 		#size-cells = <1>;
 		spi-max-frequency = <66000000>;
 		spi-rx-bus-width = <2>;
-		reg = <1>;
+		reg = <2>;
 	};
 };
 
-- 
2.11.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board
  2019-07-30 15:05 [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board Lukasz Majewski
@ 2019-07-30 15:19 ` Fabio Estevam
  2019-07-30 15:53   ` Lukasz Majewski
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-07-30 15:19 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring, Mark Rutland,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

Hi Lukasz,

Subject line could be improved:

ARM: dts: vf610-bk4: Fix qspi node description

On Tue, Jul 30, 2019 at 12:06 PM Lukasz Majewski <lukma@denx.de> wrote:
>
> Before this change the device tree description of qspi node for
> second memory on BK4 board was wrong (applicable to old, in-house
> tunned fsl-quadspi.c driver).
>
> As a result this memory was not recognized correctly when used
> with the new spi-fsl-qspi.c driver.
>
> From the dt-bindings:
>
> "Required SPI slave node properties:
>   - reg: There are two buses (A and B) with two chip selects each.
> This encodes to which bus and CS the flash is connected:
> <0>: Bus A, CS 0
> <1>: Bus A, CS 1
> <2>: Bus B, CS 0
> <3>: Bus B, CS 1"
>
> According to above with new driver the second SPI-NOR memory shall
> have reg=<2> as it is connected to Bus B, CS 0.

I am glad you got it working!

This looks very familiar with the suggestion I sent yesterday:
http://lists.infradead.org/pipermail/linux-mtd/2019-July/090655.html

It is a good practice to give some credit to someone who has helped in
finding the solution of your problem.

Adding a Suggested-by: Fabio Estevam <festevam@gmail.com> would be nice here.

This also needs a Fixes tag.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board
  2019-07-30 15:19 ` Fabio Estevam
@ 2019-07-30 15:53   ` Lukasz Majewski
  2019-07-30 16:01     ` Fabio Estevam
  0 siblings, 1 reply; 5+ messages in thread
From: Lukasz Majewski @ 2019-07-30 15:53 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring, Mark Rutland,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Hi Fabio,

> Hi Lukasz,
> 
> Subject line could be improved:
> 
> ARM: dts: vf610-bk4: Fix qspi node description
> 
> On Tue, Jul 30, 2019 at 12:06 PM Lukasz Majewski <lukma@denx.de>
> wrote:
> >
> > Before this change the device tree description of qspi node for
> > second memory on BK4 board was wrong (applicable to old, in-house
> > tunned fsl-quadspi.c driver).
> >
> > As a result this memory was not recognized correctly when used
> > with the new spi-fsl-qspi.c driver.
> >
> > From the dt-bindings:
> >
> > "Required SPI slave node properties:
> >   - reg: There are two buses (A and B) with two chip selects each.
> > This encodes to which bus and CS the flash is connected:
> > <0>: Bus A, CS 0
> > <1>: Bus A, CS 1
> > <2>: Bus B, CS 0
> > <3>: Bus B, CS 1"
> >
> > According to above with new driver the second SPI-NOR memory shall
> > have reg=<2> as it is connected to Bus B, CS 0.  
> 
> I am glad you got it working!
> 
> This looks very familiar with the suggestion I sent yesterday:
> http://lists.infradead.org/pipermail/linux-mtd/2019-July/090655.html
> 

Yes, indeed. Deepest apologizes for not adding credits. I will fix it
in v2.

> It is a good practice to give some credit to someone who has helped in
> finding the solution of your problem.
> 
> Adding a Suggested-by: Fabio Estevam <festevam@gmail.com> would be
> nice here.
> 
> This also needs a Fixes tag.

Shall I refer to the original commit (which added this DTS)? Or the
original issue posted to linux-mtd [1] ?

Note:

[1] - https://www.spinics.net/lists/linux-mtd/msg08114.html

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board
  2019-07-30 15:53   ` Lukasz Majewski
@ 2019-07-30 16:01     ` Fabio Estevam
  2019-07-30 16:04       ` Lukasz Majewski
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-07-30 16:01 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring, Mark Rutland,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

Hi Lukasz,

On Tue, Jul 30, 2019 at 12:53 PM Lukasz Majewski <lukma@denx.de> wrote:

> Shall I refer to the original commit (which added this DTS)? Or the
> original issue posted to linux-mtd [1] ?

You can add a Fixes tag like this:

Fixes: a67d2c52a82f ("ARM: dts: Add support for Liebherr's BK4 device
(vf610 based)")

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board
  2019-07-30 16:01     ` Fabio Estevam
@ 2019-07-30 16:04       ` Lukasz Majewski
  0 siblings, 0 replies; 5+ messages in thread
From: Lukasz Majewski @ 2019-07-30 16:04 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Shawn Guo, Sascha Hauer, Stefan Agner, Rob Herring, Mark Rutland,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Hi Fabio,

> Hi Lukasz,
> 
> On Tue, Jul 30, 2019 at 12:53 PM Lukasz Majewski <lukma@denx.de>
> wrote:
> 
> > Shall I refer to the original commit (which added this DTS)? Or the
> > original issue posted to linux-mtd [1] ?  
> 
> You can add a Fixes tag like this:
> 
> Fixes: a67d2c52a82f ("ARM: dts: Add support for Liebherr's BK4 device
> (vf610 based)")

Yes, the above is correct (as indicated [1]), but I was not sure if I
should also refer to the original post to linux-mtd ML.

Now it is clear - thanks :-)

Note:

[1] -
https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#reviewer-s-statement-of-oversight

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-07-30 16:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-30 15:05 [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board Lukasz Majewski
2019-07-30 15:19 ` Fabio Estevam
2019-07-30 15:53   ` Lukasz Majewski
2019-07-30 16:01     ` Fabio Estevam
2019-07-30 16:04       ` Lukasz Majewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).