devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/9] DRM panel drivers for omapdrm
@ 2019-08-10 23:10 Laurent Pinchart
  2019-08-10 23:10 ` [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix Laurent Pinchart
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Laurent Pinchart @ 2019-08-10 23:10 UTC (permalink / raw)
  To: dri-devel; +Cc: devicetree, Thierry Reding, Sam Ravnborg, Rob Herring

Hello everybody,

These 9 patches have initially been posted as part of the larger "[PATCH
00/60] drm/omap: Replace custom display drivers with drm_bridge and
drm_panel" series, hence the v2 in the subject prefix.

I'm posting this second version separately per Sam's request as the rest
of the original series is expected to take more time to process through
review. 

There's nothing very special here. The first three patches add DT vendor
prefixes and DT bindings. Since v1 patch 3/9 has been converted from
text to YAML, and as I'm not very familiar with YAML DT bindings, I'm
eagerly waiting for reviews.

The last six patches add new panel drivers. The code originates from the
corresponding omapdrm-specific panel drivers, which explains why only
one new DT binding is needed as most of them are already present.

Please see individual patches for changelogs. Sam, I believe I've taken
all your comments into account, I hope none fell through the cracks.

The patches are based on top of drm-misc-next and can be found at

	git://linuxtv.org/pinchartl/media.git omapdrm/panels

Laurent Pinchart (9):
  dt-bindings: Add vendor prefix for LG Display
  dt-bindings: Add legacy 'toppoly' vendor prefix
  dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
  drm/panel: Add driver for the LG Philips LB035Q02 panel
  drm/panel: Add driver for the NEC NL8048HL11 panel
  drm/panel: Add driver for the Sharp LS037V7DW01 panel
  drm/panel: Add driver for the Sony ACX565AKM panel
  drm/panel: Add driver for the Toppoly TD028TTEC1 panel
  drm/panel: Add driver for the Toppoly TD043MTEA1 panel

 .../display/panel/nec,nl8048hl11.yaml         |  49 ++
 .../devicetree/bindings/vendor-prefixes.yaml  |   5 +
 drivers/gpu/drm/panel/Kconfig                 |  46 ++
 drivers/gpu/drm/panel/Makefile                |   6 +
 drivers/gpu/drm/panel/panel-lg-lb035q02.c     | 237 ++++++
 drivers/gpu/drm/panel/panel-nec-nl8048hl11.c  | 247 +++++++
 .../gpu/drm/panel/panel-sharp-ls037v7dw01.c   | 226 ++++++
 drivers/gpu/drm/panel/panel-sony-acx565akm.c  | 693 ++++++++++++++++++
 drivers/gpu/drm/panel/panel-tpo-td028ttec1.c  | 381 ++++++++++
 drivers/gpu/drm/panel/panel-tpo-td043mtea1.c  | 508 +++++++++++++
 10 files changed, 2398 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-lg-lb035q02.c
 create mode 100644 drivers/gpu/drm/panel/panel-nec-nl8048hl11.c
 create mode 100644 drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
 create mode 100644 drivers/gpu/drm/panel/panel-sony-acx565akm.c
 create mode 100644 drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
 create mode 100644 drivers/gpu/drm/panel/panel-tpo-td043mtea1.c

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix
  2019-08-10 23:10 [PATCH v2 0/9] DRM panel drivers for omapdrm Laurent Pinchart
@ 2019-08-10 23:10 ` Laurent Pinchart
  2019-08-12 18:54   ` Rob Herring
  2019-08-10 23:10 ` [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel Laurent Pinchart
  2019-08-11 17:23 ` [PATCH v2 0/9] DRM panel drivers for omapdrm Sam Ravnborg
  2 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2019-08-10 23:10 UTC (permalink / raw)
  To: dri-devel; +Cc: devicetree, Thierry Reding, Sam Ravnborg, Rob Herring

The 'toppoly' vendor prefix is in use and refers to TPO, whose DT vendor
prefix is already defined as 'tpo'. Add 'toppoly' as an alternative and
document it as legacy.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v1:

- Mark the prefix as deprecated
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 5efddbff2430..29dcc6f8a64a 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -935,6 +935,9 @@ patternProperties:
     description: Tecon Microprocessor Technologies, LLC.
   "^topeet,.*":
     description: Topeet
+  "^toppoly,.*":
+    description: TPO (deprecated, use tpo)
+    deprecated: true
   "^toradex,.*":
     description: Toradex AG
   "^toshiba,.*":
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
  2019-08-10 23:10 [PATCH v2 0/9] DRM panel drivers for omapdrm Laurent Pinchart
  2019-08-10 23:10 ` [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix Laurent Pinchart
@ 2019-08-10 23:10 ` Laurent Pinchart
  2019-08-11 16:55   ` Sam Ravnborg
  2019-08-12 19:18   ` Rob Herring
  2019-08-11 17:23 ` [PATCH v2 0/9] DRM panel drivers for omapdrm Sam Ravnborg
  2 siblings, 2 replies; 9+ messages in thread
From: Laurent Pinchart @ 2019-08-10 23:10 UTC (permalink / raw)
  To: dri-devel; +Cc: devicetree, Thierry Reding, Sam Ravnborg, Rob Herring

The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB
parallel data interface and an SPI control interface.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v1:

- Convert to YAML
---
 .../display/panel/nec,nl8048hl11.yaml         | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
new file mode 100644
index 000000000000..cc3d40975828
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NEC NL8048HL11 4.1" WVGA TFT LCD panel
+
+description:
+  The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel
+  data interface and an SPI control interface.
+
+maintainers:
+  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: nec,nl8048hl11
+
+  label: true
+  reset-gpios: true
+  port: true
+
+required:
+  - compatible
+  - reset-gpios
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    lcd_panel: panel {
+      compatible = "nec,nl8048hl11";
+      spi-max-frequency = <10000000>;
+
+      reset-gpios = <&gpio7 7 GPIO_ACTIVE_LOW>;
+
+      port {
+        lcd_in: endpoint {
+          remote-endpoint = <&dpi_out>;
+        };
+      };
+    };
+
+...
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
  2019-08-10 23:10 ` [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel Laurent Pinchart
@ 2019-08-11 16:55   ` Sam Ravnborg
  2019-08-12 19:21     ` Rob Herring
  2019-08-12 19:18   ` Rob Herring
  1 sibling, 1 reply; 9+ messages in thread
From: Sam Ravnborg @ 2019-08-11 16:55 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: devicetree, Thierry Reding, Rob Herring, dri-devel

Hi Laurent.

My meta-schemas foo is very limited, but I noticed a few things.
Hopefully Rob finds time soon to review.

	Sam

On Sun, Aug 11, 2019 at 02:10:42AM +0300, Laurent Pinchart wrote:
> The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB
> parallel data interface and an SPI control interface.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
> 
> - Convert to YAML
> ---
>  .../display/panel/nec,nl8048hl11.yaml         | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> new file mode 100644
> index 000000000000..cc3d40975828
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NEC NL8048HL11 4.1" WVGA TFT LCD panel
> +
> +description:
> +  The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel
> +  data interface and an SPI control interface.
> +
> +maintainers:
> +  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
I *think* we are missing a reference to spi-controller.yaml here.


> +
> +properties:
> +  compatible:
> +    const: nec,nl8048hl11
> +
> +  label: true
> +  reset-gpios: true
> +  port: true
> +
> +required:
> +  - compatible
> +  - reset-gpios
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    lcd_panel: panel {
> +      compatible = "nec,nl8048hl11";
> +      spi-max-frequency = <10000000>;
Not sure, but should there be a reg property here for spi too?

> +
> +      reset-gpios = <&gpio7 7 GPIO_ACTIVE_LOW>;
> +
> +      port {
> +        lcd_in: endpoint {
> +          remote-endpoint = <&dpi_out>;
> +        };
> +      };
> +    };
> +
> +...
> -- 
> Regards,
> 
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 0/9] DRM panel drivers for omapdrm
  2019-08-10 23:10 [PATCH v2 0/9] DRM panel drivers for omapdrm Laurent Pinchart
  2019-08-10 23:10 ` [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix Laurent Pinchart
  2019-08-10 23:10 ` [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel Laurent Pinchart
@ 2019-08-11 17:23 ` Sam Ravnborg
  2 siblings, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2019-08-11 17:23 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: devicetree, Thierry Reding, Rob Herring, dri-devel

Hi Laurent.

On Sun, Aug 11, 2019 at 02:10:39AM +0300, Laurent Pinchart wrote:
> Hello everybody,
> 
> These 9 patches have initially been posted as part of the larger "[PATCH
> 00/60] drm/omap: Replace custom display drivers with drm_bridge and
> drm_panel" series, hence the v2 in the subject prefix.
> 
> I'm posting this second version separately per Sam's request as the rest
> of the original series is expected to take more time to process through
> review.
Thanks, make good sense (to me) that we process these now while waiting
for the dust to settel on the other more invasive patches.

> 
> There's nothing very special here. The first three patches add DT vendor
> prefixes and DT bindings. Since v1 patch 3/9 has been converted from
> text to YAML, and as I'm not very familiar with YAML DT bindings, I'm
> eagerly waiting for reviews.
> 
> The last six patches add new panel drivers. The code originates from the
> corresponding omapdrm-specific panel drivers, which explains why only
> one new DT binding is needed as most of them are already present.
> 
> Please see individual patches for changelogs. Sam, I believe I've taken
> all your comments into account, I hope none fell through the cracks.
I have been through the patches - all looked good.
One generel comment about drm_panel_remove().

The DT for the NEC NL8048HL11 needs to be reviewed, and then we can
land all patches in one go.
Unless someone else put some review effort in and find something.

	Sam


> 
> The patches are based on top of drm-misc-next and can be found at
> 
> 	git://linuxtv.org/pinchartl/media.git omapdrm/panels
> 
> Laurent Pinchart (9):
>   dt-bindings: Add vendor prefix for LG Display
>   dt-bindings: Add legacy 'toppoly' vendor prefix
>   dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
>   drm/panel: Add driver for the LG Philips LB035Q02 panel
>   drm/panel: Add driver for the NEC NL8048HL11 panel
>   drm/panel: Add driver for the Sharp LS037V7DW01 panel
>   drm/panel: Add driver for the Sony ACX565AKM panel
>   drm/panel: Add driver for the Toppoly TD028TTEC1 panel
>   drm/panel: Add driver for the Toppoly TD043MTEA1 panel
> 
>  .../display/panel/nec,nl8048hl11.yaml         |  49 ++
>  .../devicetree/bindings/vendor-prefixes.yaml  |   5 +
>  drivers/gpu/drm/panel/Kconfig                 |  46 ++
>  drivers/gpu/drm/panel/Makefile                |   6 +
>  drivers/gpu/drm/panel/panel-lg-lb035q02.c     | 237 ++++++
>  drivers/gpu/drm/panel/panel-nec-nl8048hl11.c  | 247 +++++++
>  .../gpu/drm/panel/panel-sharp-ls037v7dw01.c   | 226 ++++++
>  drivers/gpu/drm/panel/panel-sony-acx565akm.c  | 693 ++++++++++++++++++
>  drivers/gpu/drm/panel/panel-tpo-td028ttec1.c  | 381 ++++++++++
>  drivers/gpu/drm/panel/panel-tpo-td043mtea1.c  | 508 +++++++++++++
>  10 files changed, 2398 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
>  create mode 100644 drivers/gpu/drm/panel/panel-lg-lb035q02.c
>  create mode 100644 drivers/gpu/drm/panel/panel-nec-nl8048hl11.c
>  create mode 100644 drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
>  create mode 100644 drivers/gpu/drm/panel/panel-sony-acx565akm.c
>  create mode 100644 drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
>  create mode 100644 drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> 
> -- 
> Regards,
> 
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix
  2019-08-10 23:10 ` [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix Laurent Pinchart
@ 2019-08-12 18:54   ` Rob Herring
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2019-08-12 18:54 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: devicetree, Thierry Reding, Sam Ravnborg, dri-devel

On Sat, Aug 10, 2019 at 5:10 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> The 'toppoly' vendor prefix is in use and refers to TPO, whose DT vendor
> prefix is already defined as 'tpo'. Add 'toppoly' as an alternative and
> document it as legacy.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
>
> - Mark the prefix as deprecated
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
  2019-08-10 23:10 ` [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel Laurent Pinchart
  2019-08-11 16:55   ` Sam Ravnborg
@ 2019-08-12 19:18   ` Rob Herring
  2019-08-13 13:09     ` Laurent Pinchart
  1 sibling, 1 reply; 9+ messages in thread
From: Rob Herring @ 2019-08-12 19:18 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: devicetree, Thierry Reding, Sam Ravnborg, dri-devel

On Sat, Aug 10, 2019 at 5:10 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB
> parallel data interface and an SPI control interface.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
>
> - Convert to YAML
> ---
>  .../display/panel/nec,nl8048hl11.yaml         | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> new file mode 100644
> index 000000000000..cc3d40975828
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NEC NL8048HL11 4.1" WVGA TFT LCD panel
> +
> +description:
> +  The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel
> +  data interface and an SPI control interface.
> +
> +maintainers:
> +  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: nec,nl8048hl11
> +
> +  label: true
> +  reset-gpios: true
> +  port: true
> +
> +required:
> +  - compatible
> +  - reset-gpios
> +  - port
> +
> +additionalProperties: false
> +
> +examples:

Your example will fail on 'make dt_binding_check'...

> +  - |
> +    lcd_panel: panel {

SPI devices have to have a minimal SPI controller parent. Primarily
just #size-cells and #address-cells are needed.

'reg' is missing here too.

> +      compatible = "nec,nl8048hl11";
> +      spi-max-frequency = <10000000>;

This needs to be listed in properties ideally with some constraints.

> +
> +      reset-gpios = <&gpio7 7 GPIO_ACTIVE_LOW>;

And GPIO_ACTIVE_LOW. You have to add includes you need.

> +
> +      port {
> +        lcd_in: endpoint {
> +          remote-endpoint = <&dpi_out>;
> +        };
> +      };
> +    };
> +
> +...
> --
> Regards,
>
> Laurent Pinchart
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
  2019-08-11 16:55   ` Sam Ravnborg
@ 2019-08-12 19:21     ` Rob Herring
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2019-08-12 19:21 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: devicetree, Thierry Reding, Laurent Pinchart, dri-devel

On Sun, Aug 11, 2019 at 10:56 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Laurent.
>
> My meta-schemas foo is very limited, but I noticed a few things.
> Hopefully Rob finds time soon to review.
>
>         Sam
>
> On Sun, Aug 11, 2019 at 02:10:42AM +0300, Laurent Pinchart wrote:
> > The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB
> > parallel data interface and an SPI control interface.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v1:
> >
> > - Convert to YAML
> > ---
> >  .../display/panel/nec,nl8048hl11.yaml         | 49 +++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> > new file mode 100644
> > index 000000000000..cc3d40975828
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NEC NL8048HL11 4.1" WVGA TFT LCD panel
> > +
> > +description:
> > +  The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel
> > +  data interface and an SPI control interface.
> > +
> > +maintainers:
> > +  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> I *think* we are missing a reference to spi-controller.yaml here.

No, because this is a SPI slave, not a SPI controller. The example
does need a 'spi' parent node and then spi-controller.yaml will get
applied to the example.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
  2019-08-12 19:18   ` Rob Herring
@ 2019-08-13 13:09     ` Laurent Pinchart
  0 siblings, 0 replies; 9+ messages in thread
From: Laurent Pinchart @ 2019-08-13 13:09 UTC (permalink / raw)
  To: Rob Herring; +Cc: devicetree, Thierry Reding, Sam Ravnborg, dri-devel

Hi Rob,

On Mon, Aug 12, 2019 at 01:18:39PM -0600, Rob Herring wrote:
> On Sat, Aug 10, 2019 at 5:10 PM Laurent Pinchart wrote:
> >
> > The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB
> > parallel data interface and an SPI control interface.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v1:
> >
> > - Convert to YAML
> > ---
> >  .../display/panel/nec,nl8048hl11.yaml         | 49 +++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> > new file mode 100644
> > index 000000000000..cc3d40975828
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NEC NL8048HL11 4.1" WVGA TFT LCD panel
> > +
> > +description:
> > +  The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel
> > +  data interface and an SPI control interface.
> > +
> > +maintainers:
> > +  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: nec,nl8048hl11
> > +
> > +  label: true
> > +  reset-gpios: true
> > +  port: true
> > +
> > +required:
> > +  - compatible
> > +  - reset-gpios
> > +  - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> 
> Your example will fail on 'make dt_binding_check'...

I wasn't aware of this. I've now read writing-schema.md and will make
sure to submit bindings that pass the checks. I'll address the issues
your pointed out below for the next version.

> > +  - |
> > +    lcd_panel: panel {
> 
> SPI devices have to have a minimal SPI controller parent. Primarily
> just #size-cells and #address-cells are needed.
> 
> 'reg' is missing here too.
> 
> > +      compatible = "nec,nl8048hl11";
> > +      spi-max-frequency = <10000000>;
> 
> This needs to be listed in properties ideally with some constraints.
> 
> > +
> > +      reset-gpios = <&gpio7 7 GPIO_ACTIVE_LOW>;
> 
> And GPIO_ACTIVE_LOW. You have to add includes you need.
> 
> > +
> > +      port {
> > +        lcd_in: endpoint {
> > +          remote-endpoint = <&dpi_out>;
> > +        };
> > +      };
> > +    };
> > +
> > +...

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-08-13 13:09 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-10 23:10 [PATCH v2 0/9] DRM panel drivers for omapdrm Laurent Pinchart
2019-08-10 23:10 ` [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix Laurent Pinchart
2019-08-12 18:54   ` Rob Herring
2019-08-10 23:10 ` [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel Laurent Pinchart
2019-08-11 16:55   ` Sam Ravnborg
2019-08-12 19:21     ` Rob Herring
2019-08-12 19:18   ` Rob Herring
2019-08-13 13:09     ` Laurent Pinchart
2019-08-11 17:23 ` [PATCH v2 0/9] DRM panel drivers for omapdrm Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).