* [PATCH] dt-bindings: gpu: Convert Samsung 2D Graphics Accelerator to dt-schema
[not found] <CGME20190924113225eucas1p131429c7f7e0d520693b89bb2a7d9e211@eucas1p1.samsung.com>
@ 2019-09-24 11:31 ` Marek Szyprowski
2019-09-24 11:44 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Marek Szyprowski @ 2019-09-24 11:31 UTC (permalink / raw)
To: devicetree, dri-devel, linux-kernel, linux-samsung-soc
Cc: Rob Herring, Mark Rutland, Inki Dae, Krzysztof Kozlowski,
Maciej Falkowski, Marek Szyprowski
From: Maciej Falkowski <m.falkowski@samsung.com>
Convert Samsung 2D Graphics Accelerator to newer dt-schema format
Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
.../devicetree/bindings/gpu/samsung-g2d.txt | 27 ----------
.../devicetree/bindings/gpu/samsung-g2d.yaml | 53 +++++++++++++++++++
2 files changed, 53 insertions(+), 27 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
deleted file mode 100644
index 1e7959332dbc..000000000000
--- a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-* Samsung 2D Graphics Accelerator
-
-Required properties:
- - compatible : value should be one among the following:
- (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 SoC
- (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
- (c) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
-
- - reg : Physical base address of the IP registers and length of memory
- mapped region.
-
- - interrupts : G2D interrupt number to the CPU.
- - clocks : from common clock binding: handle to G2D clocks.
- - clock-names : names of clocks listed in clocks property, in the same
- order, depending on SoC type:
- - for S5PV210 and Exynos4 based SoCs: "fimg2d" and
- "sclk_fimg2d"
- - for Exynos5250 SoC: "fimg2d".
-
-Example:
- g2d@12800000 {
- compatible = "samsung,s5pv210-g2d";
- reg = <0x12800000 0x1000>;
- interrupts = <0 89 0>;
- clocks = <&clock 177>, <&clock 277>;
- clock-names = "sclk_fimg2d", "fimg2d";
- };
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
new file mode 100644
index 000000000000..bb0a4bf168cc
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpu/samsung-g2d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SoC 2D Graphics Accelerator
+
+maintainers:
+ - Inki Dae <inki.dae@samsung.com>
+
+properties:
+ compatible:
+ enum:
+ - samsung,s5pv210-g2d # in S5PV210 & Exynos4210 SoC
+ - samsung,exynos4212-g2d # in Exynos4x12 SoCs
+ - samsung,exynos5250-g2d
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ oneOf:
+ - items: # for Exynos5250 SoC
+ - const: fimg2d
+ - items: # for S5PV210 and Exynos4 based SoCs
+ - const: sclk_fimg2d
+ - const: fimg2d
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+examples:
+ - |
+ g2d@12800000 {
+ compatible = "samsung,s5pv210-g2d";
+ reg = <0x12800000 0x1000>;
+ interrupts = <0 89 0>;
+ clocks = <&clock 177>, <&clock 277>;
+ clock-names = "sclk_fimg2d", "fimg2d";
+ };
+
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: gpu: Convert Samsung 2D Graphics Accelerator to dt-schema
2019-09-24 11:31 ` [PATCH] dt-bindings: gpu: Convert Samsung 2D Graphics Accelerator to dt-schema Marek Szyprowski
@ 2019-09-24 11:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-24 11:44 UTC (permalink / raw)
To: Marek Szyprowski
Cc: devicetree, dri-devel, linux-kernel, linux-samsung-soc,
Rob Herring, Mark Rutland, Inki Dae, Maciej Falkowski
On Tue, Sep 24, 2019 at 01:31:59PM +0200, Marek Szyprowski wrote:
> From: Maciej Falkowski <m.falkowski@samsung.com>
>
> Convert Samsung 2D Graphics Accelerator to newer dt-schema format
>
> Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> .../devicetree/bindings/gpu/samsung-g2d.txt | 27 ----------
> .../devicetree/bindings/gpu/samsung-g2d.yaml | 53 +++++++++++++++++++
> 2 files changed, 53 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> deleted file mode 100644
> index 1e7959332dbc..000000000000
> --- a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -* Samsung 2D Graphics Accelerator
> -
> -Required properties:
> - - compatible : value should be one among the following:
> - (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 SoC
> - (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
> - (c) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
> -
> - - reg : Physical base address of the IP registers and length of memory
> - mapped region.
> -
> - - interrupts : G2D interrupt number to the CPU.
> - - clocks : from common clock binding: handle to G2D clocks.
> - - clock-names : names of clocks listed in clocks property, in the same
> - order, depending on SoC type:
> - - for S5PV210 and Exynos4 based SoCs: "fimg2d" and
> - "sclk_fimg2d"
> - - for Exynos5250 SoC: "fimg2d".
> -
> -Example:
> - g2d@12800000 {
> - compatible = "samsung,s5pv210-g2d";
> - reg = <0x12800000 0x1000>;
> - interrupts = <0 89 0>;
> - clocks = <&clock 177>, <&clock 277>;
> - clock-names = "sclk_fimg2d", "fimg2d";
> - };
>ss diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> new file mode 100644
> index 000000000000..bb0a4bf168cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/samsung-g2d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung SoC 2D Graphics Accelerator
> +
> +maintainers:
> + - Inki Dae <inki.dae@samsung.com>
> +
> +properties:
> + compatible:
> + enum:
> + - samsung,s5pv210-g2d # in S5PV210 & Exynos4210 SoC
> + - samsung,exynos4212-g2d # in Exynos4x12 SoCs
> + - samsung,exynos5250-g2d
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + oneOf:
> + - items: # for Exynos5250 SoC
> + - const: fimg2d
> + - items: # for S5PV210 and Exynos4 based SoCs
> + - const: sclk_fimg2d
> + - const: fimg2d
Just like in previous conversions ("dt-bindings: gpu: Convert Samsung
Image Scaler to dt-schem") - you need to add here proper if-else
constraints.
Best regards,
Krzysztof
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +examples
> + - |
> + g2d@12800000 {
> + compatible = "samsung,s5pv210-g2d";
> + reg = <0x12800000 0x1000>;
> + interrupts = <0 89 0>;
> + clocks = <&clock 177>, <&clock 277>;
> + clock-names = "sclk_fimg2d", "fimg2d";
> + };
> +
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-24 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190924113225eucas1p131429c7f7e0d520693b89bb2a7d9e211@eucas1p1.samsung.com>
2019-09-24 11:31 ` [PATCH] dt-bindings: gpu: Convert Samsung 2D Graphics Accelerator to dt-schema Marek Szyprowski
2019-09-24 11:44 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).