devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 01/49] dt: bindings: net: add qcom,ath11k.yaml
Date: Fri, 25 Oct 2019 16:30:28 -0500	[thread overview]
Message-ID: <20191025213028.GA5117@bogus> (raw)
In-Reply-To: <1571565847-10338-2-git-send-email-kvalo@codeaurora.org>

On Sun, Oct 20, 2019 at 01:03:19PM +0300, Kalle Valo wrote:
> ath11k is a driver for Qualcomm IEEE 802.11ax devices. Add a
> bindings document for the driver, first documenting IPQ8074 which is the
> only device ath11k currently supports.
> 
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> ---
>  .../bindings/net/wireless/qcom,ath11k.yaml         | 277 +++++++++++++++++++++
>  1 file changed, 277 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> new file mode 100644
> index 000000000000..5d25542f85f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -0,0 +1,277 @@
> +# SPDX-License-Identifier: BSD-3-Clause-Clear

(GPL-2.0-only OR BSD-2-Clause) please.

> +# Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath11k.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies ath11k wireless devices Generic Binding
> +
> +maintainers:
> +  - Kalle Valo <kvalo@codeaurora.org>
> +
> +description: |
> +  These are dt entries used on ath11k driver. AHB based ipq8074 uses most of the properties defined in this doc.

Describe the h/w, not what the document is.

Wrap your lines.

> +
> +properties:
> +  compatible:
> +    const: "qcom,ipq8074-wifi"

Drop quotes.

> +
> +  reg:
> +    description: Address and length of the register set for the device

Don't need a description.

> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 53
> +    maxItems: 53

Assuming the list below has 53 entries min/maxItems is implied.

> +    items:
> +      - description: misc-pulse1 interrupt events
> +      - description: misc-latch interrupt events
> +      - description: sw exception interrupt events
> +      - description: watchdog interrupt events
> +      - description: interrupt event for ring CE0
> +      - description: interrupt event for ring CE1
> +      - description: interrupt event for ring CE2
> +      - description: interrupt event for ring CE3
> +      - description: interrupt event for ring CE4
> +      - description: interrupt event for ring CE5
> +      - description: interrupt event for ring CE6
> +      - description: interrupt event for ring CE7
> +      - description: interrupt event for ring CE8
> +      - description: interrupt event for ring CE9
> +      - description: interrupt event for ring CE10
> +      - description: interrupt event for ring CE11
> +      - description: interrupt event for ring host2wbm-desc-feed
> +      - description: interrupt event for ring host2reo-re-injection
> +      - description: interrupt event for ring host2reo-command
> +      - description: interrupt event for ring host2rxdma-monitor-ring3
> +      - description: interrupt event for ring host2rxdma-monitor-ring2
> +      - description: interrupt event for ring host2rxdma-monitor-ring1
> +      - description: interrupt event for ring reo2ost-exception
> +      - description: interrupt event for ring wbm2host-rx-release
> +      - description: interrupt event for ring reo2host-status
> +      - description: interrupt event for ring reo2host-destination-ring4
> +      - description: interrupt event for ring reo2host-destination-ring3
> +      - description: interrupt event for ring reo2host-destination-ring2
> +      - description: interrupt event for ring reo2host-destination-ring1
> +      - description: interrupt event for ring rxdma2host-monitor-destination-mac3
> +      - description: interrupt event for ring rxdma2host-monitor-destination-mac2
> +      - description: interrupt event for ring rxdma2host-monitor-destination-mac1
> +      - description: interrupt event for ring ppdu-end-interrupts-mac3
> +      - description: interrupt event for ring ppdu-end-interrupts-mac2
> +      - description: interrupt event for ring ppdu-end-interrupts-mac1
> +      - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3
> +      - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2
> +      - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1
> +      - description: interrupt event for ring host2rxdma-host-buf-ring-mac3
> +      - description: interrupt event for ring host2rxdma-host-buf-ring-mac2
> +      - description: interrupt event for ring host2rxdma-host-buf-ring-mac1
> +      - description: interrupt event for ring rxdma2host-destination-ring-mac3
> +      - description: interrupt event for ring rxdma2host-destination-ring-mac2
> +      - description: interrupt event for ring rxdma2host-destination-ring-mac1
> +      - description: interrupt event for ring host2tcl-input-ring4
> +      - description: interrupt event for ring host2tcl-input-ring3
> +      - description: interrupt event for ring host2tcl-input-ring2
> +      - description: interrupt event for ring host2tcl-input-ring1
> +      - description: interrupt event for ring wbm2host-tx-completions-ring3
> +      - description: interrupt event for ring wbm2host-tx-completions-ring2
> +      - description: interrupt event for ring wbm2host-tx-completions-ring1
> +      - description: interrupt event for ring tcl2host-status-ring
> +
> +
> +  interrupt-names:
> +    minItems: 53
> +    maxItems: 53
> +    items:
> +      - const: misc-pulse1
> +      - const: misc-latch
> +      - const: sw-exception
> +      - const: watchdog
> +      - const: ce0
> +      - const: ce1
> +      - const: ce2
> +      - const: ce3
> +      - const: ce4
> +      - const: ce5
> +      - const: ce6
> +      - const: ce7
> +      - const: ce8
> +      - const: ce9
> +      - const: ce10
> +      - const: ce11
> +      - const: host2wbm-desc-feed
> +      - const: host2reo-re-injection
> +      - const: host2reo-command
> +      - const: host2rxdma-monitor-ring3
> +      - const: host2rxdma-monitor-ring2
> +      - const: host2rxdma-monitor-ring1
> +      - const: reo2ost-exception
> +      - const: wbm2host-rx-release
> +      - const: reo2host-status
> +      - const: reo2host-destination-ring4
> +      - const: reo2host-destination-ring3
> +      - const: reo2host-destination-ring2
> +      - const: reo2host-destination-ring1
> +      - const: rxdma2host-monitor-destination-mac3
> +      - const: rxdma2host-monitor-destination-mac2
> +      - const: rxdma2host-monitor-destination-mac1
> +      - const: ppdu-end-interrupts-mac3
> +      - const: ppdu-end-interrupts-mac2
> +      - const: ppdu-end-interrupts-mac1
> +      - const: rxdma2host-monitor-status-ring-mac3
> +      - const: rxdma2host-monitor-status-ring-mac2
> +      - const: rxdma2host-monitor-status-ring-mac1
> +      - const: host2rxdma-host-buf-ring-mac3
> +      - const: host2rxdma-host-buf-ring-mac2
> +      - const: host2rxdma-host-buf-ring-mac1
> +      - const: rxdma2host-destination-ring-mac3
> +      - const: rxdma2host-destination-ring-mac2
> +      - const: rxdma2host-destination-ring-mac1
> +      - const: host2tcl-input-ring4
> +      - const: host2tcl-input-ring3
> +      - const: host2tcl-input-ring2
> +      - const: host2tcl-input-ring1
> +      - const: wbm2host-tx-completions-ring3
> +      - const: wbm2host-tx-completions-ring2
> +      - const: wbm2host-tx-completions-ring1
> +      - const: tcl2host-status-ring
> +
> +  qcom,rproc:
> +    $ref: /schemas/types.yaml#definitions/phandle
> +    description:
> +      DT entry of q6v5-wcss remoteproc driver.
> +      Phandle to a node that can contain the following properties
> +        * compatible
> +        * reg
> +        * reg-names
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - qcom,rproc
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +
> +    q6v5_wcss: q6v5_wcss@CD00000 {
> +    	compatible = "qcom,ipq8074-wcss-pil";
> +    	reg = <0xCD00000 0x4040>,
> +    	      <0x4AB000 0x20>;
> +    	reg-names = "qdsp6",
> +    		    "rmb";

Mixed tabs and spaces. YAML needs spaces (at least at the beginning), so 
just use spaces. More below...

> +    };
> +
> +    wifi0: wifi@c000000 {
> +        	compatible = "qcom,ipq8074-wifi";
> +    	reg = <0xc000000 0x2000000>;
> +    	interrupts = <0 320 1>,
> +    		     <0 319 1>,
> +    		     <0 318 1>,
> +    		     <0 317 1>,
> +    		     <0 316 1>,
> +    		     <0 315 1>,
> +    		     <0 314 1>,
> +    		     <0 311 1>,
> +    		     <0 310 1>,
> +    		     <0 411 1>,
> +    		     <0 410 1>,
> +    		     <0 40 1>,
> +    		     <0 39 1>,
> +    		     <0 302 1>,
> +    		     <0 301 1>,
> +    		     <0 37 1>,
> +    		     <0 36 1>,
> +    		     <0 296 1>,
> +    		     <0 295 1>,
> +    		     <0 294 1>,
> +    		     <0 293 1>,
> +    		     <0 292 1>,
> +    		     <0 291 1>,
> +    		     <0 290 1>,
> +    		     <0 289 1>,
> +    		     <0 288 1>,
> +    		     <0 239 1>,
> +    		     <0 236 1>,
> +    		     <0 235 1>,
> +    		     <0 234 1>,
> +    		     <0 233 1>,
> +    		     <0 232 1>,
> +    		     <0 231 1>,
> +    		     <0 230 1>,
> +    		     <0 229 1>,
> +    		     <0 228 1>,
> +    		     <0 224 1>,
> +    		     <0 223 1>,
> +    		     <0 203 1>,
> +    		     <0 183 1>,
> +    		     <0 180 1>,
> +    		     <0 179 1>,
> +    		     <0 178 1>,
> +    		     <0 177 1>,
> +    		     <0 176 1>,
> +    		     <0 163 1>,
> +    		     <0 162 1>,
> +    		     <0 160 1>,
> +    		     <0 159 1>,
> +    		     <0 158 1>,
> +    		     <0 157 1>,
> +    		     <0 156 1>;
> +    	interrupt-names = "misc-pulse1",
> +    			  "misc-latch",
> +    			  "sw-exception",
> +    			  "watchdog",
> +    			  "ce0",
> +    			  "ce1",
> +    			  "ce2",
> +    			  "ce3",
> +    			  "ce4",
> +    			  "ce5",
> +    			  "ce6",
> +    			  "ce7",
> +    			  "ce8",
> +    			  "ce9",
> +    			  "ce10",
> +    			  "ce11",
> +    			  "host2wbm-desc-feed",
> +    			  "host2reo-re-injection",
> +    			  "host2reo-command",
> +    			  "host2rxdma-monitor-ring3",
> +    			  "host2rxdma-monitor-ring2",
> +    			  "host2rxdma-monitor-ring1",
> +    			  "reo2ost-exception",
> +    			  "wbm2host-rx-release",
> +    			  "reo2host-status",
> +    			  "reo2host-destination-ring4",
> +    			  "reo2host-destination-ring3",
> +    			  "reo2host-destination-ring2",
> +    			  "reo2host-destination-ring1",
> +    			  "rxdma2host-monitor-destination-mac3",
> +    			  "rxdma2host-monitor-destination-mac2",
> +    			  "rxdma2host-monitor-destination-mac1",
> +    			  "ppdu-end-interrupts-mac3",
> +    			  "ppdu-end-interrupts-mac2",
> +    			  "ppdu-end-interrupts-mac1",
> +    			  "rxdma2host-monitor-status-ring-mac3",
> +    			  "rxdma2host-monitor-status-ring-mac2",
> +    			  "rxdma2host-monitor-status-ring-mac1",
> +    			  "host2rxdma-host-buf-ring-mac3",
> +    			  "host2rxdma-host-buf-ring-mac2",
> +    			  "host2rxdma-host-buf-ring-mac1",
> +    			  "rxdma2host-destination-ring-mac3",
> +    			  "rxdma2host-destination-ring-mac2",
> +    			  "rxdma2host-destination-ring-mac1",
> +    			  "host2tcl-input-ring4",
> +    			  "host2tcl-input-ring3",
> +    			  "host2tcl-input-ring2",
> +    			  "host2tcl-input-ring1",
> +    			  "wbm2host-tx-completions-ring3",
> +    			  "wbm2host-tx-completions-ring2",
> +    			  "wbm2host-tx-completions-ring1",
> +    			  "tcl2host-status-ring";
> +    	qcom,rproc = <&q6v5_wcss>;
> +    };
> 

  reply	other threads:[~2019-10-25 21:30 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20 10:03 [PATCH v2 00/49] ath11k: driver for Qualcomm IEEE 802.11ax devices Kalle Valo
2019-10-20 10:03 ` [PATCH v2 01/49] dt: bindings: net: add qcom,ath11k.yaml Kalle Valo
2019-10-25 21:30   ` Rob Herring [this message]
2019-10-27 13:28     ` Kalle Valo
2019-10-27 20:56       ` Rob Herring
2019-11-05 14:55         ` Kalle Valo
2019-11-07 15:38     ` Kalle Valo
2019-11-15 12:18       ` Kalle Valo
2019-10-20 10:03 ` [PATCH v2 02/49] ath11k: add Kconfig Kalle Valo
2019-10-21 20:53   ` Jeff Johnson
2019-11-07 16:04     ` Kalle Valo
2019-10-20 10:03 ` [PATCH v2 03/49] ath11k: add Makefile Kalle Valo
2019-10-20 10:03 ` [PATCH v2 04/49] ath11k: add ahb.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 05/49] ath11k: add ahb.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 06/49] ath11k: add ce.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 07/49] ath11k: add ce.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 08/49] ath11k: add core.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 09/49] ath11k: add core.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 10/49] ath11k: add debug.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 11/49] ath11k: add debug.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 12/49] ath11k: add debug_htt_stats.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 13/49] ath11k: add debug_htt_stats.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 14/49] ath11k: add debugfs_sta.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 15/49] ath11k: add dp.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 16/49] ath11k: add dp.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 17/49] ath11k: add dp_rx.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 18/49] ath11k: add dp_rx.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 19/49] ath11k: add dp_tx.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 20/49] ath11k: add dp_tx.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 21/49] ath11k: add hal.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 22/49] ath11k: add hal.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 23/49] ath11k: add hal_desc.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 24/49] ath11k: add hal_rx.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 25/49] ath11k: add hal_rx.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 26/49] ath11k: add hal_tx.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 27/49] ath11k: add hal_tx.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 28/49] ath11k: add htc.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 29/49] ath11k: add htc.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 30/49] ath11k: add hw.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 31/49] ath11k: add mac.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 32/49] ath11k: add mac.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 33/49] ath11k: add peer.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 34/49] ath11k: add peer.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 35/49] ath11k: add qmi.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 36/49] ath11k: add qmi.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 37/49] ath11k: add reg.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 38/49] ath11k: add reg.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 39/49] ath11k: add rx_desc.h Kalle Valo
2019-10-20 10:03 ` [PATCH v2 40/49] ath11k: add testmode.c Kalle Valo
2019-10-20 10:03 ` [PATCH v2 41/49] ath11k: add testmode.h Kalle Valo
2019-10-20 10:04 ` [PATCH v2 42/49] ath11k: add testmode_i.h Kalle Valo
2019-10-20 10:04 ` [PATCH v2 43/49] ath11k: add trace.c Kalle Valo
2019-10-20 10:04 ` [PATCH v2 44/49] ath11k: add trace.h Kalle Valo
2019-10-20 10:04 ` [PATCH v2 45/49] ath11k: add wmi.c Kalle Valo
2019-10-20 10:04 ` [PATCH v2 46/49] ath11k: add wmi.h Kalle Valo
2019-10-20 10:04 ` [PATCH v2 47/49] ath: add ath11k to Makefile Kalle Valo
2019-10-20 10:04 ` [PATCH v2 48/49] ath: add ath11k to Kconfig Kalle Valo
2019-10-20 10:04 ` [PATCH v2 49/49] MAINTAINERS: add ath11k Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025213028.GA5117@bogus \
    --to=robh@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).