* [PATCH] arm64: dts: rockchip: rockpro64: fix ES8316 i2c address
@ 2019-11-12 1:15 Vasily Khoruzhick
2019-11-12 7:38 ` Vasily Khoruzhick
0 siblings, 1 reply; 2+ messages in thread
From: Vasily Khoruzhick @ 2019-11-12 1:15 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Heiko Stuebner, Akash Gajjar,
Katsuhiro Suzuki, devicetree, linux-arm-kernel, linux-rockchip
Cc: Vasily Khoruzhick
According to Rockpro64 schematics [1] CE pin of ES8316 is wired
to ground, so codec address should be 0x10.
[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
Fixes: 6860769ea771 ("arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64")
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
index 7f4b2eba31d4..18bbe548839b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
@@ -477,9 +477,9 @@
i2c-scl-falling-time-ns = <15>;
status = "okay";
- es8316: codec@11 {
+ es8316: codec@10 {
compatible = "everest,es8316";
- reg = <0x11>;
+ reg = <0x10>;
clocks = <&cru SCLK_I2S_8CH_OUT>;
clock-names = "mclk";
#sound-dai-cells = <0>;
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rockpro64: fix ES8316 i2c address
2019-11-12 1:15 [PATCH] arm64: dts: rockchip: rockpro64: fix ES8316 i2c address Vasily Khoruzhick
@ 2019-11-12 7:38 ` Vasily Khoruzhick
0 siblings, 0 replies; 2+ messages in thread
From: Vasily Khoruzhick @ 2019-11-12 7:38 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Heiko Stuebner, Akash Gajjar,
Katsuhiro Suzuki, devicetree, arm-linux, linux-rockchip
On Mon, Nov 11, 2019 at 5:15 PM Vasily Khoruzhick <anarsoul@gmail.com> wrote:
>
> According to Rockpro64 schematics [1] CE pin of ES8316 is wired
> to ground, so codec address should be 0x10.
>
> [1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
Please don't merge it yet, it appears that on Katsuhiro's board codec
is at address 0x11.
> Fixes: 6860769ea771 ("arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64")
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> index 7f4b2eba31d4..18bbe548839b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> @@ -477,9 +477,9 @@
> i2c-scl-falling-time-ns = <15>;
> status = "okay";
>
> - es8316: codec@11 {
> + es8316: codec@10 {
> compatible = "everest,es8316";
> - reg = <0x11>;
> + reg = <0x10>;
> clocks = <&cru SCLK_I2S_8CH_OUT>;
> clock-names = "mclk";
> #sound-dai-cells = <0>;
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-12 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 1:15 [PATCH] arm64: dts: rockchip: rockpro64: fix ES8316 i2c address Vasily Khoruzhick
2019-11-12 7:38 ` Vasily Khoruzhick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).