* [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs.
@ 2019-11-22 6:18 Hui Song
2019-11-22 13:01 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Hui Song @ 2019-11-22 6:18 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Linus Walleij,
Bartosz Golaszewski
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-gpio, Song Hui
From: Song Hui <hui.song_1@nxp.com>
On these boards, the irq_set_type must point one valid function pointer
that can correctly set both edge and falling edge.
Signed-off-by: Song Hui <hui.song_1@nxp.com>
---
drivers/gpio/gpio-mpc8xxx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 81f0f31..8ddb23b 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -296,6 +296,7 @@ static const struct mpc8xxx_gpio_devtype mpc512x_gpio_devtype = {
static const struct mpc8xxx_gpio_devtype ls1028a_gpio_devtype = {
.gpio_dir_in_init = ls1028a_gpio_dir_in_init,
+ .irq_set_type = mpc8xxx_irq_set_type,
};
static const struct mpc8xxx_gpio_devtype mpc5125_gpio_devtype = {
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs.
2019-11-22 6:18 [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs Hui Song
@ 2019-11-22 13:01 ` Linus Walleij
2019-11-22 13:08 ` Michael Walle
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2019-11-22 13:01 UTC (permalink / raw)
To: Hui Song
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland,
Bartosz Golaszewski, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, open list:GPIO SUBSYSTEM
On Fri, Nov 22, 2019 at 7:18 AM Hui Song <hui.song_1@nxp.com> wrote:
> From: Song Hui <hui.song_1@nxp.com>
>
> On these boards, the irq_set_type must point one valid function pointer
> that can correctly set both edge and falling edge.
>
> Signed-off-by: Song Hui <hui.song_1@nxp.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs.
2019-11-22 13:01 ` Linus Walleij
@ 2019-11-22 13:08 ` Michael Walle
2019-11-22 13:29 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Michael Walle @ 2019-11-22 13:08 UTC (permalink / raw)
To: linus.walleij
Cc: bgolaszewski, devicetree, hui.song_1, leoyang.li,
linux-arm-kernel, linux-gpio, linux-kernel, mark.rutland,
robh+dt, shawnguo
>> From: Song Hui <hui.song_1@nxp.com>
>>
>> On these boards, the irq_set_type must point one valid function
>> pointer
>> that can correctly set both edge and falling edge.
>>
>> Signed-off-by: Song Hui <hui.song_1@nxp.com>
>
> Patch applied!
>
> Yours,
> Linus Walleij
mhh.. this bug should already be fixed in a better way with [1]:
gpio: mpc8xxx: Don't overwrite default irq_set_type callback
-michael
[1]
https://lore.kernel.org/lkml/CACRpkdZ5eWHEV-oN77QxH9X4DZRUB3zM=gP=+rM=ZLAX6Wxw9w@mail.gmail.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs.
2019-11-22 13:08 ` Michael Walle
@ 2019-11-22 13:29 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-11-22 13:29 UTC (permalink / raw)
To: Michael Walle
Cc: Bartosz Golaszewski,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Hui Song, Leo Li, Linux ARM, open list:GPIO SUBSYSTEM,
linux-kernel, Mark Rutland, Rob Herring, Shawn Guo
On Fri, Nov 22, 2019 at 2:08 PM Michael Walle <michael@walle.cc> wrote:
> >> From: Song Hui <hui.song_1@nxp.com>
> >>
> >> On these boards, the irq_set_type must point one valid function
> >> pointer
> >> that can correctly set both edge and falling edge.
> >>
> >> Signed-off-by: Song Hui <hui.song_1@nxp.com>
> >
> > Patch applied!
> >
> > Yours,
> > Linus Walleij
>
> mhh.. this bug should already be fixed in a better way with [1]:
> gpio: mpc8xxx: Don't overwrite default irq_set_type callback
OK I drop this patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-22 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 6:18 [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs Hui Song
2019-11-22 13:01 ` Linus Walleij
2019-11-22 13:08 ` Michael Walle
2019-11-22 13:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).