devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: ti: k3-j721e-main: Add missing power-domains for smmu
@ 2019-11-22 10:03 Lokesh Vutla
  2020-01-06  4:00 ` Lokesh Vutla
  0 siblings, 1 reply; 3+ messages in thread
From: Lokesh Vutla @ 2019-11-22 10:03 UTC (permalink / raw)
  To: Tero Kristo, Nishanth Menon
  Cc: Device Tree Mailing List, Rob Herring, Linux ARM Mailing List,
	Lokesh Vutla, Sekhar Nori, Suman Anna

Add power-domains entry for smmu, so that the it is accessible as long
as the driver is active. Without this device shutdown is throwing the
below warning:
"[   44.736348] arm-smmu-v3 36600000.smmu: failed to clear cr0"

Reported-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 698ef9a1d5b7..96445111e398 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -43,6 +43,7 @@
 	smmu0: smmu@36600000 {
 		compatible = "arm,smmu-v3";
 		reg = <0x0 0x36600000 0x0 0x100000>;
+		power-domains = <&k3_pds 229 TI_SCI_PD_EXCLUSIVE>;
 		interrupt-parent = <&gic500>;
 		interrupts = <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>,
 			     <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>;
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-j721e-main: Add missing power-domains for smmu
  2019-11-22 10:03 [PATCH] arm64: dts: ti: k3-j721e-main: Add missing power-domains for smmu Lokesh Vutla
@ 2020-01-06  4:00 ` Lokesh Vutla
  2020-01-17 12:58   ` Tero Kristo
  0 siblings, 1 reply; 3+ messages in thread
From: Lokesh Vutla @ 2020-01-06  4:00 UTC (permalink / raw)
  To: Tero Kristo, Nishanth Menon
  Cc: Device Tree Mailing List, Rob Herring, Linux ARM Mailing List,
	Sekhar Nori, Suman Anna

H Tero,

On 22/11/19 3:33 PM, Lokesh Vutla wrote:
> Add power-domains entry for smmu, so that the it is accessible as long
> as the driver is active. Without this device shutdown is throwing the
> below warning:
> "[   44.736348] arm-smmu-v3 36600000.smmu: failed to clear cr0"
> 
> Reported-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Any comments on this patch? If there are no objections, can this be picked?

Thanks and regards,
Lokesh

> ---
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 698ef9a1d5b7..96445111e398 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -43,6 +43,7 @@
>  	smmu0: smmu@36600000 {
>  		compatible = "arm,smmu-v3";
>  		reg = <0x0 0x36600000 0x0 0x100000>;
> +		power-domains = <&k3_pds 229 TI_SCI_PD_EXCLUSIVE>;
>  		interrupt-parent = <&gic500>;
>  		interrupts = <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>,
>  			     <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-j721e-main: Add missing power-domains for smmu
  2020-01-06  4:00 ` Lokesh Vutla
@ 2020-01-17 12:58   ` Tero Kristo
  0 siblings, 0 replies; 3+ messages in thread
From: Tero Kristo @ 2020-01-17 12:58 UTC (permalink / raw)
  To: Lokesh Vutla, Nishanth Menon
  Cc: Device Tree Mailing List, Rob Herring, Linux ARM Mailing List,
	Sekhar Nori, Suman Anna

On 06/01/2020 06:00, Lokesh Vutla wrote:
> H Tero,
> 
> On 22/11/19 3:33 PM, Lokesh Vutla wrote:
>> Add power-domains entry for smmu, so that the it is accessible as long
>> as the driver is active. Without this device shutdown is throwing the
>> below warning:
>> "[   44.736348] arm-smmu-v3 36600000.smmu: failed to clear cr0"
>>
>> Reported-by: Suman Anna <s-anna@ti.com>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> 
> Any comments on this patch? If there are no objections, can this be picked?

Sorry for delay, I've been engulfed with various other pieces of work 
and handling upstream has been quite slow.

Anyways, for this patch, queued up for 5.6, thanks!

-Tero

> 
> Thanks and regards,
> Lokesh
> 
>> ---
>>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> index 698ef9a1d5b7..96445111e398 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> @@ -43,6 +43,7 @@
>>   	smmu0: smmu@36600000 {
>>   		compatible = "arm,smmu-v3";
>>   		reg = <0x0 0x36600000 0x0 0x100000>;
>> +		power-domains = <&k3_pds 229 TI_SCI_PD_EXCLUSIVE>;
>>   		interrupt-parent = <&gic500>;
>>   		interrupts = <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>,
>>   			     <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>;
>>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-17 12:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 10:03 [PATCH] arm64: dts: ti: k3-j721e-main: Add missing power-domains for smmu Lokesh Vutla
2020-01-06  4:00 ` Lokesh Vutla
2020-01-17 12:58   ` Tero Kristo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).