* [PATCH] dtc: checks: check_graph_port: skip node name check in overlay case
@ 2019-11-22 19:16 Benoit Parrot
2019-12-17 16:06 ` Benoit Parrot
0 siblings, 1 reply; 2+ messages in thread
From: Benoit Parrot @ 2019-11-22 19:16 UTC (permalink / raw)
To: Rob Herring
Cc: Maxime Ripard, devicetree, linux-kernel, Tomi Valkeinen,
Peter Ujfalusi, Jyri Sarha, Benoit Parrot
In check_graph_port() we need to skip the node name check in the overlay
case as it causes a false positive warning.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
checks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/checks.c b/checks.c
index 756f0fa9203f..6b6712da146a 100644
--- a/checks.c
+++ b/checks.c
@@ -1707,7 +1707,8 @@ static void check_graph_port(struct check *c, struct dt_info *dti,
if (node->bus != &graph_port_bus)
return;
- if (!strprefixeq(node->name, node->basenamelen, "port"))
+ if (!strprefixeq(node->name, node->basenamelen, "port") &&
+ !(dti->dtsflags & DTSF_PLUGIN))
FAIL(c, dti, node, "graph port node name should be 'port'");
check_graph_reg(c, dti, node);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dtc: checks: check_graph_port: skip node name check in overlay case
2019-11-22 19:16 [PATCH] dtc: checks: check_graph_port: skip node name check in overlay case Benoit Parrot
@ 2019-12-17 16:06 ` Benoit Parrot
0 siblings, 0 replies; 2+ messages in thread
From: Benoit Parrot @ 2019-12-17 16:06 UTC (permalink / raw)
To: Rob Herring
Cc: Maxime Ripard, devicetree, linux-kernel, Tomi Valkeinen,
Peter Ujfalusi, Jyri Sarha
Ping!
Benoit Parrot <bparrot@ti.com> wrote on Fri [2019-Nov-22 13:16:31 -0600]:
> In check_graph_port() we need to skip the node name check in the overlay
> case as it causes a false positive warning.
>
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> ---
> checks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/checks.c b/checks.c
> index 756f0fa9203f..6b6712da146a 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -1707,7 +1707,8 @@ static void check_graph_port(struct check *c, struct dt_info *dti,
> if (node->bus != &graph_port_bus)
> return;
>
> - if (!strprefixeq(node->name, node->basenamelen, "port"))
> + if (!strprefixeq(node->name, node->basenamelen, "port") &&
> + !(dti->dtsflags & DTSF_PLUGIN))
> FAIL(c, dti, node, "graph port node name should be 'port'");
>
> check_graph_reg(c, dti, node);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-17 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 19:16 [PATCH] dtc: checks: check_graph_port: skip node name check in overlay case Benoit Parrot
2019-12-17 16:06 ` Benoit Parrot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).