devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: broonie@kernel.org, lee.jones@linaro.org,
	linus.walleij@linaro.org, vinod.koul@linaro.org,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, spapothi@codeaurora.org,
	bgoswami@codeaurora.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v4 09/12] dt-bindings: gpio: wcd934x: Add bindings for gpio
Date: Fri, 22 Nov 2019 18:15:58 -0600	[thread overview]
Message-ID: <20191123001356.GA5528@bogus> (raw)
In-Reply-To: <20191121170509.10579-10-srinivas.kandagatla@linaro.org>

On Thu, Nov 21, 2019 at 05:05:06PM +0000, Srinivas Kandagatla wrote:
> Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated
> gpio controller to control 5 gpios on the chip. This patch adds
> required device tree bindings for it.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  .../bindings/gpio/qcom,wcd934x-gpio.yaml      | 47 +++++++++++++++++++
>  1 file changed, 47 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml

Reviewed-by: Rob Herring <robh@kernel.org>

However, this should be referenced from the main file:

gpio@42:
  type: object
  allOf:
    - $ref: ../gpio/qcom,wcd934x-gpio.yaml#

And better to move the example there to be complete.

Rob

  reply	other threads:[~2019-11-23  0:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 17:04 [PATCH v4 00/12] ASoC: Add support to WCD9340/WCD9341 codec Srinivas Kandagatla
2019-11-21 17:04 ` [PATCH v4 01/12] dt-bindings: SLIMBus: add slim devices optional properties Srinivas Kandagatla
2019-11-23  0:04   ` Rob Herring
2019-11-21 17:04 ` [PATCH v4 02/12] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec Srinivas Kandagatla
2019-11-23  0:09   ` Rob Herring
2019-11-21 17:05 ` [PATCH v4 03/12] mfd: wcd934x: add support to wcd9340/wcd9341 codec Srinivas Kandagatla
2019-12-09 13:16   ` Lee Jones
2019-11-21 17:05 ` [PATCH v4 04/12] ASoC: " Srinivas Kandagatla
2019-11-21 17:05 ` [PATCH v4 05/12] ASoC: wcd934x: add basic controls Srinivas Kandagatla
2019-11-21 17:05 ` [PATCH v4 06/12] ASoC: wcd934x: add playback dapm widgets Srinivas Kandagatla
2019-11-21 17:05 ` [PATCH v4 07/12] ASoC: wcd934x: add capture " Srinivas Kandagatla
2019-11-21 17:05 ` [PATCH v4 08/12] ASoC: wcd934x: add audio routings Srinivas Kandagatla
2019-11-21 17:05 ` [PATCH v4 09/12] dt-bindings: gpio: wcd934x: Add bindings for gpio Srinivas Kandagatla
2019-11-23  0:15   ` Rob Herring [this message]
2019-11-21 17:05 ` [PATCH v4 10/12] gpio: wcd934x: Add support to wcd934x gpio controller Srinivas Kandagatla
2019-11-21 17:05 ` [PATCH v4 11/12] ASoC: qcom: dt-bindings: Add compatible for DB845c and Lenovo Yoga Srinivas Kandagatla
2019-11-21 17:05 ` [PATCH v4 12/12] ASoC: qcom: sdm845: add support to " Srinivas Kandagatla
2020-05-08 17:13 ` [PATCH v4 00/12] ASoC: Add support to WCD9340/WCD9341 codec Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191123001356.GA5528@bogus \
    --to=robh@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spapothi@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vinod.koul@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).