From: Corey Minyard <minyard@acm.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openipmi-developer@lists.sourceforge.net, robh+dt@kernel.org,
mark.rutland@arm.com, joel@jms.id.au, arnd@arndb.de,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Haiyue Wang <haiyue.wang@linux.intel.com>
Subject: Re: [PATCH 2/3] ipmi: kcs: Finish configuring ASPEED KCS device before enable
Date: Tue, 3 Dec 2019 07:40:26 -0600 [thread overview]
Message-ID: <20191203134026.GI18165@minyard.net> (raw)
In-Reply-To: <84315a29b453068373c096c03433e3a326731988.1575376664.git-series.andrew@aj.id.au>
On Tue, Dec 03, 2019 at 11:08:24PM +1030, Andrew Jeffery wrote:
> The currently interrupts are configured after the channel was enabled.
How about:
The interrupts were configured after the channel was enabled, configure
them before so they will work.
-corey
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
> index 3c955946e647..e3dd09022589 100644
> --- a/drivers/char/ipmi/kcs_bmc_aspeed.c
> +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
> @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
> kcs_bmc->io_inputb = aspeed_kcs_inb;
> kcs_bmc->io_outputb = aspeed_kcs_outb;
>
> + rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
> + if (rc)
> + return rc;
> +
> dev_set_drvdata(dev, kcs_bmc);
>
> aspeed_kcs_set_address(kcs_bmc, addr);
> aspeed_kcs_enable_channel(kcs_bmc, true);
> - rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
> - if (rc)
> - return rc;
>
> rc = misc_register(&kcs_bmc->miscdev);
> if (rc) {
> --
> git-series 0.9.1
next prev parent reply other threads:[~2019-12-03 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 12:38 [PATCH 0/3] ipmi: kcs-bmc: Rework bindings to clean up DT warnings Andrew Jeffery
2019-12-03 12:38 ` [PATCH 1/3] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS Andrew Jeffery
2019-12-03 14:31 ` Rob Herring
2019-12-05 5:13 ` Andrew Jeffery
2019-12-05 17:50 ` Rob Herring
2019-12-05 23:19 ` Andrew Jeffery
2019-12-03 12:38 ` [PATCH 2/3] ipmi: kcs: Finish configuring ASPEED KCS device before enable Andrew Jeffery
2019-12-03 13:40 ` Corey Minyard [this message]
2019-12-05 5:15 ` Andrew Jeffery
2019-12-03 12:38 ` [PATCH 3/3] ipmi: kcs: aspeed: Implement v2 bindings Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203134026.GI18165@minyard.net \
--to=minyard@acm.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyue.wang@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).