From: Rob Herring <robh@kernel.org>
To: haibo.chen@nxp.com
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
mark.rutland@arm.com, kernel@pengutronix.de,
devicetree@vger.kernel.org, festevam@gmail.com,
linux-mmc@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH 12/14] doc: dt: fsl-imx-esdhc: add auto-cmd23-broken binding
Date: Tue, 3 Dec 2019 13:27:33 -0600 [thread overview]
Message-ID: <20191203192733.GA24286@bogus> (raw)
In-Reply-To: <1573816606-26779-2-git-send-email-haibo.chen@nxp.com>
On Fri, Nov 15, 2019 at 07:16:46PM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Add fsl,auto-cmd23-broken binding.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> index d50144f5f1d2..a776f418a028 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> @@ -43,6 +43,14 @@ Optional properties:
> property allows user to change the delay target for the strobe input read clock.
> If not use this property, driver default set the delay target to value 7.
> Only eMMC HS400 mode need to take care of this property.
> +- fsl,auto-cmd23-broken: disable the ACMD23 function of USDHC.
> + This is required for eMMC on imx6qpdl/imx6sx/imx7d when it use ADMA mode. Because
> + for these SoC, it do not support the ACMD23 completely, only take the 16 bit block
> + count from the 0x4 register (BLK_ATT) as argument for the ACMD23, the upper 16 bit
> + of the CMD23's argument is ignored. This will impact the reliable write operation
> + and the RPMB block write operation, because these operations need to set the bit 31
> + of the CMD23's argument. SDMA mode will default disable the ACMD23 mode. SD card do
> + not has this limitation on these SoCs.
Use the compatible string or perhaps the version register like the
sdhci-esdhc driver does.
Rob
next prev parent reply other threads:[~2019-12-03 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 11:16 [PATCH 08/14] doc: dt: fsl-imx-esdhc: add strobe-dll-delay-target binding haibo.chen
2019-11-15 11:16 ` [PATCH 12/14] doc: dt: fsl-imx-esdhc: add auto-cmd23-broken binding haibo.chen
2019-12-03 19:27 ` Rob Herring [this message]
2019-12-03 19:21 ` [PATCH 08/14] doc: dt: fsl-imx-esdhc: add strobe-dll-delay-target binding Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203192733.GA24286@bogus \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).