From: Rob Herring <robh@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Levin Du <djw@t-chip.com.cn>,
Akash Gajjar <akash@openedev.com>,
Mark Rutland <mark.rutland@arm.com>, Da Xue <da@lessconfused.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding
Date: Tue, 3 Dec 2019 16:37:04 -0600 [thread overview]
Message-ID: <20191203223704.GA29109@bogus> (raw)
In-Reply-To: <20191119185817.11216-1-jagan@amarulasolutions.com>
On Wed, Nov 20, 2019 at 12:28:16AM +0530, Jagan Teki wrote:
> Though the ROC-PC is manufactured by firefly, it is co-designed
> by libretch like other Libretech computer boards from allwinner,
> amlogic does.
>
> It is always meaningful to keep maintain those vendors who are
> part of design participation, so add libretech roc-pc compatible
> with existing binding.
Maybe so, but this is pretty pointless if it's not different h/w.
Compatible strings are simply a h/w identifier.
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index f7470ed1e17d..45728fd22af8 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -100,6 +100,7 @@ properties:
> - description: Firefly ROC-RK3399-PC
> items:
> - enum:
> + - libretech,roc-rk3399-pc
> - firefly,roc-rk3399-pc
> - firefly,roc-rk3399-pc-mezzanine
This doesn't match your change in the dts. file. The schema says there
are 2 strings with the first one being 1 of these 3.
> - const: rockchip,rk3399
> --
> 2.18.0.321.gffc6fa0e3
>
prev parent reply other threads:[~2019-12-03 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 18:58 [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Jagan Teki
2019-11-19 18:58 ` [PATCH v2 2/2] arm64: dts: rockchip: Add libretech compatible for ROC-PC Jagan Teki
2019-12-03 22:37 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203223704.GA29109@bogus \
--to=robh@kernel.org \
--cc=akash@openedev.com \
--cc=da@lessconfused.com \
--cc=devicetree@vger.kernel.org \
--cc=djw@t-chip.com.cn \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).