Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding
@ 2019-11-19 18:58 Jagan Teki
  2019-11-19 18:58 ` [PATCH v2 2/2] arm64: dts: rockchip: Add libretech compatible for ROC-PC Jagan Teki
  2019-12-03 22:37 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Jagan Teki @ 2019-11-19 18:58 UTC (permalink / raw)
  To: Heiko Stuebner, Levin Du, Akash Gajjar, Rob Herring, Mark Rutland
  Cc: Da Xue, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, linux-amarula, Jagan Teki

Though the ROC-PC is manufactured by firefly, it is co-designed
by libretch like other Libretech computer boards from allwinner,
amlogic does.

It is always meaningful to keep maintain those vendors who are
part of design participation, so add libretech roc-pc compatible
with existing binding.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index f7470ed1e17d..45728fd22af8 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -100,6 +100,7 @@ properties:
       - description: Firefly ROC-RK3399-PC
         items:
           - enum:
+              - libretech,roc-rk3399-pc
               - firefly,roc-rk3399-pc
               - firefly,roc-rk3399-pc-mezzanine
           - const: rockchip,rk3399
-- 
2.18.0.321.gffc6fa0e3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] arm64: dts: rockchip: Add libretech compatible for ROC-PC
  2019-11-19 18:58 [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Jagan Teki
@ 2019-11-19 18:58 ` Jagan Teki
  2019-12-03 22:37 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Jagan Teki @ 2019-11-19 18:58 UTC (permalink / raw)
  To: Heiko Stuebner, Levin Du, Akash Gajjar, Rob Herring, Mark Rutland
  Cc: Da Xue, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, linux-amarula, Jagan Teki

Though the ROC-PC is manufactured by firefly, it is co-designed
by libretch like other Libretech computer boards from allwinner,
amlogic does.

So, it is always meaningful to keep maintain those vendors who
are part of design participation so append the compatible
"libretech,roc-rk3399-pc" to existing roc-pc dts file.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
index cd4195425309..6a909e4eefd2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
@@ -8,5 +8,6 @@
 
 / {
 	model = "Firefly ROC-RK3399-PC Board";
-	compatible = "firefly,roc-rk3399-pc", "rockchip,rk3399";
+	compatible = "libretech,roc-rk3399-pc", "firefly,roc-rk3399-pc",
+		     "rockchip,rk3399";
 };
-- 
2.18.0.321.gffc6fa0e3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding
  2019-11-19 18:58 [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Jagan Teki
  2019-11-19 18:58 ` [PATCH v2 2/2] arm64: dts: rockchip: Add libretech compatible for ROC-PC Jagan Teki
@ 2019-12-03 22:37 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-12-03 22:37 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Heiko Stuebner, Levin Du, Akash Gajjar, Mark Rutland, Da Xue,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	linux-amarula

On Wed, Nov 20, 2019 at 12:28:16AM +0530, Jagan Teki wrote:
> Though the ROC-PC is manufactured by firefly, it is co-designed
> by libretch like other Libretech computer boards from allwinner,
> amlogic does.
> 
> It is always meaningful to keep maintain those vendors who are
> part of design participation, so add libretech roc-pc compatible
> with existing binding.

Maybe so, but this is pretty pointless if it's not different h/w. 
Compatible strings are simply a h/w identifier.

> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index f7470ed1e17d..45728fd22af8 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -100,6 +100,7 @@ properties:
>        - description: Firefly ROC-RK3399-PC
>          items:
>            - enum:
> +              - libretech,roc-rk3399-pc
>                - firefly,roc-rk3399-pc
>                - firefly,roc-rk3399-pc-mezzanine

This doesn't match your change in the dts. file. The schema says there 
are 2 strings with the first one being 1 of these 3.

>            - const: rockchip,rk3399
> -- 
> 2.18.0.321.gffc6fa0e3
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 18:58 [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Jagan Teki
2019-11-19 18:58 ` [PATCH v2 2/2] arm64: dts: rockchip: Add libretech compatible for ROC-PC Jagan Teki
2019-12-03 22:37 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Rob Herring

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git