From: Simon Horman <simon.horman@netronome.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@vger.kernel.org, grygorii.strashko@ti.com,
robh+dt@kernel.org, rafal@milecki.pl, davem@davemloft.net,
andrew@lunn.ch, mark.rutland@arm.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells
Date: Fri, 6 Dec 2019 10:31:51 +0100 [thread overview]
Message-ID: <20191206093150.GA27144@netronome.com> (raw)
In-Reply-To: <20191206000421.12541-1-f.fainelli@gmail.com>
On Thu, Dec 05, 2019 at 04:04:21PM -0800, Florian Fainelli wrote:
> The MDIO node on BCM5301X had an reversed #address-cells and
> #size-cells properties, correct those, silencing checker warnings:
>
> .../linux/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: mdio@18003000: #address-cells:0:0: 1 was expected
>
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Fixes: 23f1eca6d59b ("ARM: dts: BCM5301X: Specify MDIO bus in the DT")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks, make dtbs_check seems a lot happier now.
Reviewed-by: Simon Horman <simon.horman@netronome.com>
FWIIW, I think a similar change might also be in order for bcm-cygnus.dtsi.
> ---
> arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 372dc1eb88a0..2d9b4dd05830 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -353,8 +353,8 @@
> mdio: mdio@18003000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18003000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> };
>
> mdio-bus-mux@18003000 {
> --
> 2.17.1
>
prev parent reply other threads:[~2019-12-06 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 0:04 [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells Florian Fainelli
2019-12-06 9:31 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206093150.GA27144@netronome.com \
--to=simon.horman@netronome.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).