* [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells
@ 2019-12-06 0:04 Florian Fainelli
2019-12-06 9:31 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2019-12-06 0:04 UTC (permalink / raw)
To: linux-arm-kernel
Cc: grygorii.strashko, simon.horman, robh+dt, rafal, davem, andrew,
mark.rutland, devicetree, netdev, Florian Fainelli
The MDIO node on BCM5301X had an reversed #address-cells and
#size-cells properties, correct those, silencing checker warnings:
.../linux/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: mdio@18003000: #address-cells:0:0: 1 was expected
Reported-by: Simon Horman <simon.horman@netronome.com>
Fixes: 23f1eca6d59b ("ARM: dts: BCM5301X: Specify MDIO bus in the DT")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 372dc1eb88a0..2d9b4dd05830 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -353,8 +353,8 @@
mdio: mdio@18003000 {
compatible = "brcm,iproc-mdio";
reg = <0x18003000 0x8>;
- #size-cells = <1>;
- #address-cells = <0>;
+ #size-cells = <0>;
+ #address-cells = <1>;
};
mdio-bus-mux@18003000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells
2019-12-06 0:04 [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells Florian Fainelli
@ 2019-12-06 9:31 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2019-12-06 9:31 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, grygorii.strashko, robh+dt, rafal, davem,
andrew, mark.rutland, devicetree, netdev
On Thu, Dec 05, 2019 at 04:04:21PM -0800, Florian Fainelli wrote:
> The MDIO node on BCM5301X had an reversed #address-cells and
> #size-cells properties, correct those, silencing checker warnings:
>
> .../linux/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: mdio@18003000: #address-cells:0:0: 1 was expected
>
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Fixes: 23f1eca6d59b ("ARM: dts: BCM5301X: Specify MDIO bus in the DT")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks, make dtbs_check seems a lot happier now.
Reviewed-by: Simon Horman <simon.horman@netronome.com>
FWIIW, I think a similar change might also be in order for bcm-cygnus.dtsi.
> ---
> arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 372dc1eb88a0..2d9b4dd05830 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -353,8 +353,8 @@
> mdio: mdio@18003000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18003000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> };
>
> mdio-bus-mux@18003000 {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-06 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 0:04 [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells Florian Fainelli
2019-12-06 9:31 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).