devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"H . Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] ARM: dts: e60k02: fix power button
Date: Mon, 9 Dec 2019 08:56:26 +0800	[thread overview]
Message-ID: <20191209005621.GO3365@dragon> (raw)
In-Reply-To: <20191205070612.27204646@kemnade.info>

On Thu, Dec 05, 2019 at 07:06:12AM +0100, Andreas Kemnade wrote:
> On Wed, 4 Dec 2019 20:36:47 +0800
> Shawn Guo <shawnguo@kernel.org> wrote:
> 
> > On Mon, Nov 11, 2019 at 09:29:59PM +0100, Andreas Kemnade wrote:
> > > The power button was only producing irqs, but no key events,
> > > Forced power down with long key press works, so probably
> > > only a short spike arrives at the SoC.
> > > Further investigation shows that LDORTC2 is off after boot
> > > of the vendor kernel. LDORTC2 is shared with a GPIO at the pmic
> > > which probably transfers the button press to the SoC.
> > > That regulator off at boot, so "regulator-boot-on" is definitively
> > > wrong. So remove that.
> > > 
> > > Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>  
> > 
> > Do you want this go into 5.5-rc as a fix?  In that case, we may need a
> > Fixes tag here.
> > 
> well, now there is 
> regulator: core: Let boot-on regulators be powered off
> so the power button should work after regulator_late_cleanup()
> is called but that is usually some time after userspace has started,
> so it would be better to have that in. And of course dt should
> correctly describe the hardware. That would be
> 
> Fixes: c100ea86e6ab ("ARM: dts: add Netronix E60K02 board common file")

Applied with the tag.

> 
> BTW: I have not seen your 5.5 stuff in Linus' tree yet. Seems that Olof
> has not sent his pull request yet or is there bigger trouble?

Now they are in v5.5-rc1.

Shawn

      reply	other threads:[~2019-12-09  0:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 20:29 [PATCH] ARM: dts: e60k02: fix power button Andreas Kemnade
2019-11-11 21:05 ` H. Nikolaus Schaller
2019-12-04 12:36 ` Shawn Guo
2019-12-05  6:06   ` Andreas Kemnade
2019-12-09  0:56     ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209005621.GO3365@dragon \
    --to=shawnguo@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).