* [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells
@ 2019-12-06 18:19 Florian Fainelli
2019-12-07 0:54 ` Ray Jui
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-12-06 18:19 UTC (permalink / raw)
To: linux-arm-kernel
Cc: grygorii.strashko, simon.horman, robh+dt, rafal, davem, andrew,
mark.rutland, devicetree, netdev, bcm-kernel-feedback-list,
Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt, open list
The MDIO node on Cygnus had an reversed #address-cells and
#size-cells properties, correct those.
Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
Reported-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 2dac3efc7640..1bc45cfd5453 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -174,8 +174,8 @@
mdio: mdio@18002000 {
compatible = "brcm,iproc-mdio";
reg = <0x18002000 0x8>;
- #size-cells = <1>;
- #address-cells = <0>;
+ #size-cells = <0>;
+ #address-cells = <1>;
status = "disabled";
gphy0: ethernet-phy@0 {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells
2019-12-06 18:19 [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells Florian Fainelli
@ 2019-12-07 0:54 ` Ray Jui
2019-12-07 17:13 ` Simon Horman
2019-12-09 18:14 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Ray Jui @ 2019-12-07 0:54 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel
Cc: grygorii.strashko, simon.horman, robh+dt, rafal, davem, andrew,
mark.rutland, devicetree, netdev, bcm-kernel-feedback-list,
Ray Jui, Scott Branden, Eric Anholt, open list
On 12/6/19 10:19 AM, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
> mdio: mdio@18002000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18002000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> status = "disabled";
>
> gphy0: ethernet-phy@0 {
>
Looks good! Thanks!
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells
2019-12-06 18:19 [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells Florian Fainelli
2019-12-07 0:54 ` Ray Jui
@ 2019-12-07 17:13 ` Simon Horman
2019-12-09 18:14 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2019-12-07 17:13 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, grygorii.strashko, robh+dt, rafal, davem,
andrew, mark.rutland, devicetree, netdev,
bcm-kernel-feedback-list, Ray Jui, Scott Branden, Eric Anholt,
open list
On Fri, Dec 06, 2019 at 10:19:09AM -0800, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Florian,
this looks good to me.
Reviewed-by: Simon Horman <simon.horman@netronome.com>
> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
> mdio: mdio@18002000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18002000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> status = "disabled";
>
> gphy0: ethernet-phy@0 {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells
2019-12-06 18:19 [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells Florian Fainelli
2019-12-07 0:54 ` Ray Jui
2019-12-07 17:13 ` Simon Horman
@ 2019-12-09 18:14 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-12-09 18:14 UTC (permalink / raw)
To: bcm-kernel-feedback-list, linux-arm-kernel
Cc: grygorii.strashko, simon.horman, robh+dt, rafal, davem, andrew,
mark.rutland, devicetree, netdev, Ray Jui, Scott Branden,
Eric Anholt, open list
On Fri, 6 Dec 2019 10:19:09 -0800, Florian Fainelli <f.fainelli@gmail.com> wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
Applied to devicetree/fixes, thanks!
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-09 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 18:19 [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells Florian Fainelli
2019-12-07 0:54 ` Ray Jui
2019-12-07 17:13 ` Simon Horman
2019-12-09 18:14 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).