From: Shawn Guo <shawnguo@kernel.org>
To: Peng Ma <peng.ma@nxp.com>
Cc: "vkoul@kernel.org" <vkoul@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Leo Li <leoyang.li@nxp.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Robin Gong <yibin.gong@nxp.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [v4 2/2] arm64: dts: ls1028a: Update edma compatible to fit eDMA driver
Date: Thu, 12 Dec 2019 10:19:51 +0800 [thread overview]
Message-ID: <20191212021950.GE15858@dragon> (raw)
In-Reply-To: <20191211080749.30751-2-peng.ma@nxp.com>
On Wed, Dec 11, 2019 at 08:09:39AM +0000, Peng Ma wrote:
> The eDMA of LS1028A soc has a little bit different from others, So we
> should distinguish them in driver by compatible.
>
> Signed-off-by: Peng Ma <peng.ma@nxp.com>
> ---
> Changed for v4
> - Add new change patch
>
> Documentation/devicetree/bindings/dma/fsl-edma.txt | 1 +
Please have bindings change as a separate patch.
Shawn
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl-edma.txt b/Documentation/devicetree/bindings/dma/fsl-edma.txt
> index 29dd3ccb1235..e77b08ebcd06 100644
> --- a/Documentation/devicetree/bindings/dma/fsl-edma.txt
> +++ b/Documentation/devicetree/bindings/dma/fsl-edma.txt
> @@ -10,6 +10,7 @@ Required properties:
> - compatible :
> - "fsl,vf610-edma" for eDMA used similar to that on Vybrid vf610 SoC
> - "fsl,imx7ulp-edma" for eDMA2 used similar to that on i.mx7ulp
> + - "fsl,fsl,ls1028a-edma" for eDMA used similar to that on Vybrid vf610 SoC
> - reg : Specifies base physical address(s) and size of the eDMA registers.
> The 1st region is eDMA control register's address and size.
> The 2nd and the 3rd regions are programmable channel multiplexing
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8e8a77eb596a..b3716a89fa0d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -316,7 +316,7 @@
>
> edma0: dma-controller@22c0000 {
> #dma-cells = <2>;
> - compatible = "fsl,vf610-edma";
> + compatible = "fsl,ls1028a-edma";
> reg = <0x0 0x22c0000 0x0 0x10000>,
> <0x0 0x22d0000 0x0 0x10000>,
> <0x0 0x22e0000 0x0 0x10000>;
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-12-12 2:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 8:09 [v4 1/2] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform Peng Ma
2019-12-11 8:09 ` [v4 2/2] arm64: dts: ls1028a: Update edma compatible to fit eDMA driver Peng Ma
2019-12-12 2:19 ` Shawn Guo [this message]
2019-12-12 1:56 ` [v4 1/2] dmaengine: fsl-edma: Add eDMA support for QorIQ LS1028A platform Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212021950.GE15858@dragon \
--to=shawnguo@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.ma@nxp.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).