devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: qcom: sm8150: Update UFS resets
@ 2019-12-16 18:32 Vinod Koul
  2019-12-16 18:32 ` [PATCH 2/2] arm64: dts: qcom: sm8150-mtp: Add reset line for UFS Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2019-12-16 18:32 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, Vinod Koul, Rob Herring, Mark Rutland, devicetree,
	linux-kernel

The reset described is the phy reset so it should be named ufsphy, so
update it and add the UFS card reset

Earlier reset description was incorrect as phy reset was pointed to
'rst' as well as 'ufsphy' so both phy and core attempted to reset this
causing UFS to not come up. This was discovered with 870b1279c7a0
("scsi: ufs-qcom: Add reset control support for host controller")

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index f36d621a53e2..6a351e0cb3a6 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -517,8 +517,9 @@
 			phy-names = "ufsphy";
 			lanes-per-direction = <2>;
 			#reset-cells = <1>;
-			resets = <&gcc GCC_UFS_PHY_BCR>;
-			reset-names = "rst";
+			resets = <&gcc GCC_UFS_PHY_BCR>,
+				 <&gcc GCC_UFS_CARD_BCR>;
+			reset-names = "ufsphy", "rst";
 
 			clock-names =
 				"core_clk",
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sm8150-mtp: Add reset line for UFS
  2019-12-16 18:32 [PATCH 1/2] arm64: dts: qcom: sm8150: Update UFS resets Vinod Koul
@ 2019-12-16 18:32 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-12-16 18:32 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, Vinod Koul, Rob Herring, Mark Rutland, devicetree,
	linux-kernel

Add the reset line for the UFS node.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
index 1eb93a768a85..9cab51759d2f 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
@@ -7,6 +7,7 @@
 /dts-v1/;
 
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/gpio/gpio.h>
 #include "sm8150.dtsi"
 #include "pm8150.dtsi"
 #include "pm8150b.dtsi"
@@ -389,6 +390,8 @@
 &ufs_mem_hc {
 	status = "okay";
 
+	reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
+
 	vcc-supply = <&vreg_l10a_2p5>;
 	vcc-max-microamp = <750000>;
 	vccq-supply = <&vreg_l9a_1p2>;
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-16 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 18:32 [PATCH 1/2] arm64: dts: qcom: sm8150: Update UFS resets Vinod Koul
2019-12-16 18:32 ` [PATCH 2/2] arm64: dts: qcom: sm8150-mtp: Add reset line for UFS Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).