* [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy
@ 2019-12-23 10:03 Geert Uytterhoeven
2019-12-23 10:51 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-12-23 10:03 UTC (permalink / raw)
To: Antoine Tenart, David S . Miller
Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Rob Herring,
Frank Rowand, netdev, devicetree, linux-kernel,
Geert Uytterhoeven
If CONFIG_OF_MDIO=n:
drivers/net/phy/mdio_bus.c:23:
include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
static bool of_mdiobus_child_is_phy(struct device_node *child)
^~~~~~~~~~~~~~~~~~~~~~~
Fix this by adding the missing "inline" keyword.
Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
include/linux/of_mdio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h
index 79bc82e30c02333d..491a2b7e77c1e906 100644
--- a/include/linux/of_mdio.h
+++ b/include/linux/of_mdio.h
@@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev,
}
#else /* CONFIG_OF_MDIO */
-static bool of_mdiobus_child_is_phy(struct device_node *child)
+static inline bool of_mdiobus_child_is_phy(struct device_node *child)
{
return false;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy
2019-12-23 10:03 [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy Geert Uytterhoeven
@ 2019-12-23 10:51 ` Andrew Lunn
2019-12-23 11:10 ` Borislav Petkov
2019-12-26 23:17 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2019-12-23 10:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Antoine Tenart, David S . Miller, Florian Fainelli,
Heiner Kallweit, Rob Herring, Frank Rowand, netdev, devicetree,
linux-kernel
On Mon, Dec 23, 2019 at 11:03:21AM +0100, Geert Uytterhoeven wrote:
> If CONFIG_OF_MDIO=n:
>
> drivers/net/phy/mdio_bus.c:23:
> include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
> static bool of_mdiobus_child_is_phy(struct device_node *child)
> ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by adding the missing "inline" keyword.
>
> Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy
2019-12-23 10:03 [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy Geert Uytterhoeven
2019-12-23 10:51 ` Andrew Lunn
@ 2019-12-23 11:10 ` Borislav Petkov
2019-12-26 23:17 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2019-12-23 11:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Antoine Tenart, David S . Miller, Andrew Lunn, Florian Fainelli,
Heiner Kallweit, Rob Herring, Frank Rowand, netdev, devicetree,
linux-kernel
On Mon, Dec 23, 2019 at 11:03:21AM +0100, Geert Uytterhoeven wrote:
> If CONFIG_OF_MDIO=n:
>
> drivers/net/phy/mdio_bus.c:23:
> include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
> static bool of_mdiobus_child_is_phy(struct device_node *child)
> ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by adding the missing "inline" keyword.
>
> Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> include/linux/of_mdio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h
> index 79bc82e30c02333d..491a2b7e77c1e906 100644
> --- a/include/linux/of_mdio.h
> +++ b/include/linux/of_mdio.h
> @@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev,
> }
>
> #else /* CONFIG_OF_MDIO */
> -static bool of_mdiobus_child_is_phy(struct device_node *child)
> +static inline bool of_mdiobus_child_is_phy(struct device_node *child)
> {
> return false;
> }
> --
I'm seeing it too with rc3.
Acked-by: Borislav Petkov <bp@suse.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy
2019-12-23 10:03 [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy Geert Uytterhoeven
2019-12-23 10:51 ` Andrew Lunn
2019-12-23 11:10 ` Borislav Petkov
@ 2019-12-26 23:17 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-12-26 23:17 UTC (permalink / raw)
To: geert
Cc: antoine.tenart, andrew, f.fainelli, hkallweit1, robh+dt,
frowand.list, netdev, devicetree, linux-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 23 Dec 2019 11:03:21 +0100
> If CONFIG_OF_MDIO=n:
>
> drivers/net/phy/mdio_bus.c:23:
> include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function]
> static bool of_mdiobus_child_is_phy(struct device_node *child)
> ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by adding the missing "inline" keyword.
>
> Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-26 23:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23 10:03 [PATCH] of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy Geert Uytterhoeven
2019-12-23 10:51 ` Andrew Lunn
2019-12-23 11:10 ` Borislav Petkov
2019-12-26 23:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).