From: Jonathan Cameron <jic23@kernel.org>
To: Beniamin Bia <beniamin.bia@analog.com>
Cc: <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<Michael.Hennerich@analog.com>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <biabeniamin@outlook.com>
Subject: Re: [PATCH 3/3] dt-binding: iio: Add documentation for ADF4371 channel child notes
Date: Mon, 23 Dec 2019 11:00:09 +0000 [thread overview]
Message-ID: <20191223110009.6fcc2951@archlinux> (raw)
In-Reply-To: <20191219133755.26109-3-beniamin.bia@analog.com>
On Thu, 19 Dec 2019 15:37:55 +0200
Beniamin Bia <beniamin.bia@analog.com> wrote:
> This patch documents the ADF4371 individual channel configuration.
>
> Signed-off-by: Beniamin Bia <beniamin.bia@analog.com>
> ---
> .../bindings/iio/frequency/adf4371.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> index 7ec3ec94356b..5339c929e883 100644
> --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> @@ -40,12 +40,48 @@ properties:
> output stage will shut down until the ADF4371/ADF4372 achieves lock as
> measured by the digital lock detect circuitry.
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> required:
> - compatible
> - reg
> - clocks
> - clock-names
>
> + patternProperties:
> + "^channel@[01]$":
> + type: object
> + description: Represents the external channels which are connected to the device.
> +
> + properties:
> + reg:
> + description: |
> + The channel number. It can have up to 3 channels on adf4372
> + and 4 channels on adf4371, numbered from 0 to 3.
> + maxItems: 1
> +
> + adi,output-enable:
> + description: |
> + If this property is specified, the output channel will be enabled.
> + If left empty, the driver will initialize the defaults (RF8x, channel 0
> + will be the only one enabled).
If I read the driver right, this is effectively 'power up channel when driver
loads'. Why do we need that in DT? A bit of udev magic or similar and the existing
controls can set both this and the frequency below. Would happen a tiny
bit after the driver loads, but I assume the driver current loads with the channels
turned off so that shouldn't matter...
> + maxItems: 1
> +
> + adi,power-up-frequency:
> + description: |
> + Set the frequency after power up for the channel. If this property is
> + specified, it has to be in sync with the power up frequency set on the
> + other channels. This limitation is due to the fact that all the channel
> + frequencies are derived from the VCO fundamental frequency.
> + maxItems: 1
> +
> + required:
> + - reg
> +
> examples:
> - |
> spi0 {
> @@ -55,9 +91,36 @@ examples:
> frequency@0 {
> compatible = "adi,adf4371";
> reg = <0>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> spi-max-frequency = <1000000>;
> clocks = <&adf4371_clkin>;
> clock-names = "clkin";
> +
> + channel@0 {
> + reg = <0>;
> + adi,output-enable;
> + adi,power-up-frequency = /bits/ 64 <8000000000>;
> + };
> +
> + channel@1 {
> + reg = <1>;
> + adi,output-enable;
> + };
> +
> + channel@2 {
> + reg = <2>;
> + adi,output-enable;
> + adi,power-up-frequency = /bits/ 64 <16000000000>;
> + };
> +
> + channel@3 {
> + reg = <3>;
> + adi,output-enable;
> + adi,power-up-frequency = /bits/ 64 <32000000000>;
> + };
> };
> };
> ...
prev parent reply other threads:[~2019-12-23 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:37 [PATCH 1/3] iio: frequency: adf4371: Create a power down/up function Beniamin Bia
2019-12-19 13:37 ` [PATCH 2/3] iio: frequency: adf4371: Introduce channel child nodes Beniamin Bia
2019-12-23 11:02 ` Jonathan Cameron
2019-12-19 13:37 ` [PATCH 3/3] dt-binding: iio: Add documentation for ADF4371 channel child notes Beniamin Bia
2019-12-23 11:00 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223110009.6fcc2951@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=beniamin.bia@analog.com \
--cc=biabeniamin@outlook.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).