From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Tero Kristo <t-kristo@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/5] clk: ti: clkctrl: Fix hidden dependency to node name
Date: Mon, 30 Dec 2019 12:00:22 -0800 [thread overview]
Message-ID: <20191230200023.9EE1020718@mail.kernel.org> (raw)
In-Reply-To: <20191210172108.38868-2-tony@atomide.com>
Quoting Tony Lindgren (2019-12-10 09:21:04)
> We currently have a hidden dependency to the device tree node name for
> the clkctrl clocks. Instead of using standard node name like "clock", we
> must use "l4-per-clkctrl" type naming so the clock driver can find the
> associated clock domain. Further, if "clk" is specified for a clock node
> name, the driver sets TI_CLK_CLKCTRL_COMPAT flag that uses different
> logic for the clock name based on the parent node name for the all the
> clkctrl clocks for the SoC.
>
> If the clock node naming dependency is not understood, the related
> clockdomain is not found, or a wrong one can get used if a clock manager
> has multiple clock domains.
>
> As each clkctrl instance represents a single clock domain, let's allow
> using domain specific compatible names to specify the clock domain.
>
> This simplifies things and removes the hidden dependency to the node
> name. And then later on, after the node names have been standardized,
> we can drop the related code for parsing the node names.
>
> Let's also update the binding to use standard "clock" node naming
> instead of "clk" and add the missing description for reg.
>
> Cc: devicetree@vger.kernel.org
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
next prev parent reply other threads:[~2019-12-30 20:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 17:21 [PATCH 0/5] Clock changes needed to probe rng on omap4 and 5 Tony Lindgren
2019-12-10 17:21 ` [PATCH 1/5] clk: ti: clkctrl: Fix hidden dependency to node name Tony Lindgren
2019-12-19 20:18 ` Rob Herring
2019-12-30 20:00 ` Stephen Boyd [this message]
2019-12-10 17:21 ` [PATCH 2/5] ARM: dts: Add missing omap4 secure clocks Tony Lindgren
2019-12-30 20:00 ` Stephen Boyd
2019-12-10 17:21 ` [PATCH 3/5] ARM: dts: Add missing omap5 " Tony Lindgren
2019-12-30 20:00 ` Stephen Boyd
2019-12-10 17:21 ` [PATCH 4/5] ARM: dts: Configure omap4 rng to probe with ti-sysc Tony Lindgren
2019-12-10 17:21 ` [PATCH 5/5] ARM: dts: Configure omap5 " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230200023.9EE1020718@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).