* [PATCH] of: overlay: Remove blank line between assignment and check
@ 2019-12-31 13:46 Geert Uytterhoeven
2020-01-08 16:49 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-12-31 13:46 UTC (permalink / raw)
To: Rob Herring, Pantelis Antoniou, Frank Rowand
Cc: devicetree, Geert Uytterhoeven
There used to be blank lines between assignment and check of the
__of_changeset_revert_entries() result, to make the phandle cache
management operations stand out. After the removal of those operations
in commit 90dc0d1ce890419f ("of: Rework and simplify phandle cache to
use a fixed size"), there is no longer a reason to have such a blank
line.
Remove the blank line, to rejoin visibly the status assignement and
check, and to match coding style.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/of/overlay.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 788ab3501913d04f..87ef7cdfd0381799 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -1391,7 +1391,6 @@ int of_overlay_remove(int *ovcs_id)
ret_apply = 0;
ret = __of_changeset_revert_entries(&ovcs->cset, &ret_apply);
-
if (ret) {
if (ret_apply)
devicetree_state_flags |= DTSF_REVERT_FAIL;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of: overlay: Remove blank line between assignment and check
2019-12-31 13:46 [PATCH] of: overlay: Remove blank line between assignment and check Geert Uytterhoeven
@ 2020-01-08 16:49 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-01-08 16:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Pantelis Antoniou, Frank Rowand, devicetree, Geert Uytterhoeven
On Tue, 31 Dec 2019 14:46:44 +0100, Geert Uytterhoeven wrote:
> There used to be blank lines between assignment and check of the
> __of_changeset_revert_entries() result, to make the phandle cache
> management operations stand out. After the removal of those operations
> in commit 90dc0d1ce890419f ("of: Rework and simplify phandle cache to
> use a fixed size"), there is no longer a reason to have such a blank
> line.
>
> Remove the blank line, to rejoin visibly the status assignement and
> check, and to match coding style.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/of/overlay.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-08 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-31 13:46 [PATCH] of: overlay: Remove blank line between assignment and check Geert Uytterhoeven
2020-01-08 16:49 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).