From: Rob Herring <robh@kernel.org>
To: Yifeng Zhao <yifeng.zhao@rock-chips.com>
Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
heiko@sntech.de, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 2/3] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller
Date: Wed, 4 Mar 2020 10:56:24 -0600 [thread overview]
Message-ID: <20200304165624.GA2630@bogus> (raw)
In-Reply-To: <20200303094736.7490-3-yifeng.zhao@rock-chips.com>
On Tue, Mar 03, 2020 at 05:47:35PM +0800, Yifeng Zhao wrote:
> Documentation support for Rockchip RK3xxx NAND flash controllers
>
> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> ---
>
> Changes in v3:
> -change the title for the dt-bindings
>
> Changes in v2: None
>
> .../bindings/mtd/rockchip,nand.yaml | 95 +++++++++++++++++++
> 1 file changed, 95 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand.yaml
> new file mode 100644
> index 000000000000..9a81f682ac01
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/rockchip,nand.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual license new bindings:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/rockchip,nand.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip SoCs NAND FLASH Controller (NFC) Device Tree Bindings
> +
> +allOf:
> + - $ref: "nand-controller.yaml"
> +
> +maintainers:
> + - Yifeng Zhao <yifeng.zhao@rock-chips.com>
> +
> +properties:
> + "#address-cells": true
> + "#size-cells": true
> +
> + compatible:
> + const: rockchip,nfc
Should be SoC specific.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Module Clock
> + - description: Bus Clock
> +
> + clock-names:
> + items:
> + - const: clk_nfc
> + - const: clk_ahb
'clk_' is redundant.
> +
> + clock-rates:
> + maximum: 150000000
Not a standard property. Should be implied by the compatible string.
> +
> + pinctrl-names: true
No need to specify this, pinctrl properties are allowed on any node and
added by the tool.
> +
> +patternProperties:
> + "^pinctrl-[0-9]+$": true
Same here.
> +
> + "^nand@[a-f0-9]$":
Based on reg, should be only '[0-3]'
> + type: object
> + properties:
> + reg:
> + minimum: 0
> + maximum: 3
> +
> + nand-ecc-step-size:
> + const: 1024
> +
> + nand-ecc-strength:
> + enum: [16, 24 , 40, 60, 70]
> +
> + nand-bus-width:
> + const: 8
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/rk3308-cru.h>
> + nfc: nand-controller@ff4b0000 {
> + compatible = "rockchip,nfc";
> + reg = <0x0 0xff4b0000 0x0 0x4000>;
> + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_NANDC>, <&cru HCLK_NANDC>;
> + clock-names = "clk_nfc", "clk_ahb";
> + clock-rates = <150000000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&flash_csn0 &flash_rdy &flash_ale &flash_cle
> + &flash_wrn &flash_rdn &flash_bus8>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + nand@0 {
> + reg = <0>;
> + nand-ecc-mode = "hw";
> + nand-ecc-strength = <16>;
> + nand-ecc-step-size = <1024>;
> + nand-bus-width = <8>;
> + };
> + };
> +
> +...
> --
> 2.17.1
>
>
>
next prev parent reply other threads:[~2020-03-04 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 9:47 [PATCH v3 0/3] Add Rockchip NFC drivers for RK3308 and others Yifeng Zhao
2020-03-03 9:47 ` [PATCH v3 1/3] mtd: rawnand: rockchip: NFC drivers for RK3308, RK3188 " Yifeng Zhao
2020-03-09 11:16 ` Miquel Raynal
2020-03-16 9:59 ` 赵仪峰
2020-03-16 10:06 ` Miquel Raynal
2020-03-03 9:47 ` [PATCH v3 2/3] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Yifeng Zhao
2020-03-04 16:56 ` Rob Herring [this message]
2020-03-03 9:47 ` [PATCH v3 3/3] MAINTAINERS: add maintainers to rockchip nfc Yifeng Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304165624.GA2630@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).