* [PATCH 6/6 V3] ASoC: tas5756m: Add DT binding document [not found] <20200308142509.27765-1-charles-antoine.couret@mind.be> @ 2020-03-08 14:25 ` Charles-Antoine Couret 2020-03-09 20:38 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Charles-Antoine Couret @ 2020-03-08 14:25 UTC (permalink / raw) To: alsa-devel; +Cc: Charles-Antoine Couret, devicetree Document the bindings for the tas5756m driver. Signed-off-by: Charles-Antoine Couret <charles-antoine.couret@mind.be> --- .../devicetree/bindings/sound/tas5756m.yaml | 64 +++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tas5756m.yaml diff --git a/Documentation/devicetree/bindings/sound/tas5756m.yaml b/Documentation/devicetree/bindings/sound/tas5756m.yaml new file mode 100644 index 000000000000..2fd4492c4bd2 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/tas5756m.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/tas5756m.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TAS5756M audio codec Device Tree Bindings + +maintainers: + - Charles-Antoine Couret <charles-antoine.couret@mind.be> + +description: | + You can read datasheets there: + http://www.ti.com/lit/ds/symlink/tas5754m.pdf + http://www.ti.com/lit/ds/symlink/tas5756m.pdf + + TAS5754M datasheet has a more complete datasheet about register mapping + which is common with TAS5756M. + + Those devices have a programmable DSP whith several modes named hybridflow. + More details about it there: http://www.ti.com/lit/ug/slau577a/slau577a.pdf + +properties: + compatible: + enum: + - "ti,tas5756m" + - "ti,tas5754m" + + reg: + maxItems: 1 + description: I2C slave address + + "#sound-dai-cells": + const: 0 + + mute-gpios: + maxItems: 1 + description: GPIO wired to the mute pin. + + ti,hybridflow: + description: | + Select the HybridFlow DSP program. + If not supplied default DSP program is used instead. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [1, 2, 3, 4, 5, 6, 7, 8, 9] + +additionalProperties: false + +required: + - "#sound-dai-cells" + - compatible + - reg + +examples: + - | + tas5756m: tas5756m@4c { + compatible = "ti,tas5756m"; + reg = <0x4c>; + #sound-dai-cells = <0>; + + ti,hybridflow = <6>; + mute-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + }; -- 2.24.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 6/6 V3] ASoC: tas5756m: Add DT binding document 2020-03-08 14:25 ` [PATCH 6/6 V3] ASoC: tas5756m: Add DT binding document Charles-Antoine Couret @ 2020-03-09 20:38 ` Rob Herring 2020-03-09 20:55 ` Couret Charles-Antoine 2020-03-26 15:09 ` RESEND: " Couret Charles-Antoine 0 siblings, 2 replies; 4+ messages in thread From: Rob Herring @ 2020-03-09 20:38 UTC (permalink / raw) To: Charles-Antoine Couret; +Cc: alsa-devel, Charles-Antoine Couret, devicetree On Sun, 8 Mar 2020 15:25:09 +0100, Charles-Antoine Couret wrote: > Document the bindings for the tas5756m driver. > > Signed-off-by: Charles-Antoine Couret <charles-antoine.couret@mind.be> > --- > .../devicetree/bindings/sound/tas5756m.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/tas5756m.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/sound/tas5756m.example.dts:23.37-38 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/sound/tas5756m.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/sound/tas5756m.example.dt.yaml] Error 1 Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1251057 Please check and re-submit. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 6/6 V3] ASoC: tas5756m: Add DT binding document 2020-03-09 20:38 ` Rob Herring @ 2020-03-09 20:55 ` Couret Charles-Antoine 2020-03-26 15:09 ` RESEND: " Couret Charles-Antoine 1 sibling, 0 replies; 4+ messages in thread From: Couret Charles-Antoine @ 2020-03-09 20:55 UTC (permalink / raw) To: Rob Herring; +Cc: alsa-devel, devicetree Le 09/03/2020 à 21:38, Rob Herring a écrit : > On Sun, 8 Mar 2020 15:25:09 +0100, Charles-Antoine Couret wrote: >> Document the bindings for the tas5756m driver. >> >> Signed-off-by: Charles-Antoine Couret <charles-antoine.couret@mind.be> >> --- >> .../devicetree/bindings/sound/tas5756m.yaml | 64 +++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/tas5756m.yaml >> > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/sound/tas5756m.example.dts:23.37-38 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/sound/tas5756m.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/sound/tas5756m.example.dt.yaml] Error 1 > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1251057 > Please check and re-submit. Hi Rob, I don't understand this issue. My example is based on a real device tree and it works fine. I don't have access to your "Documentation/devicetree/bindings/sound/tas5756m.example.dts" file so I can not reproduce it. I executed your script before sending the patch (but without extracting the example) and it was fine. Can you explain the issue please? Thank you in advance and have a nice day, Charles-Antoine Couret ^ permalink raw reply [flat|nested] 4+ messages in thread
* RESEND: [PATCH 6/6 V3] ASoC: tas5756m: Add DT binding document 2020-03-09 20:38 ` Rob Herring 2020-03-09 20:55 ` Couret Charles-Antoine @ 2020-03-26 15:09 ` Couret Charles-Antoine 1 sibling, 0 replies; 4+ messages in thread From: Couret Charles-Antoine @ 2020-03-26 15:09 UTC (permalink / raw) To: Rob Herring; +Cc: alsa-devel, devicetree Le 09/03/2020 à 21:38, Rob Herring a écrit : > On Sun, 8 Mar 2020 15:25:09 +0100, Charles-Antoine Couret wrote: >> Document the bindings for the tas5756m driver. >> >> Signed-off-by: Charles-Antoine Couret <charles-antoine.couret@mind.be> >> --- >> .../devicetree/bindings/sound/tas5756m.yaml | 64 +++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/tas5756m.yaml >> > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/sound/tas5756m.example.dts:23.37-38 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/sound/tas5756m.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/sound/tas5756m.example.dt.yaml] Error 1 > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1251057 > Please check and re-submit. Hi Rob, I don't understand this issue. My example is based on a real device tree and it works fine. I don't have access to your "Documentation/devicetree/bindings/sound/tas5756m.example.dts" file so I can not reproduce it. I executed your script before sending the patch (but without extracting the example) and it was fine. Can you explain the issue please? Thank you in advance and have a nice day, Charles-Antoine Couret ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-26 15:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200308142509.27765-1-charles-antoine.couret@mind.be>
2020-03-08 14:25 ` [PATCH 6/6 V3] ASoC: tas5756m: Add DT binding document Charles-Antoine Couret
2020-03-09 20:38 ` Rob Herring
2020-03-09 20:55 ` Couret Charles-Antoine
2020-03-26 15:09 ` RESEND: " Couret Charles-Antoine
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).