* [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema
@ 2020-03-03 9:48 Geert Uytterhoeven
2020-03-05 21:54 ` Stephen Boyd
2020-03-10 20:55 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-03-03 9:48 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Rob Herring
Cc: linux-clk, devicetree, linux-renesas-soc, Geert Uytterhoeven
Convert the Renesas Clock Pulse Generator / Module Standby and Software
Reset Device Tree binding documentation to json-schema.
Note that #reset-cells was incorrecty marked a required property for
RZ/A2 before.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in clk-renesas-for-v5.7.
v2:
- Remove complex if-construct implementing per-SoC clocks/clock-names
constraints; list all possible clock-names upfront instead,
- Drop Clock Domain member example.
---
.../bindings/clock/renesas,cpg-mssr.txt | 100 ---------------
.../bindings/clock/renesas,cpg-mssr.yaml | 119 ++++++++++++++++++
2 files changed, 119 insertions(+), 100 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
create mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
deleted file mode 100644
index f4d153f24a0ff803..0000000000000000
--- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
+++ /dev/null
@@ -1,100 +0,0 @@
-* Renesas Clock Pulse Generator / Module Standby and Software Reset
-
-On Renesas ARM SoCs (SH/R-Mobile, R-Car, RZ), the CPG (Clock Pulse Generator)
-and MSSR (Module Standby and Software Reset) blocks are intimately connected,
-and share the same register block.
-
-They provide the following functionalities:
- - The CPG block generates various core clocks,
- - The MSSR block provides two functions:
- 1. Module Standby, providing a Clock Domain to control the clock supply
- to individual SoC devices,
- 2. Reset Control, to perform a software reset of individual SoC devices.
-
-Required Properties:
- - compatible: Must be one of:
- - "renesas,r7s9210-cpg-mssr" for the r7s9210 SoC (RZ/A2)
- - "renesas,r8a7743-cpg-mssr" for the r8a7743 SoC (RZ/G1M)
- - "renesas,r8a7744-cpg-mssr" for the r8a7744 SoC (RZ/G1N)
- - "renesas,r8a7745-cpg-mssr" for the r8a7745 SoC (RZ/G1E)
- - "renesas,r8a77470-cpg-mssr" for the r8a77470 SoC (RZ/G1C)
- - "renesas,r8a774a1-cpg-mssr" for the r8a774a1 SoC (RZ/G2M)
- - "renesas,r8a774b1-cpg-mssr" for the r8a774b1 SoC (RZ/G2N)
- - "renesas,r8a774c0-cpg-mssr" for the r8a774c0 SoC (RZ/G2E)
- - "renesas,r8a7790-cpg-mssr" for the r8a7790 SoC (R-Car H2)
- - "renesas,r8a7791-cpg-mssr" for the r8a7791 SoC (R-Car M2-W)
- - "renesas,r8a7792-cpg-mssr" for the r8a7792 SoC (R-Car V2H)
- - "renesas,r8a7793-cpg-mssr" for the r8a7793 SoC (R-Car M2-N)
- - "renesas,r8a7794-cpg-mssr" for the r8a7794 SoC (R-Car E2)
- - "renesas,r8a7795-cpg-mssr" for the r8a7795 SoC (R-Car H3)
- - "renesas,r8a7796-cpg-mssr" for the r8a77960 SoC (R-Car M3-W)
- - "renesas,r8a77961-cpg-mssr" for the r8a77961 SoC (R-Car M3-W+)
- - "renesas,r8a77965-cpg-mssr" for the r8a77965 SoC (R-Car M3-N)
- - "renesas,r8a77970-cpg-mssr" for the r8a77970 SoC (R-Car V3M)
- - "renesas,r8a77980-cpg-mssr" for the r8a77980 SoC (R-Car V3H)
- - "renesas,r8a77990-cpg-mssr" for the r8a77990 SoC (R-Car E3)
- - "renesas,r8a77995-cpg-mssr" for the r8a77995 SoC (R-Car D3)
-
- - reg: Base address and length of the memory resource used by the CPG/MSSR
- block
-
- - clocks: References to external parent clocks, one entry for each entry in
- clock-names
- - clock-names: List of external parent clock names. Valid names are:
- - "extal" (r7s9210, r8a7743, r8a7744, r8a7745, r8a77470, r8a774a1,
- r8a774b1, r8a774c0, r8a7790, r8a7791, r8a7792, r8a7793,
- r8a7794, r8a7795, r8a77960, r8a77961, r8a77965, r8a77970,
- r8a77980, r8a77990, r8a77995)
- - "extalr" (r8a774a1, r8a774b1, r8a7795, r8a77960, r8a77961, r8a77965,
- r8a77970, r8a77980)
- - "usb_extal" (r8a7743, r8a7744, r8a7745, r8a77470, r8a7790, r8a7791,
- r8a7793, r8a7794)
-
- - #clock-cells: Must be 2
- - For CPG core clocks, the two clock specifier cells must be "CPG_CORE"
- and a core clock reference, as defined in
- <dt-bindings/clock/*-cpg-mssr.h>.
- - For module clocks, the two clock specifier cells must be "CPG_MOD" and
- a module number, as defined in the datasheet.
-
- - #power-domain-cells: Must be 0
- - SoC devices that are part of the CPG/MSSR Clock Domain and can be
- power-managed through Module Standby should refer to the CPG device
- node in their "power-domains" property, as documented by the generic PM
- Domain bindings in
- Documentation/devicetree/bindings/power/power-domain.yaml.
-
- - #reset-cells: Must be 1
- - The single reset specifier cell must be the module number, as defined
- in the datasheet.
-
-
-Examples
---------
-
- - CPG device node:
-
- cpg: clock-controller@e6150000 {
- compatible = "renesas,r8a7795-cpg-mssr";
- reg = <0 0xe6150000 0 0x1000>;
- clocks = <&extal_clk>, <&extalr_clk>;
- clock-names = "extal", "extalr";
- #clock-cells = <2>;
- #power-domain-cells = <0>;
- #reset-cells = <1>;
- };
-
-
- - CPG/MSSR Clock Domain member device node:
-
- scif2: serial@e6e88000 {
- compatible = "renesas,scif-r8a7795", "renesas,scif";
- reg = <0 0xe6e88000 0 64>;
- interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cpg CPG_MOD 310>;
- clock-names = "fck";
- dmas = <&dmac1 0x13>, <&dmac1 0x12>;
- dma-names = "tx", "rx";
- power-domains = <&cpg>;
- resets = <&cpg 310>;
- };
diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
new file mode 100644
index 0000000000000000..4c1e6ac272196e97
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/clock/renesas,cpg-mssr.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Renesas Clock Pulse Generator / Module Standby and Software Reset
+
+maintainers:
+ - Geert Uytterhoeven <geert+renesas@glider.be>
+
+description: |
+ On Renesas ARM SoCs (SH/R-Mobile, R-Car, RZ), the CPG (Clock Pulse Generator)
+ and MSSR (Module Standby and Software Reset) blocks are intimately connected,
+ and share the same register block.
+
+ They provide the following functionalities:
+ - The CPG block generates various core clocks,
+ - The MSSR block provides two functions:
+ 1. Module Standby, providing a Clock Domain to control the clock supply
+ to individual SoC devices,
+ 2. Reset Control, to perform a software reset of individual SoC devices.
+
+properties:
+ compatible:
+ enum:
+ - renesas,r7s9210-cpg-mssr # RZ/A2
+ - renesas,r8a7743-cpg-mssr # RZ/G1M
+ - renesas,r8a7744-cpg-mssr # RZ/G1N
+ - renesas,r8a7745-cpg-mssr # RZ/G1E
+ - renesas,r8a77470-cpg-mssr # RZ/G1C
+ - renesas,r8a774a1-cpg-mssr # RZ/G2M
+ - renesas,r8a774b1-cpg-mssr # RZ/G2N
+ - renesas,r8a774c0-cpg-mssr # RZ/G2E
+ - renesas,r8a7790-cpg-mssr # R-Car H2
+ - renesas,r8a7791-cpg-mssr # R-Car M2-W
+ - renesas,r8a7792-cpg-mssr # R-Car V2H
+ - renesas,r8a7793-cpg-mssr # R-Car M2-N
+ - renesas,r8a7794-cpg-mssr # R-Car E2
+ - renesas,r8a7795-cpg-mssr # R-Car H3
+ - renesas,r8a7796-cpg-mssr # R-Car M3-W
+ - renesas,r8a77961-cpg-mssr # R-Car M3-W+
+ - renesas,r8a77965-cpg-mssr # R-Car M3-N
+ - renesas,r8a77970-cpg-mssr # R-Car V3M
+ - renesas,r8a77980-cpg-mssr # R-Car V3H
+ - renesas,r8a77990-cpg-mssr # R-Car E3
+ - renesas,r8a77995-cpg-mssr # R-Car D3
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ minItems: 1
+ maxItems: 2
+ items:
+ enum:
+ - extal # All
+ - extalr # Most R-Car Gen3 and RZ/G2
+ - usb_extal # Most R-Car Gen2 and RZ/G1
+
+ '#clock-cells':
+ description: |
+ - For CPG core clocks, the two clock specifier cells must be "CPG_CORE"
+ and a core clock reference, as defined in
+ <dt-bindings/clock/*-cpg-mssr.h>
+ - For module clocks, the two clock specifier cells must be "CPG_MOD" and
+ a module number, as defined in the datasheet.
+ const: 2
+
+ '#power-domain-cells':
+ description:
+ SoC devices that are part of the CPG/MSSR Clock Domain and can be
+ power-managed through Module Standby should refer to the CPG device node
+ in their "power-domains" property, as documented by the generic PM Domain
+ bindings in Documentation/devicetree/bindings/power/power-domain.yaml.
+ const: 0
+
+ '#reset-cells':
+ description:
+ The single reset specifier cell must be the module number, as defined in
+ the datasheet.
+ const: 1
+
+if:
+ not:
+ properties:
+ compatible:
+ items:
+ enum:
+ - renesas,r7s9210-cpg-mssr
+then:
+ required:
+ - '#reset-cells'
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - '#clock-cells'
+ - '#power-domain-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ cpg: clock-controller@e6150000 {
+ compatible = "renesas,r8a7795-cpg-mssr";
+ reg = <0xe6150000 0x1000>;
+ clocks = <&extal_clk>, <&extalr_clk>;
+ clock-names = "extal", "extalr";
+ #clock-cells = <2>;
+ #power-domain-cells = <0>;
+ #reset-cells = <1>;
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema
2020-03-03 9:48 [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema Geert Uytterhoeven
@ 2020-03-05 21:54 ` Stephen Boyd
2020-03-10 20:55 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2020-03-05 21:54 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Rob Herring
Cc: linux-clk, devicetree, linux-renesas-soc, Geert Uytterhoeven
Quoting Geert Uytterhoeven (2020-03-03 01:48:48)
> Convert the Renesas Clock Pulse Generator / Module Standby and Software
> Reset Device Tree binding documentation to json-schema.
>
> Note that #reset-cells was incorrecty marked a required property for
> RZ/A2 before.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema
2020-03-03 9:48 [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema Geert Uytterhoeven
2020-03-05 21:54 ` Stephen Boyd
@ 2020-03-10 20:55 ` Rob Herring
2020-03-11 8:08 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2020-03-10 20:55 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Michael Turquette, Stephen Boyd, linux-clk, devicetree,
linux-renesas-soc, Geert Uytterhoeven
On Tue, 3 Mar 2020 10:48:48 +0100, Geert Uytterhoeven wrote:
> Convert the Renesas Clock Pulse Generator / Module Standby and Software
> Reset Device Tree binding documentation to json-schema.
>
> Note that #reset-cells was incorrecty marked a required property for
> RZ/A2 before.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in clk-renesas-for-v5.7.
>
> v2:
> - Remove complex if-construct implementing per-SoC clocks/clock-names
> constraints; list all possible clock-names upfront instead,
> - Drop Clock Domain member example.
> ---
> .../bindings/clock/renesas,cpg-mssr.txt | 100 ---------------
> .../bindings/clock/renesas,cpg-mssr.yaml | 119 ++++++++++++++++++
> 2 files changed, 119 insertions(+), 100 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
> create mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema
2020-03-10 20:55 ` Rob Herring
@ 2020-03-11 8:08 ` Geert Uytterhoeven
2020-03-12 8:30 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-03-11 8:08 UTC (permalink / raw)
To: Rob Herring
Cc: Geert Uytterhoeven, Michael Turquette, Stephen Boyd, linux-clk,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
On Tue, Mar 10, 2020 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, 3 Mar 2020 10:48:48 +0100, Geert Uytterhoeven wrote:
> > Convert the Renesas Clock Pulse Generator / Module Standby and Software
> > Reset Device Tree binding documentation to json-schema.
> >
> > Note that #reset-cells was incorrecty marked a required property for
> > RZ/A2 before.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > To be queued in clk-renesas-for-v5.7.
> >
> > v2:
> > - Remove complex if-construct implementing per-SoC clocks/clock-names
> > constraints; list all possible clock-names upfront instead,
> > - Drop Clock Domain member example.
> > ---
> > .../bindings/clock/renesas,cpg-mssr.txt | 100 ---------------
> > .../bindings/clock/renesas,cpg-mssr.yaml | 119 ++++++++++++++++++
> > 2 files changed, 119 insertions(+), 100 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
> > create mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Thanks, queued in renesas-devel for v5.7.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema
2020-03-11 8:08 ` Geert Uytterhoeven
@ 2020-03-12 8:30 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-03-12 8:30 UTC (permalink / raw)
To: Rob Herring
Cc: Michael Turquette, Stephen Boyd, linux-clk,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas
On Wed, Mar 11, 2020 at 9:08 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Mar 10, 2020 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
> > On Tue, 3 Mar 2020 10:48:48 +0100, Geert Uytterhoeven wrote:
> > > Convert the Renesas Clock Pulse Generator / Module Standby and Software
> > > Reset Device Tree binding documentation to json-schema.
> > >
> > > Note that #reset-cells was incorrecty marked a required property for
> > > RZ/A2 before.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > To be queued in clk-renesas-for-v5.7.
> > >
> > > v2:
> > > - Remove complex if-construct implementing per-SoC clocks/clock-names
> > > constraints; list all possible clock-names upfront instead,
> > > - Drop Clock Domain member example.
> > > ---
> > > .../bindings/clock/renesas,cpg-mssr.txt | 100 ---------------
> > > .../bindings/clock/renesas,cpg-mssr.yaml | 119 ++++++++++++++++++
> > > 2 files changed, 119 insertions(+), 100 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
> > > create mode 100644 Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> Thanks, queued in renesas-devel for v5.7.
Oops, clk-renesas-for-v5.7, of course.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-12 8:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 9:48 [PATCH v2] dt-bindings: clock: renesas: cpg-mssr: Convert to json-schema Geert Uytterhoeven
2020-03-05 21:54 ` Stephen Boyd
2020-03-10 20:55 ` Rob Herring
2020-03-11 8:08 ` Geert Uytterhoeven
2020-03-12 8:30 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).