devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] dt-bindings: A few updates to PSCI and power-domain bindings
@ 2020-03-26 10:56 Ulf Hansson
  2020-03-26 10:56 ` [PATCH 1/2] dt-bindings: arm: Add some constraints for PSCI nodes Ulf Hansson
  2020-03-26 10:56 ` [PATCH 2/2] dt-bindings: power: Fix example for power-domain Ulf Hansson
  0 siblings, 2 replies; 5+ messages in thread
From: Ulf Hansson @ 2020-03-26 10:56 UTC (permalink / raw)
  To: Rob Herring, devicetree
  Cc: Sudeep Holla, Lorenzo Pieralisi, Rafael J . Wysocki, Lina Iyer,
	Ulf Hansson, linux-arm-kernel, linux-pm

Recent updates to the PSCI and the power-domain DT bindings, deserves some
additional improvements on top. This series takes care of this.

Ulf Hansson (2):
  dt-bindings: arm: Add some constraints for PSCI nodes
  dt-bindings: power: Fix example for power-domain

 .../devicetree/bindings/arm/psci.yaml         |  5 ++++
 .../bindings/power/power-domain.yaml          | 28 +++++++++----------
 2 files changed, 19 insertions(+), 14 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dt-bindings: arm: Add some constraints for PSCI nodes
  2020-03-26 10:56 [PATCH 0/2] dt-bindings: A few updates to PSCI and power-domain bindings Ulf Hansson
@ 2020-03-26 10:56 ` Ulf Hansson
  2020-03-31 22:05   ` Rob Herring
  2020-03-26 10:56 ` [PATCH 2/2] dt-bindings: power: Fix example for power-domain Ulf Hansson
  1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2020-03-26 10:56 UTC (permalink / raw)
  To: Rob Herring, devicetree
  Cc: Sudeep Holla, Lorenzo Pieralisi, Rafael J . Wysocki, Lina Iyer,
	Ulf Hansson, linux-arm-kernel, linux-pm

There's no point allowing anything else but "psci" for the corresponding
nodename of the PSCI node, so let's make this an explicit requirement.

Moreover, let's also prevent additional properties, which also allows a
better verification of the "patternProperties" bindings for subnodes.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 Documentation/devicetree/bindings/arm/psci.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml
index 5e66934455bb..9247b58c26fc 100644
--- a/Documentation/devicetree/bindings/arm/psci.yaml
+++ b/Documentation/devicetree/bindings/arm/psci.yaml
@@ -32,6 +32,9 @@ description: |+
     http://infocenter.arm.com/help/topic/com.arm.doc.den0022c/DEN0022C_Power_State_Coordination_Interface.pdf
 
 properties:
+  $nodename:
+    const: psci
+
   compatible:
     oneOf:
       - description:
@@ -141,6 +144,8 @@ allOf:
         - cpu_off
         - cpu_on
 
+additionalProperties: false
+
 examples:
   - |+
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dt-bindings: power: Fix example for power-domain
  2020-03-26 10:56 [PATCH 0/2] dt-bindings: A few updates to PSCI and power-domain bindings Ulf Hansson
  2020-03-26 10:56 ` [PATCH 1/2] dt-bindings: arm: Add some constraints for PSCI nodes Ulf Hansson
@ 2020-03-26 10:56 ` Ulf Hansson
  2020-03-31 22:05   ` Rob Herring
  1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2020-03-26 10:56 UTC (permalink / raw)
  To: Rob Herring, devicetree
  Cc: Sudeep Holla, Lorenzo Pieralisi, Rafael J . Wysocki, Lina Iyer,
	Ulf Hansson, linux-arm-kernel, linux-pm

The change that converted the domain-idle-states DT bindings to the
json-schema, forgot to update the corresponding example for the
power-domain binding. Let's fix it.

Fixes: 3261227d136d ("dt-bindings: power: Convert domain-idle-states bindings to json-schema")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 .../bindings/power/power-domain.yaml          | 28 +++++++++----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml
index 6047aacd7766..ff5936e4a215 100644
--- a/Documentation/devicetree/bindings/power/power-domain.yaml
+++ b/Documentation/devicetree/bindings/power/power-domain.yaml
@@ -114,18 +114,18 @@ examples:
         domain-idle-states = <&DOMAIN_PWR_DN>;
     };
 
-    DOMAIN_RET: state@0 {
-        compatible = "domain-idle-state";
-        reg = <0x0 0x0>;
-        entry-latency-us = <1000>;
-        exit-latency-us = <2000>;
-        min-residency-us = <10000>;
-    };
-
-    DOMAIN_PWR_DN: state@1 {
-        compatible = "domain-idle-state";
-        reg = <0x1 0x0>;
-        entry-latency-us = <5000>;
-        exit-latency-us = <8000>;
-        min-residency-us = <7000>;
+    domain-idle-states {
+        DOMAIN_RET: domain-retention {
+            compatible = "domain-idle-state";
+            entry-latency-us = <1000>;
+            exit-latency-us = <2000>;
+            min-residency-us = <10000>;
+        };
+
+        DOMAIN_PWR_DN: domain-pwr-dn {
+            compatible = "domain-idle-state";
+            entry-latency-us = <5000>;
+            exit-latency-us = <8000>;
+            min-residency-us = <7000>;
+        };
     };
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: Add some constraints for PSCI nodes
  2020-03-26 10:56 ` [PATCH 1/2] dt-bindings: arm: Add some constraints for PSCI nodes Ulf Hansson
@ 2020-03-31 22:05   ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-03-31 22:05 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: devicetree, Sudeep Holla, Lorenzo Pieralisi, Rafael J . Wysocki,
	Lina Iyer, Ulf Hansson, linux-arm-kernel, linux-pm

On Thu, 26 Mar 2020 11:56:25 +0100, Ulf Hansson wrote:
> There's no point allowing anything else but "psci" for the corresponding
> nodename of the PSCI node, so let's make this an explicit requirement.
> 
> Moreover, let's also prevent additional properties, which also allows a
> better verification of the "patternProperties" bindings for subnodes.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/psci.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: power: Fix example for power-domain
  2020-03-26 10:56 ` [PATCH 2/2] dt-bindings: power: Fix example for power-domain Ulf Hansson
@ 2020-03-31 22:05   ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-03-31 22:05 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: devicetree, Sudeep Holla, Lorenzo Pieralisi, Rafael J . Wysocki,
	Lina Iyer, Ulf Hansson, linux-arm-kernel, linux-pm

On Thu, 26 Mar 2020 11:56:26 +0100, Ulf Hansson wrote:
> The change that converted the domain-idle-states DT bindings to the
> json-schema, forgot to update the corresponding example for the
> power-domain binding. Let's fix it.
> 
> Fixes: 3261227d136d ("dt-bindings: power: Convert domain-idle-states bindings to json-schema")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  .../bindings/power/power-domain.yaml          | 28 +++++++++----------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-31 22:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 10:56 [PATCH 0/2] dt-bindings: A few updates to PSCI and power-domain bindings Ulf Hansson
2020-03-26 10:56 ` [PATCH 1/2] dt-bindings: arm: Add some constraints for PSCI nodes Ulf Hansson
2020-03-31 22:05   ` Rob Herring
2020-03-26 10:56 ` [PATCH 2/2] dt-bindings: power: Fix example for power-domain Ulf Hansson
2020-03-31 22:05   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).