devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: Document power-domains property
@ 2020-03-26 16:38 Geert Uytterhoeven
  2020-03-26 16:38 ` [PATCH 1/2] dt-bindings: usb: generic-ehci: " Geert Uytterhoeven
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-03-26 16:38 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring
  Cc: Yoshihiro Shimoda, linux-usb, devicetree, linux-renesas-soc,
	linux-kernel, Geert Uytterhoeven

	Hi Greg, Rob,

It is quite common for a generic EHCI or OHCI block to be embedded in an
SoC in its own power domain.  However, the current DT bindings do not
cover this yet, leading to "make dtbs_check" warnings like:

    arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
    arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080100: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'

This patch series documents the optional presence of "power-domains"
properties in the EHCI and OHCI devices nodes, allowing the DTS writer
to describe the controllers' positions in the power hierarchy.

Thanks!

Geert Uytterhoeven (2):
  dt-bindings: usb: generic-ehci: Document power-domains property
  dt-bindings: usb: generic-ohci: Document power-domains property

 Documentation/devicetree/bindings/usb/generic-ehci.yaml | 3 +++
 Documentation/devicetree/bindings/usb/generic-ohci.yaml | 3 +++
 2 files changed, 6 insertions(+)

-- 
2.17.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: usb: generic-ehci: Document power-domains property
  2020-03-26 16:38 [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: Document power-domains property Geert Uytterhoeven
@ 2020-03-26 16:38 ` Geert Uytterhoeven
  2020-04-10 16:31   ` Rob Herring
  2020-03-26 16:38 ` [PATCH 2/2] dt-bindings: usb: generic-ohci: " Geert Uytterhoeven
  2020-03-27  5:07 ` [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: " Yoshihiro Shimoda
  2 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-03-26 16:38 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring
  Cc: Yoshihiro Shimoda, linux-usb, devicetree, linux-renesas-soc,
	linux-kernel, Geert Uytterhoeven

It is quite common for a generic EHCI block to be embedded in an SoC in
its own power domain.  Hence allow the DTS writer to describe the
controller's position in the power hierarchy, by documenting the
optional presence of a "power-domains" property.

This gets rid of "make dtbs_check" warnings like:

    arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080100: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/usb/generic-ehci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index 10edd05872ea2537..848eea59bc0030e7 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -36,6 +36,9 @@ properties:
         - if a USB DRD channel: first clock should be host and second
           one should be peripheral
 
+  power-domains:
+    maxItems: 1
+
   big-endian:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] dt-bindings: usb: generic-ohci: Document power-domains property
  2020-03-26 16:38 [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: Document power-domains property Geert Uytterhoeven
  2020-03-26 16:38 ` [PATCH 1/2] dt-bindings: usb: generic-ehci: " Geert Uytterhoeven
@ 2020-03-26 16:38 ` Geert Uytterhoeven
  2020-04-10 16:31   ` Rob Herring
  2020-03-27  5:07 ` [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: " Yoshihiro Shimoda
  2 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-03-26 16:38 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring
  Cc: Yoshihiro Shimoda, linux-usb, devicetree, linux-renesas-soc,
	linux-kernel, Geert Uytterhoeven

It is quite common for a generic OHCI block to be embedded in an SoC in
its own power domain.  Hence allow the DTS writer to describe the
controller's position in the power hierarchy, by documenting the
optional presence of a "power-domains" property.

This gets rid of "make dtbs_check" warnings like:

    arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/usb/generic-ohci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index bcffec1f1341e502..d7efddf27b22e264 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -36,6 +36,9 @@ properties:
         - if a USB DRD channel: first clock should be host and second
           one should be peripheral
 
+  power-domains:
+    maxItems: 1
+
   big-endian:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* RE: [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: Document power-domains property
  2020-03-26 16:38 [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: Document power-domains property Geert Uytterhoeven
  2020-03-26 16:38 ` [PATCH 1/2] dt-bindings: usb: generic-ehci: " Geert Uytterhoeven
  2020-03-26 16:38 ` [PATCH 2/2] dt-bindings: usb: generic-ohci: " Geert Uytterhoeven
@ 2020-03-27  5:07 ` Yoshihiro Shimoda
  2 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2020-03-27  5:07 UTC (permalink / raw)
  To: Geert Uytterhoeven, Greg Kroah-Hartman, Rob Herring
  Cc: linux-usb, devicetree, linux-renesas-soc, linux-kernel

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Friday, March 27, 2020 1:38 AM
> 
> 	Hi Greg, Rob,
> 
> It is quite common for a generic EHCI or OHCI block to be embedded in an
> SoC in its own power domain.  However, the current DT bindings do not
> cover this yet, leading to "make dtbs_check" warnings like:
> 
>     arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080000: 'power-domains' does not match any of the
> regexes: 'pinctrl-[0-9]+'
>     arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080100: 'power-domains' does not match any of the
> regexes: 'pinctrl-[0-9]+'
> 
> This patch series documents the optional presence of "power-domains"
> properties in the EHCI and OHCI devices nodes, allowing the DTS writer
> to describe the controllers' positions in the power hierarchy.
> 
> Thanks!
> 
> Geert Uytterhoeven (2):
>   dt-bindings: usb: generic-ehci: Document power-domains property
>   dt-bindings: usb: generic-ohci: Document power-domains property

Thank you for the patches!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: usb: generic-ehci: Document power-domains property
  2020-03-26 16:38 ` [PATCH 1/2] dt-bindings: usb: generic-ehci: " Geert Uytterhoeven
@ 2020-04-10 16:31   ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-04-10 16:31 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, devicetree,
	linux-renesas-soc, linux-kernel, Geert Uytterhoeven

On Thu, 26 Mar 2020 17:38:05 +0100, Geert Uytterhoeven wrote:
> It is quite common for a generic EHCI block to be embedded in an SoC in
> its own power domain.  Hence allow the DTS writer to describe the
> controller's position in the power hierarchy, by documenting the
> optional presence of a "power-domains" property.
> 
> This gets rid of "make dtbs_check" warnings like:
> 
>     arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080100: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] dt-bindings: usb: generic-ohci: Document power-domains property
  2020-03-26 16:38 ` [PATCH 2/2] dt-bindings: usb: generic-ohci: " Geert Uytterhoeven
@ 2020-04-10 16:31   ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-04-10 16:31 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, linux-usb, devicetree,
	linux-renesas-soc, linux-kernel, Geert Uytterhoeven

On Thu, 26 Mar 2020 17:38:06 +0100, Geert Uytterhoeven wrote:
> It is quite common for a generic OHCI block to be embedded in an SoC in
> its own power domain.  Hence allow the DTS writer to describe the
> controller's position in the power hierarchy, by documenting the
> optional presence of a "power-domains" property.
> 
> This gets rid of "make dtbs_check" warnings like:
> 
>     arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dt.yaml: usb@ee080000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-10 17:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 16:38 [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: Document power-domains property Geert Uytterhoeven
2020-03-26 16:38 ` [PATCH 1/2] dt-bindings: usb: generic-ehci: " Geert Uytterhoeven
2020-04-10 16:31   ` Rob Herring
2020-03-26 16:38 ` [PATCH 2/2] dt-bindings: usb: generic-ohci: " Geert Uytterhoeven
2020-04-10 16:31   ` Rob Herring
2020-03-27  5:07 ` [PATCH 0/2] dt-bindings: usb: generic-ehci/ohci: " Yoshihiro Shimoda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).