* [PATCH v4 0/2] dts: uniphier: Add Akebi96 Board support
@ 2020-04-22 2:44 Masami Hiramatsu
2020-04-22 2:47 ` [PATCH v4 1/2] dt-bindings: arm: Add Akebi96 board support Masami Hiramatsu
2020-04-22 2:50 ` [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96 Masami Hiramatsu
0 siblings, 2 replies; 5+ messages in thread
From: Masami Hiramatsu @ 2020-04-22 2:44 UTC (permalink / raw)
To: Masahiro Yamada, Rob Herring, Masahiro Yamada
Cc: devicetree, Kunihiko Hayashi, Masami Hiramatsu, Jassi Brar,
Masami Hiramatsu, linux-arm-kernel
Hello,
Here is the 4th version of the patches to add a devicetree for
Akebi96 board.
This version fixes pinctrl_aout1 to remove unnecessary "aout1"
since which is not connected on the board.
The Akebi96 is a certified 96boards which is based on Socionext
UniPhier LD20 SoC. Most of the part is similar to LD20 reference
board, but there are some changes.
- MAX3421 USB-SPI chip on SPI port3 (for USB gadget port.)
- Simple frame buffer with 1080p fixed resolution.
- I2S port which is connected to aout1b instead of aout1.
- 3 serial ports, only serial3 has CTS/RTS.
- No NAND, only eMMC on the board.
- OP-TEE installed firmware.
See https://www.96boards.org/product/akebi96/ for details.
Thank you,
---
Masami Hiramatsu (2):
dt-bindings: arm: Add Akebi96 board support
arm64: dts: uniphier: Add support for Akebi96
.../bindings/arm/socionext/uniphier.yaml | 1
arch/arm64/boot/dts/socionext/Makefile | 1
.../boot/dts/socionext/uniphier-ld20-akebi96.dts | 190 ++++++++++++++++++++
3 files changed, 192 insertions(+)
create mode 100644 arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dts
--
Masami Hiramatsu <masami.hiramatsu@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 1/2] dt-bindings: arm: Add Akebi96 board support
2020-04-22 2:44 [PATCH v4 0/2] dts: uniphier: Add Akebi96 Board support Masami Hiramatsu
@ 2020-04-22 2:47 ` Masami Hiramatsu
2020-04-22 2:50 ` [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96 Masami Hiramatsu
1 sibling, 0 replies; 5+ messages in thread
From: Masami Hiramatsu @ 2020-04-22 2:47 UTC (permalink / raw)
To: Masahiro Yamada, Rob Herring, Masahiro Yamada
Cc: devicetree, Kunihiko Hayashi, Jassi Brar, Masami Hiramatsu,
linux-arm-kernel
Add uniphier-ld20-akebi96 compatible string for
Akebi96 board support.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
---
.../bindings/arm/socionext/uniphier.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/socionext/uniphier.yaml b/Documentation/devicetree/bindings/arm/socionext/uniphier.yaml
index 65ad6d8a3c99..10a7f0752281 100644
--- a/Documentation/devicetree/bindings/arm/socionext/uniphier.yaml
+++ b/Documentation/devicetree/bindings/arm/socionext/uniphier.yaml
@@ -51,6 +51,7 @@ properties:
- description: LD20 SoC boards
items:
- enum:
+ - socionext,uniphier-ld20-akebi96
- socionext,uniphier-ld20-global
- socionext,uniphier-ld20-ref
- const: socionext,uniphier-ld20
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96
2020-04-22 2:44 [PATCH v4 0/2] dts: uniphier: Add Akebi96 Board support Masami Hiramatsu
2020-04-22 2:47 ` [PATCH v4 1/2] dt-bindings: arm: Add Akebi96 board support Masami Hiramatsu
@ 2020-04-22 2:50 ` Masami Hiramatsu
2020-04-22 15:08 ` Masahiro Yamada
1 sibling, 1 reply; 5+ messages in thread
From: Masami Hiramatsu @ 2020-04-22 2:50 UTC (permalink / raw)
To: Masahiro Yamada, Rob Herring, Masahiro Yamada
Cc: devicetree, Kunihiko Hayashi, Jassi Brar, Masami Hiramatsu,
linux-arm-kernel
Add the device tree for Akebi96. Akebi96 is a 96boards certified
development board based on UniPhir LD20.
( https://www.96boards.org/product/akebi96/ )
This board has;
- MAX3421 USB-SPI chip on SPI port3 (for USB gadget port)
- Simple frame buffer with 1080p fixed resolution.
- I2S port which is connected to aout1b instead of aout1.
- 3 serial ports, only serial3 has CTS/RTS.
- No NAND, only eMMC on the board.
- OP-TEE installed firmware.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
Changes in v4:
- Fix to remove unnecessary "aout1" from pinctrl_aout1.
---
arch/arm64/boot/dts/socionext/Makefile | 1
.../boot/dts/socionext/uniphier-ld20-akebi96.dts | 190 ++++++++++++++++++++
2 files changed, 191 insertions(+)
create mode 100644 arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dts
diff --git a/arch/arm64/boot/dts/socionext/Makefile b/arch/arm64/boot/dts/socionext/Makefile
index d45441249cb5..dda3da33614b 100644
--- a/arch/arm64/boot/dts/socionext/Makefile
+++ b/arch/arm64/boot/dts/socionext/Makefile
@@ -2,6 +2,7 @@
dtb-$(CONFIG_ARCH_UNIPHIER) += \
uniphier-ld11-global.dtb \
uniphier-ld11-ref.dtb \
+ uniphier-ld20-akebi96.dtb \
uniphier-ld20-global.dtb \
uniphier-ld20-ref.dtb \
uniphier-pxs3-ref.dtb
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dts
new file mode 100644
index 000000000000..c0673b2d2c89
--- /dev/null
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dts
@@ -0,0 +1,190 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+//
+// Device Tree Source for Akebi96 Development Board
+//
+// Derived from uniphier-ld20-global.dts.
+//
+// Copyright (C) 2015-2017 Socionext Inc.
+// Copyright (C) 2019-2020 Linaro Ltd.
+
+/dts-v1/;
+#include <dt-bindings/gpio/uniphier-gpio.h>
+#include "uniphier-ld20.dtsi"
+
+/ {
+ model = "Akebi96";
+ compatible = "socionext,uniphier-ld20-akebi96",
+ "socionext,uniphier-ld20";
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ aliases {
+ serial0 = &serial0;
+ serial1 = &serial1;
+ serial2 = &serial2;
+ serial3 = &serial3;
+ i2c0 = &i2c0;
+ i2c1 = &i2c1;
+ i2c2 = &i2c2;
+ i2c3 = &i2c3;
+ i2c4 = &i2c4;
+ i2c5 = &i2c5;
+ spi0 = &spi0;
+ spi1 = &spi1;
+ spi2 = &spi2;
+ spi3 = &spi3;
+ ethernet0 = ð
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ reg = <0 0x80000000 0 0xc0000000>;
+ };
+
+ framebuffer {
+ compatible = "simple-framebuffer";
+ reg = <0 0xc0000000 0 0x02000000>;
+ width = <1920>;
+ height = <1080>;
+ stride = <7680>;
+ format = "a8r8g8b8";
+ };
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ memory@c0000000 {
+ reg = <0 0xc0000000 0 0x02000000>;
+ no-map;
+ };
+ };
+
+ sound {
+ compatible = "audio-graph-card";
+ label = "UniPhier LD20";
+ dais = <&spdif_port0
+ &comp_spdif_port0>;
+ };
+
+ spdif-out {
+ compatible = "linux,spdif-dit";
+ #sound-dai-cells = <0>;
+
+ port@0 {
+ spdif_tx: endpoint {
+ remote-endpoint = <&spdif_hiecout1>;
+ };
+ };
+ };
+
+ comp-spdif-out {
+ compatible = "linux,spdif-dit";
+ #sound-dai-cells = <0>;
+
+ port@0 {
+ comp_spdif_tx: endpoint {
+ remote-endpoint = <&comp_spdif_hiecout1>;
+ };
+ };
+ };
+
+ firmware {
+ optee {
+ compatible = "linaro,optee-tz";
+ method = "smc";
+ };
+ };
+};
+
+&serial0 {
+ /* Onboard USB-UART */
+ status = "okay";
+};
+
+&serial2 {
+ /* LS connector UART1 */
+ status = "okay";
+};
+
+&serial3 {
+ /* LS connector UART0 */
+ status = "okay";
+};
+
+&spdif_hiecout1 {
+ remote-endpoint = <&spdif_tx>;
+};
+
+&comp_spdif_hiecout1 {
+ remote-endpoint = <&comp_spdif_tx>;
+};
+
+ð {
+ status = "okay";
+ phy-mode = "rgmii";
+ pinctrl-0 = <&pinctrl_ether_rgmii>;
+ phy-handle = <ðphy>;
+};
+
+&mdio {
+ ethphy: ethphy@0 {
+ reg = <0>;
+ };
+};
+
+&usb {
+ status = "okay";
+};
+
+&pcie {
+ status = "okay";
+};
+
+&i2c0 {
+ /* LS connector I2C0 */
+ status = "okay";
+};
+
+&i2c1 {
+ /* LS connector I2C1 */
+ status = "okay";
+};
+
+&spi3 {
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ usb-over-spi@0 {
+ compatible = "maxim,max3421-udc";
+ reg = <0>;
+ spi-max-frequency = <12500000>;
+ interrupt-parent = <&gpio>;
+ interrupts = <0 2>, <10 3>;
+ };
+};
+
+&gpio {
+ /* IRQs for Max3421 */
+ xirq0 {
+ gpio-hog;
+ gpios = <UNIPHIER_GPIO_IRQ(0) 1>;
+ input;
+ };
+ xirq10 {
+ gpio-hog;
+ gpios = <UNIPHIER_GPIO_IRQ(10) 1>;
+ input;
+ };
+};
+
+&pinctrl_aout1 {
+ groups = "aout1b";
+};
+
+&pinctrl_uart3 {
+ groups = "uart3", "uart3_ctsrts";
+};
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96
2020-04-22 2:50 ` [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96 Masami Hiramatsu
@ 2020-04-22 15:08 ` Masahiro Yamada
2020-04-22 15:35 ` Masami Hiramatsu
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2020-04-22 15:08 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: Rob Herring, DTML, Kunihiko Hayashi, Jassi Brar,
Masami Hiramatsu, linux-arm-kernel
Hiramatsu-san
On Wed, Apr 22, 2020 at 11:50 AM Masami Hiramatsu
<masami.hiramatsu@linaro.org> wrote:
> +
> +ð {
> + status = "okay";
> + phy-mode = "rgmii";
> + pinctrl-0 = <&pinctrl_ether_rgmii>;
These two lines are actually redundant because RGMII
is the default in uniphier-ld20.dtsi
(and uniphier-ld20-ref.dts skips them.)
Did you intentionally make it verbose?
> + phy-handle = <ðphy>;
> +};
> +
> +&mdio {
> + ethphy: ethphy@0 {
> + reg = <0>;
> + };
> +};
> +
> +&usb {
> + status = "okay";
> +};
> +
> +&pcie {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + /* LS connector I2C0 */
> + status = "okay";
> +};
> +
> +&i2c1 {
> + /* LS connector I2C1 */
> + status = "okay";
> +};
> +
> +&spi3 {
> + status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
Adding #address-cells and #size-sizes to a board DTS
is strange.
I will apply this:
https://lore.kernel.org/patchwork/patch/1229497/
then delete the lines above.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96
2020-04-22 15:08 ` Masahiro Yamada
@ 2020-04-22 15:35 ` Masami Hiramatsu
0 siblings, 0 replies; 5+ messages in thread
From: Masami Hiramatsu @ 2020-04-22 15:35 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Rob Herring, Kunihiko Hayashi, DTML, Jassi Brar,
Masami Hiramatsu, linux-arm-kernel
Hello Yamada-san,
2020年4月23日(木) 0:10 Masahiro Yamada <masahiroy@kernel.org>:
>
> Hiramatsu-san
>
> On Wed, Apr 22, 2020 at 11:50 AM Masami Hiramatsu
> <masami.hiramatsu@linaro.org> wrote:
>
> > +
> > +ð {
> > + status = "okay";
> > + phy-mode = "rgmii";
> > + pinctrl-0 = <&pinctrl_ether_rgmii>;
>
> These two lines are actually redundant because RGMII
> is the default in uniphier-ld20.dtsi
> (and uniphier-ld20-ref.dts skips them.)
>
> Did you intentionally make it verbose?
Oops, no, we don't need it. It's a legacy code (IIRC, there's a
historical reason).
> > +&spi3 {
> > + status = "okay";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> Adding #address-cells and #size-sizes to a board DTS
> is strange.
Indeed.
> I will apply this:
> https://lore.kernel.org/patchwork/patch/1229497/
> then delete the lines above.
OK, I'll update.
Thank you,
--
Masami Hiramatsu
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-22 15:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 2:44 [PATCH v4 0/2] dts: uniphier: Add Akebi96 Board support Masami Hiramatsu
2020-04-22 2:47 ` [PATCH v4 1/2] dt-bindings: arm: Add Akebi96 board support Masami Hiramatsu
2020-04-22 2:50 ` [PATCH v4 2/2] arm64: dts: uniphier: Add support for Akebi96 Masami Hiramatsu
2020-04-22 15:08 ` Masahiro Yamada
2020-04-22 15:35 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).