devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
@ 2020-06-29 19:23 Fabio Estevam
  2020-06-30  2:02 ` Rob Herring
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-06-29 19:23 UTC (permalink / raw)
  To: robh+dt; +Cc: lee.jones, benjamin.gaignard, devicetree, Fabio Estevam

The following build error is seen with 'make dt_binding_check':

  CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
/home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'

Remove the extra 'additionalProperties' to pass the build.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
index 0ce56a0da553..bed22d4abffb 100644
--- a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
@@ -73,8 +73,6 @@ properties:
           output-high: true
           output-low: true
 
-      additionalProperties: false
-
     additionalProperties: false
 
     required:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
  2020-06-29 19:23 [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties Fabio Estevam
@ 2020-06-30  2:02 ` Rob Herring
  2020-06-30  7:08 ` Lee Jones
  2020-07-01  7:21 ` Benjamin GAIGNARD
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-06-30  2:02 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: benjamin.gaignard, robh+dt, devicetree, lee.jones

On Mon, 29 Jun 2020 16:23:35 -0300, Fabio Estevam wrote:
> The following build error is seen with 'make dt_binding_check':
> 
>   CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
> 
> Remove the extra 'additionalProperties' to pass the build.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
  2020-06-29 19:23 [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties Fabio Estevam
  2020-06-30  2:02 ` Rob Herring
@ 2020-06-30  7:08 ` Lee Jones
  2020-07-01  7:21 ` Benjamin GAIGNARD
  2 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2020-06-30  7:08 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: robh+dt, benjamin.gaignard, devicetree

On Mon, 29 Jun 2020, Fabio Estevam wrote:

> The following build error is seen with 'make dt_binding_check':
> 
>   CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
> 
> Remove the extra 'additionalProperties' to pass the build.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
>  1 file changed, 2 deletions(-)

Any reason for not sending this to LKML?

> diff --git a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> index 0ce56a0da553..bed22d4abffb 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> @@ -73,8 +73,6 @@ properties:
>            output-high: true
>            output-low: true
>  
> -      additionalProperties: false
> -
>      additionalProperties: false
>  
>      required:

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
  2020-06-29 19:23 [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties Fabio Estevam
  2020-06-30  2:02 ` Rob Herring
  2020-06-30  7:08 ` Lee Jones
@ 2020-07-01  7:21 ` Benjamin GAIGNARD
  2020-07-01  9:36   ` Lee Jones
  2 siblings, 1 reply; 5+ messages in thread
From: Benjamin GAIGNARD @ 2020-07-01  7:21 UTC (permalink / raw)
  To: Fabio Estevam, robh+dt; +Cc: lee.jones, devicetree



On 6/29/20 9:23 PM, Fabio Estevam wrote:
> The following build error is seen with 'make dt_binding_check':
>
>    CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
>
> Remove the extra 'additionalProperties' to pass the build.
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>   Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> index 0ce56a0da553..bed22d4abffb 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> @@ -73,8 +73,6 @@ properties:
>             output-high: true
>             output-low: true
>   
> -      additionalProperties: false
> -
>       additionalProperties: false
>   
>       required:

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties
  2020-07-01  7:21 ` Benjamin GAIGNARD
@ 2020-07-01  9:36   ` Lee Jones
  0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2020-07-01  9:36 UTC (permalink / raw)
  To: Benjamin GAIGNARD; +Cc: Fabio Estevam, robh+dt, devicetree

On Wed, 01 Jul 2020, Benjamin GAIGNARD wrote:

> 
> 
> On 6/29/20 9:23 PM, Fabio Estevam wrote:
> > The following build error is seen with 'make dt_binding_check':
> >
> >    CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> > /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
> >
> > Remove the extra 'additionalProperties' to pass the build.
> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>

FYI: The resend of this patch has already been applied.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-01  9:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 19:23 [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties Fabio Estevam
2020-06-30  2:02 ` Rob Herring
2020-06-30  7:08 ` Lee Jones
2020-07-01  7:21 ` Benjamin GAIGNARD
2020-07-01  9:36   ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).