From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Masahisa Kojima <masahisa.kojima@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ardb@kernel.org,
devicetree@vger.kernel.org, linux-integrity@vger.kernel.org,
peterhuewe@gmx.de, jgg@ziepe.ca
Subject: Re: [PATCH v3 0/2] synquacer: add TPM support
Date: Wed, 8 Jul 2020 19:20:17 +0300 [thread overview]
Message-ID: <20200708162017.GB549022@linux.intel.com> (raw)
In-Reply-To: <20200708131424.18729-1-masahisa.kojima@linaro.org>
On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote:
> This adds support for driving the TPM on Socionext SynQuacer platform
> using the driver for a memory mapped TIS frame.
>
> v3:
> - prepare new module to handle TPM MMIO access on SynQuacer platform
>
> v2:
> - don't use read/write_bytes() to implement read/write16/32 since that uses
> the wrong address
>
> Cc: jarkko.sakkinen@linux.intel.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: ardb@kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-integrity@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: peterhuewe@gmx.de
> Cc: jgg@ziepe.ca
>
> Masahisa Kojima (2):
> tpm: tis: add support for MMIO TPM on SynQuacer
> dt-bindings: Add SynQucer TPM MMIO as a trivial device
>
> .../devicetree/bindings/trivial-devices.yaml | 2 +
> drivers/char/tpm/Kconfig | 12 ++
> drivers/char/tpm/Makefile | 1 +
> drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++
> 4 files changed, 211 insertions(+)
> create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c
>
> --
> 2.20.1
>
Overally the code looks great. You've run it through checkpatch.pl?
/Jarkko
next prev parent reply other threads:[~2020-07-08 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 13:14 [PATCH v3 0/2] synquacer: add TPM support Masahisa Kojima
2020-07-08 13:14 ` [PATCH v3 1/2] tpm: tis: add support for MMIO TPM on SynQuacer Masahisa Kojima
2020-07-08 15:41 ` Ard Biesheuvel
2020-07-08 16:30 ` Jarkko Sakkinen
2020-07-08 23:39 ` Masahisa Kojima
2020-07-08 13:14 ` [PATCH v3 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device Masahisa Kojima
2020-07-13 23:05 ` Rob Herring
2020-07-08 16:20 ` Jarkko Sakkinen [this message]
2020-07-08 23:34 ` [PATCH v3 0/2] synquacer: add TPM support Masahisa Kojima
2020-07-08 23:46 ` Masahisa Kojima
2020-07-09 12:00 ` Jarkko Sakkinen
2020-07-09 11:42 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708162017.GB549022@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ardb@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahisa.kojima@linaro.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).