devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Add missing ethernet reset ID for Amlogic SoC
@ 2020-07-31  8:20 Anand Moon
  2020-07-31  8:20 ` [PATCH v2 1/3] arm64: dts: amlogic: meson-gx: add missing ethernet reset ID Anand Moon
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Anand Moon @ 2020-07-31  8:20 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-amlogic
  Cc: Rob Herring, Martin Blumenstingl, Jerome Brunet, Neil Armstrong,
	Kevin Hilman, Anand Moon

Add reset id for Ethernet to reset Ethernet IP.

Re-based on linux-next-20200730.
Could not test as their is build failed on linux-next-20200730. 

My observation:
- Sometime the device on upgrade of the kernel
  don't show up in the network.
- My observation that Ethernet interface come up successfully
  but no packet get forwarded.
- This happens some times on my network.

-Anand

Anand Moon (3):
  arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
  arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
  arm64: dts: amlogic: meson-g12: add missing ethernet reset ID

 arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 2 ++
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 3 +++
 3 files changed, 7 insertions(+)

-- 
2.28.0
:

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/3] arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
  2020-07-31  8:20 [PATCH v2 0/3] Add missing ethernet reset ID for Amlogic SoC Anand Moon
@ 2020-07-31  8:20 ` Anand Moon
  2020-07-31  8:20 ` [PATCH v2 2/3] arm64: dts: amlogic: meson-axg: " Anand Moon
  2020-07-31  8:20 ` [PATCH v2 3/3] arm64: dts: amlogic: meson-g12: " Anand Moon
  2 siblings, 0 replies; 4+ messages in thread
From: Anand Moon @ 2020-07-31  8:20 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-amlogic
  Cc: Rob Herring, Martin Blumenstingl, Jerome Brunet, Neil Armstrong,
	Kevin Hilman, Anand Moon

Add missing etherent reset ID for reset controller to reset
ethernet mac controller.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Changes V2
-Rebased on linux-next-20200730
---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index 0edd137151f8..726b91d3a905 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -13,6 +13,7 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/meson-gxbb-power.h>
+#include <dt-bindings/reset/amlogic,meson-gxbb-reset.h>
 #include <dt-bindings/thermal/thermal.h>
 
 / {
@@ -575,6 +576,8 @@ ethmac: ethernet@c9410000 {
 			interrupt-names = "macirq";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			power-domains = <&pwrc PWRC_GXBB_ETHERNET_MEM_ID>;
 			status = "disabled";
 		};
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/3] arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
  2020-07-31  8:20 [PATCH v2 0/3] Add missing ethernet reset ID for Amlogic SoC Anand Moon
  2020-07-31  8:20 ` [PATCH v2 1/3] arm64: dts: amlogic: meson-gx: add missing ethernet reset ID Anand Moon
@ 2020-07-31  8:20 ` Anand Moon
  2020-07-31  8:20 ` [PATCH v2 3/3] arm64: dts: amlogic: meson-g12: " Anand Moon
  2 siblings, 0 replies; 4+ messages in thread
From: Anand Moon @ 2020-07-31  8:20 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-amlogic
  Cc: Rob Herring, Martin Blumenstingl, Jerome Brunet, Neil Armstrong,
	Kevin Hilman, Anand Moon

Add missing etherent reset ID for reset controller to reset
ethernet mac controller.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Changes V2
-Rebased on linux-next-20200730
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index b9efc8469265..8e134cb470d3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -187,6 +187,8 @@ ethmac: ethernet@ff3f0000 {
 				      "timing-adjustment";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			status = "disabled";
 		};
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 3/3] arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
  2020-07-31  8:20 [PATCH v2 0/3] Add missing ethernet reset ID for Amlogic SoC Anand Moon
  2020-07-31  8:20 ` [PATCH v2 1/3] arm64: dts: amlogic: meson-gx: add missing ethernet reset ID Anand Moon
  2020-07-31  8:20 ` [PATCH v2 2/3] arm64: dts: amlogic: meson-axg: " Anand Moon
@ 2020-07-31  8:20 ` Anand Moon
  2 siblings, 0 replies; 4+ messages in thread
From: Anand Moon @ 2020-07-31  8:20 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-amlogic
  Cc: Rob Herring, Martin Blumenstingl, Jerome Brunet, Neil Armstrong,
	Kevin Hilman, Anand Moon

Add missing etherent reset ID for reset controller to reset
ethernet mac controller.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
----
Changes V2:
-Rebased on linux-next-2020730
---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 1e83ec5b8c91..63d19fbe8899 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -224,6 +224,8 @@ ethmac: ethernet@ff3f0000 {
 				      "timing-adjustment";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			status = "disabled";
 
 			mdio0: mdio {
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-31  8:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31  8:20 [PATCH v2 0/3] Add missing ethernet reset ID for Amlogic SoC Anand Moon
2020-07-31  8:20 ` [PATCH v2 1/3] arm64: dts: amlogic: meson-gx: add missing ethernet reset ID Anand Moon
2020-07-31  8:20 ` [PATCH v2 2/3] arm64: dts: amlogic: meson-axg: " Anand Moon
2020-07-31  8:20 ` [PATCH v2 3/3] arm64: dts: amlogic: meson-g12: " Anand Moon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).