From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 2/7] drm: rcar-du: Add r8a7742 support
Date: Sun, 9 Aug 2020 00:02:19 +0300 [thread overview]
Message-ID: <20200808210219.GN6186@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200807174954.14448-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar,
Thank you for the patch.
On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote:
> Add direct support for the r8a7742 (RZ/G1H).
>
> The RZ/G1H shares a common, compatible configuration with the r8a7790
> (R-Car H2) so that device info structure is reused, the only difference
> being TCON is unsupported on RZ/G1H (Currently unsupported by the driver).
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 3e67cf70f040..7e286c7a7a6c 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = {
> .channels_mask = BIT(2) | BIT(1) | BIT(0),
> .routes = {
> /*
> - * R8A7790 has one RGB output, two LVDS outputs and one
> - * (currently unsupported) TCON output.
> + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally
> + * R8A7790 supports one TCON output (currently unsupported by the driver).
Once we support TCON we'll have to split this, but for now I suppose
it's fine. Would you however mind wrapping this to 80 columns ? I can do
so when applying if it's fine with you.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> */
> [RCAR_DU_OUTPUT_DPAD0] = {
> .possible_crtcs = BIT(2) | BIT(1) | BIT(0),
> @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = {
> };
>
> static const struct of_device_id rcar_du_of_table[] = {
> + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info },
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-08-08 21:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 17:49 [PATCH 0/7] r8a7742: Enable DU and LVDS Lad Prabhakar
2020-08-07 17:49 ` [PATCH 1/7] dt-bindings: display: renesas,du: Document the r8a7742 bindings Lad Prabhakar
2020-08-08 20:59 ` Laurent Pinchart
2020-08-24 22:20 ` [PATCH 1/7] dt-bindings: display: renesas, du: " Rob Herring
2020-08-07 17:49 ` [PATCH 2/7] drm: rcar-du: Add r8a7742 support Lad Prabhakar
2020-08-08 21:02 ` Laurent Pinchart [this message]
2020-08-09 20:38 ` Lad, Prabhakar
2020-08-09 23:03 ` Laurent Pinchart
2020-08-07 17:49 ` [PATCH 3/7] dt-bindings: display: renesas,lvds: Document r8a7742 bindings Lad Prabhakar
2020-08-08 21:03 ` Laurent Pinchart
2020-08-08 21:05 ` Laurent Pinchart
2020-08-09 21:10 ` Lad, Prabhakar
2020-08-24 22:20 ` [PATCH 3/7] dt-bindings: display: renesas, lvds: " Rob Herring
2020-08-07 17:49 ` [PATCH 4/7] drm: rcar-du: lvds: Add r8a7742 support Lad Prabhakar
2020-08-08 21:06 ` Laurent Pinchart
2020-08-07 17:49 ` [PATCH 5/7] ARM: dts: r8a7742: Add DU support Lad Prabhakar
2020-08-07 19:48 ` Sergei Shtylyov
2020-08-07 20:22 ` Lad, Prabhakar
2020-08-10 8:53 ` Geert Uytterhoeven
2020-08-08 21:15 ` Laurent Pinchart
2020-08-07 17:49 ` [PATCH 6/7] ARM: dts: r8a7742: Add LVDS support Lad Prabhakar
2020-08-08 21:13 ` Laurent Pinchart
2020-08-09 21:29 ` Lad, Prabhakar
2020-08-10 8:27 ` Geert Uytterhoeven
2020-08-07 17:49 ` [PATCH 7/7] ARM: dts: r8a7742-iwg21d-q7: Add LCD support Lad Prabhakar
2020-08-08 21:22 ` Laurent Pinchart
2020-08-09 21:35 ` Lad, Prabhakar
2020-08-11 11:26 ` Laurent Pinchart
2020-08-13 12:54 ` Lad, Prabhakar
2020-08-08 20:55 ` [PATCH 0/7] r8a7742: Enable DU and LVDS Laurent Pinchart
2020-08-09 21:43 ` Lad, Prabhakar
2020-08-10 8:27 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808210219.GN6186@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).