* [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742
2020-08-10 17:41 [PATCH 0/2] r8a7742 add PCIe node Lad Prabhakar
@ 2020-08-10 17:41 ` Lad Prabhakar
2020-08-12 8:50 ` Geert Uytterhoeven
` (2 more replies)
2020-08-10 17:41 ` [PATCH 2/2] ARM: dts: r8a7742: Add PCIe Controller device node Lad Prabhakar
2020-09-07 14:51 ` [PATCH 0/2] r8a7742 add PCIe node Lorenzo Pieralisi
2 siblings, 3 replies; 8+ messages in thread
From: Lad Prabhakar @ 2020-08-10 17:41 UTC (permalink / raw)
To: Geert Uytterhoeven, Rob Herring, Marek Vasut, Yoshihiro Shimoda,
Bjorn Helgaas, linux-renesas-soc, devicetree
Cc: linux-pci, Magnus Damm, linux-kernel, Prabhakar, Lad Prabhakar,
Chris Paterson
Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
is identical to the R-Car Gen2 family.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
Documentation/devicetree/bindings/pci/rcar-pci.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
index 1041c44a614f..14d307deff06 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
@@ -1,7 +1,8 @@
* Renesas R-Car PCIe interface
Required properties:
-compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
+compatible: "renesas,pcie-r8a7742" for the R8A7742 SoC;
+ "renesas,pcie-r8a7743" for the R8A7743 SoC;
"renesas,pcie-r8a7744" for the R8A7744 SoC;
"renesas,pcie-r8a774a1" for the R8A774A1 SoC;
"renesas,pcie-r8a774b1" for the R8A774B1 SoC;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742
2020-08-10 17:41 ` [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742 Lad Prabhakar
@ 2020-08-12 8:50 ` Geert Uytterhoeven
2020-08-17 8:19 ` Yoshihiro Shimoda
2020-08-24 23:05 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2020-08-12 8:50 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Rob Herring, Marek Vasut, Yoshihiro Shimoda, Bjorn Helgaas,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-pci, Magnus Damm, Linux Kernel Mailing List, Prabhakar,
Chris Paterson
On Mon, Aug 10, 2020 at 7:42 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742
2020-08-10 17:41 ` [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742 Lad Prabhakar
2020-08-12 8:50 ` Geert Uytterhoeven
@ 2020-08-17 8:19 ` Yoshihiro Shimoda
2020-08-24 23:05 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Yoshihiro Shimoda @ 2020-08-17 8:19 UTC (permalink / raw)
To: Prabhakar Mahadev Lad, Geert Uytterhoeven, Rob Herring,
Marek Vasut, Bjorn Helgaas, linux-renesas-soc, devicetree
Cc: linux-pci, Magnus Damm, linux-kernel, Prabhakar,
Prabhakar Mahadev Lad, Chris Paterson
Hi Lad-san,
> From: Lad Prabhakar, Sent: Tuesday, August 11, 2020 2:42 AM
>
> Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Thank you for your patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742
2020-08-10 17:41 ` [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742 Lad Prabhakar
2020-08-12 8:50 ` Geert Uytterhoeven
2020-08-17 8:19 ` Yoshihiro Shimoda
@ 2020-08-24 23:05 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-08-24 23:05 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Chris Paterson, Magnus Damm, Prabhakar, linux-kernel,
Yoshihiro Shimoda, Bjorn Helgaas, linux-pci, Marek Vasut,
linux-renesas-soc, devicetree, Rob Herring, Geert Uytterhoeven
On Mon, 10 Aug 2020 18:41:55 +0100, Lad Prabhakar wrote:
> Add support for r8a7742. The Renesas RZ/G1H (R8A7742) PCIe controller
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> Documentation/devicetree/bindings/pci/rcar-pci.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7742: Add PCIe Controller device node
2020-08-10 17:41 [PATCH 0/2] r8a7742 add PCIe node Lad Prabhakar
2020-08-10 17:41 ` [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742 Lad Prabhakar
@ 2020-08-10 17:41 ` Lad Prabhakar
2020-08-12 9:12 ` Geert Uytterhoeven
2020-09-07 14:51 ` [PATCH 0/2] r8a7742 add PCIe node Lorenzo Pieralisi
2 siblings, 1 reply; 8+ messages in thread
From: Lad Prabhakar @ 2020-08-10 17:41 UTC (permalink / raw)
To: Geert Uytterhoeven, Rob Herring, Marek Vasut, Yoshihiro Shimoda,
Bjorn Helgaas, linux-renesas-soc, devicetree
Cc: linux-pci, Magnus Damm, linux-kernel, Prabhakar, Lad Prabhakar,
Chris Paterson
Add a device node for the PCIe controller on the Renesas
RZ/G1H (r8a7742) SoC.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
arch/arm/boot/dts/r8a7742.dtsi | 35 ++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7742.dtsi b/arch/arm/boot/dts/r8a7742.dtsi
index a7e66220d63a..6e1292acbf2a 100644
--- a/arch/arm/boot/dts/r8a7742.dtsi
+++ b/arch/arm/boot/dts/r8a7742.dtsi
@@ -188,6 +188,13 @@
clock-frequency = <0>;
};
+ /* External PCIe clock - can be overridden by the board */
+ pcie_bus_clk: pcie_bus {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <0>;
+ };
+
pmu-0 {
compatible = "arm,cortex-a15-pmu";
interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
@@ -1509,6 +1516,34 @@
resets = <&cpg 408>;
};
+ pciec: pcie@fe000000 {
+ compatible = "renesas,pcie-r8a7742",
+ "renesas,pcie-rcar-gen2";
+ reg = <0 0xfe000000 0 0x80000>;
+ #address-cells = <3>;
+ #size-cells = <2>;
+ bus-range = <0x00 0xff>;
+ device_type = "pci";
+ ranges = <0x01000000 0 0x00000000 0 0xfe100000 0 0x00100000>,
+ <0x02000000 0 0xfe200000 0 0xfe200000 0 0x00200000>,
+ <0x02000000 0 0x30000000 0 0x30000000 0 0x08000000>,
+ <0x42000000 0 0x38000000 0 0x38000000 0 0x08000000>;
+ /* Map all possible DDR as inbound ranges */
+ dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x80000000>,
+ <0x43000000 1 0x80000000 1 0x80000000 0 0x80000000>;
+ interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
+ #interrupt-cells = <1>;
+ interrupt-map-mask = <0 0 0 0>;
+ interrupt-map = <0 0 0 0 &gic GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 319>, <&pcie_bus_clk>;
+ clock-names = "pcie", "pcie_bus";
+ power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
+ resets = <&cpg 319>;
+ status = "disabled";
+ };
+
du: display@feb00000 {
compatible = "renesas,du-r8a7742";
reg = <0 0xfeb00000 0 0x70000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] ARM: dts: r8a7742: Add PCIe Controller device node
2020-08-10 17:41 ` [PATCH 2/2] ARM: dts: r8a7742: Add PCIe Controller device node Lad Prabhakar
@ 2020-08-12 9:12 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2020-08-12 9:12 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Rob Herring, Marek Vasut, Yoshihiro Shimoda, Bjorn Helgaas,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-pci, Magnus Damm, Linux Kernel Mailing List, Prabhakar,
Chris Paterson
On Mon, Aug 10, 2020 at 7:42 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add a device node for the PCIe controller on the Renesas
> RZ/G1H (r8a7742) SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.10.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] r8a7742 add PCIe node
2020-08-10 17:41 [PATCH 0/2] r8a7742 add PCIe node Lad Prabhakar
2020-08-10 17:41 ` [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742 Lad Prabhakar
2020-08-10 17:41 ` [PATCH 2/2] ARM: dts: r8a7742: Add PCIe Controller device node Lad Prabhakar
@ 2020-09-07 14:51 ` Lorenzo Pieralisi
2 siblings, 0 replies; 8+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-07 14:51 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Geert Uytterhoeven, Rob Herring, Marek Vasut, Yoshihiro Shimoda,
Bjorn Helgaas, linux-renesas-soc, devicetree, linux-pci,
Magnus Damm, linux-kernel, Prabhakar, Chris Paterson
On Mon, Aug 10, 2020 at 06:41:54PM +0100, Lad Prabhakar wrote:
> Hi All,
>
> This patch set adds PCIe instance to r8a7742 Soc dtsi.
> patches apply on-top of [1] + [2]
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/
> renesas-devel.git/log/?h=renesas-arm-dt-for-v5.10
> [2] https://patchwork.kernel.org/project/linux-renesas-soc/
> list/?series=330277
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (2):
> dt-bindings: PCI: rcar: Add device tree support for r8a7742
> ARM: dts: r8a7742: Add PCIe Controller device node
>
> .../devicetree/bindings/pci/rcar-pci.txt | 3 +-
> arch/arm/boot/dts/r8a7742.dtsi | 35 +++++++++++++++++++
> 2 files changed, 37 insertions(+), 1 deletion(-)
I took patch (1) in pci/rcar, thanks.
Lorenzo
^ permalink raw reply [flat|nested] 8+ messages in thread