* [PATCH v12 06/13] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU
2020-08-10 22:26 [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation Jordan Crouse
@ 2020-08-10 22:26 ` Jordan Crouse
2020-08-10 22:26 ` [PATCH v12 12/13] arm: dts: qcom: sm845: Set the compatible string for the " Jordan Crouse
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Jordan Crouse @ 2020-08-10 22:26 UTC (permalink / raw)
To: linux-arm-msm
Cc: Will Deacon, Robin Murphy, Bjorn Andersson, iommu, freedreno,
Sai Prakash Ranjan, Rob Herring, Joerg Roedel, Rob Herring,
devicetree, linux-arm-kernel, linux-kernel
Every Qcom Adreno GPU has an embedded SMMU for its own use. These
devices depend on unique features such as split pagetables,
different stall/halt requirements and other settings. Identify them
with a compatible string so that they can be identified in the
arm-smmu implementation specific code.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 503160a7b9a0..70996348c1d8 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -49,6 +49,10 @@ properties:
- enum:
- nvidia,tegra194-smmu
- const: nvidia,smmu-500
+ - description: Qcom Adreno GPUs implementing "arm,smmu-v2"
+ items:
+ - const: qcom,adreno-smmu
+ - const: qcom,smmu-v2
- items:
- const: arm,mmu-500
- const: arm,smmu-v2
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v12 12/13] arm: dts: qcom: sm845: Set the compatible string for the GPU SMMU
2020-08-10 22:26 [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation Jordan Crouse
2020-08-10 22:26 ` [PATCH v12 06/13] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU Jordan Crouse
@ 2020-08-10 22:26 ` Jordan Crouse
2020-08-13 13:19 ` [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation Will Deacon
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Jordan Crouse @ 2020-08-10 22:26 UTC (permalink / raw)
To: linux-arm-msm
Cc: Will Deacon, Robin Murphy, Bjorn Andersson, iommu, freedreno,
Sai Prakash Ranjan, Andy Gross, Rob Herring, devicetree,
linux-kernel
Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable
split pagetables and per-instance pagetables for drm/msm.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 2884577dcb77..6a9adaa401a9 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4058,7 +4058,7 @@ opp-257000000 {
};
adreno_smmu: iommu@5040000 {
- compatible = "qcom,sdm845-smmu-v2", "qcom,smmu-v2";
+ compatible = "qcom,adreno-smmu", "qcom,smmu-v2";
reg = <0 0x5040000 0 0x10000>;
#iommu-cells = <1>;
#global-interrupts = <2>;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation
2020-08-10 22:26 [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation Jordan Crouse
2020-08-10 22:26 ` [PATCH v12 06/13] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU Jordan Crouse
2020-08-10 22:26 ` [PATCH v12 12/13] arm: dts: qcom: sm845: Set the compatible string for the " Jordan Crouse
@ 2020-08-13 13:19 ` Will Deacon
2020-08-14 2:41 ` [PATCH 10/19] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU Rob Clark
2020-08-14 2:41 ` [PATCH 17/19] arm: dts: qcom: sm845: Set the compatible string for the " Rob Clark
4 siblings, 0 replies; 7+ messages in thread
From: Will Deacon @ 2020-08-13 13:19 UTC (permalink / raw)
To: Jordan Crouse
Cc: linux-arm-msm, Robin Murphy, Bjorn Andersson, iommu, freedreno,
Sai Prakash Ranjan, Akhil P Oommen, Andy Gross,
AngeloGioacchino Del Regno, Ben Dooks, Brian Masney,
Daniel Vetter, David Airlie, Douglas Anderson, Emil Velikov,
Eric Anholt, Greg Kroah-Hartman, Hanna Hawa, Joerg Roedel,
Jon Hunter, Jonathan Marek, Krishna Reddy, Nicolin Chen,
Pritesh Raithatha, Rob Clark, Rob Herring, Sam Ravnborg,
Sean Paul, Sharat Masetty, Shawn Guo, Sibi Sankar, Stephen Boyd,
Thierry Reding, Thierry Reding, Vivek Gautam, Wambui Karuga,
devicetree, dri-devel, linux-arm-kernel, linux-kernel
On Mon, Aug 10, 2020 at 04:26:44PM -0600, Jordan Crouse wrote:
> This series adds an Adreno SMMU implementation to arm-smmu to allow GPU hardware
> pagetable switching.
>
> The Adreno GPU has built in capabilities to switch the TTBR0 pagetable during
> runtime to allow each individual instance or application to have its own
> pagetable. In order to take advantage of the HW capabilities there are certain
> requirements needed of the SMMU hardware.
"capabilities" is a polite way of putting it ;)
Anyway, modulo two design comments, I think this is about as nice as we're
going to get this. Thanks for persevering, and sorry that you have to deal
with such dreadful hardware.
Hopefully the next version will be the one, although I'd like Robin to take
a quick look as well if he gets a chance.
Will
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 10/19] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU
2020-08-10 22:26 [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation Jordan Crouse
` (2 preceding siblings ...)
2020-08-13 13:19 ` [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation Will Deacon
@ 2020-08-14 2:41 ` Rob Clark
2020-09-01 5:00 ` Bjorn Andersson
2020-08-14 2:41 ` [PATCH 17/19] arm: dts: qcom: sm845: Set the compatible string for the " Rob Clark
4 siblings, 1 reply; 7+ messages in thread
From: Rob Clark @ 2020-08-14 2:41 UTC (permalink / raw)
To: dri-devel, iommu, linux-arm-msm
Cc: Sai Prakash Ranjan, Will Deacon, freedreno, Bjorn Andersson,
Sibi Sankar, Vivek Gautam, Stephen Boyd, Robin Murphy,
Joerg Roedel, linux-arm-kernel, Jordan Crouse, Rob Herring,
Rob Clark, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
From: Jordan Crouse <jcrouse@codeaurora.org>
Every Qcom Adreno GPU has an embedded SMMU for its own use. These
devices depend on unique features such as split pagetables,
different stall/halt requirements and other settings. Identify them
with a compatible string so that they can be identified in the
arm-smmu implementation specific code.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 503160a7b9a0..5ec5d0d691f6 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -40,6 +40,10 @@ properties:
- qcom,sm8150-smmu-500
- qcom,sm8250-smmu-500
- const: arm,mmu-500
+ - description: Qcom Adreno GPUs implementing "arm,smmu-v2"
+ items:
+ - const: qcom,adreno-smmu
+ - const: qcom,smmu-v2
- description: Marvell SoCs implementing "arm,mmu-500"
items:
- const: marvell,ap806-smmu-500
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 10/19] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU
2020-08-14 2:41 ` [PATCH 10/19] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU Rob Clark
@ 2020-09-01 5:00 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2020-09-01 5:00 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, iommu, linux-arm-msm, Sai Prakash Ranjan, Will Deacon,
freedreno, Sibi Sankar, Vivek Gautam, Stephen Boyd, Robin Murphy,
Joerg Roedel, linux-arm-kernel, Jordan Crouse, Rob Herring,
Rob Clark, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote:
> From: Jordan Crouse <jcrouse@codeaurora.org>
>
> Every Qcom Adreno GPU has an embedded SMMU for its own use. These
> devices depend on unique features such as split pagetables,
> different stall/halt requirements and other settings. Identify them
> with a compatible string so that they can be identified in the
> arm-smmu implementation specific code.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 503160a7b9a0..5ec5d0d691f6 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -40,6 +40,10 @@ properties:
> - qcom,sm8150-smmu-500
> - qcom,sm8250-smmu-500
> - const: arm,mmu-500
> + - description: Qcom Adreno GPUs implementing "arm,smmu-v2"
> + items:
> + - const: qcom,adreno-smmu
> + - const: qcom,smmu-v2
> - description: Marvell SoCs implementing "arm,mmu-500"
> items:
> - const: marvell,ap806-smmu-500
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 17/19] arm: dts: qcom: sm845: Set the compatible string for the GPU SMMU
2020-08-10 22:26 [PATCH v12 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation Jordan Crouse
` (3 preceding siblings ...)
2020-08-14 2:41 ` [PATCH 10/19] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU Rob Clark
@ 2020-08-14 2:41 ` Rob Clark
4 siblings, 0 replies; 7+ messages in thread
From: Rob Clark @ 2020-08-14 2:41 UTC (permalink / raw)
To: dri-devel, iommu, linux-arm-msm
Cc: Sai Prakash Ranjan, Will Deacon, freedreno, Bjorn Andersson,
Sibi Sankar, Vivek Gautam, Stephen Boyd, Robin Murphy,
Joerg Roedel, linux-arm-kernel, Jordan Crouse, Rob Clark,
Andy Gross, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
From: Jordan Crouse <jcrouse@codeaurora.org>
Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable
split pagetables and per-instance pagetables for drm/msm.
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 2884577dcb77..6a9adaa401a9 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4058,7 +4058,7 @@ opp-257000000 {
};
adreno_smmu: iommu@5040000 {
- compatible = "qcom,sdm845-smmu-v2", "qcom,smmu-v2";
+ compatible = "qcom,adreno-smmu", "qcom,smmu-v2";
reg = <0 0x5040000 0 0x10000>;
#iommu-cells = <1>;
#global-interrupts = <2>;
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread