From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, "Marek Vasut" <marex@denx.de>,
devicetree@vger.kernel.org, "Guido Günther" <agx@sigxcpu.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings
Date: Sun, 16 Aug 2020 08:39:33 +0200 [thread overview]
Message-ID: <20200816063933.GC1201814@ravnborg.org> (raw)
In-Reply-To: <20200813012910.13576-3-laurent.pinchart@ideasonboard.com>
On Thu, Aug 13, 2020 at 04:29:04AM +0300, Laurent Pinchart wrote:
> Additional compatible strings have been added in DT source for the
> i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings.
> Most of the upstream DT sources use the fsl,imx28-lcdif compatible
> string, which mostly predates the realization that the LCDIF in the
> i.MX6 and newer SoCs have extra features compared to the i.MX28.
>
> Update the bindings to add the missing compatible strings, with the
> correct fallback values. This fails to validate some of the upstream DT
> sources. Instead of adding the incorrect compatible fallback to the
> binding, the sources should be updated separately.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/mxsfb.yaml | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml b/Documentation/devicetree/bindings/display/mxsfb.yaml
> index 202381ec5bb7..ec6533b1d4a3 100644
> --- a/Documentation/devicetree/bindings/display/mxsfb.yaml
> +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml
> @@ -15,11 +15,19 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - fsl,imx23-lcdif
> - - fsl,imx28-lcdif
> - - fsl,imx6sx-lcdif
> - - fsl,imx8mq-lcdif
> + oneOf:
> + - enum:
> + - fsl,imx23-lcdif
> + - fsl,imx28-lcdif
> + - fsl,imx6sx-lcdif
Indent correct.
> + - items:
> + - enum:
> + - fsl,imx6sl-lcdif
> + - fsl,imx6sll-lcdif
> + - fsl,imx6ul-lcdif
> + - fsl,imx7d-lcdif
> + - fsl,imx8mq-lcdif
Indent shall be two more spaces like above.
(This is at least my best uderstanding)
> + - const: fsl,imx6sx-lcdif
With the above the following compatibles are supported:
"fsl,imx23-lcdif"
"fsl,imx28-lcdif"
"fsl,imx6sx-lcdif"
"fsl,imx8mq-lcdif"
"fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif"
"fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif"
"fsl,imx6ul-lcdif", "fsl,imx6sx-lcdif"
"fsl,imx7d-lcdif", "fsl,imx6sx-lcdif"
"fsl,imx8mq-lcdif", "fsl,imx6sx-lcdif"
So the fallback value is the later "fsl,imx6sx-lcdif" which looks ok.
With indent fixed (or explained why I am wrong):
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> reg:
> maxItems: 1
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-16 6:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 1:29 [PATCH 0/8] drm: mxsfb: Allow overriding bus width Laurent Pinchart
2020-08-13 1:29 ` [PATCH 1/8] dt-bindings: display: mxsfb: Convert binding to YAML Laurent Pinchart
2020-08-16 6:22 ` Sam Ravnborg
2020-08-17 0:00 ` Laurent Pinchart
2020-08-24 23:59 ` Rob Herring
2020-08-13 1:29 ` [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings Laurent Pinchart
2020-08-16 6:39 ` Sam Ravnborg [this message]
2020-08-17 0:04 ` Laurent Pinchart
2020-08-24 23:57 ` Rob Herring
2020-08-21 14:53 ` Stefan Agner
2020-08-23 23:26 ` Laurent Pinchart
2020-08-24 14:19 ` Stefan Agner
2020-10-07 1:12 ` Laurent Pinchart
2020-08-13 1:29 ` [PATCH 3/8] dt-bindings: display: mxsfb: Add a bus-width endpoint property Laurent Pinchart
2020-08-15 21:28 ` Guido Günther
2020-08-17 0:09 ` Laurent Pinchart
2020-08-16 7:25 ` Sam Ravnborg
2020-08-17 0:17 ` Laurent Pinchart
2020-08-13 1:29 ` [PATCH 4/8] dt-bindings: display: mxsfb: Rename to fsl,lcdif.yaml Laurent Pinchart
2020-08-16 7:27 ` Sam Ravnborg
2020-08-21 14:55 ` Stefan Agner
2020-08-23 23:27 ` Laurent Pinchart
2020-08-13 1:29 ` [PATCH 5/8] ARM: dts: imx: Fix LCDIF compatible strings Laurent Pinchart
2020-08-16 7:28 ` Sam Ravnborg
2020-08-13 1:29 ` [PATCH 6/8] arm64: dts: imx8mq: " Laurent Pinchart
2020-08-16 7:28 ` Sam Ravnborg
2020-08-13 1:29 ` [PATCH 7/8] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock Laurent Pinchart
2020-08-16 7:28 ` Sam Ravnborg
2020-08-13 1:29 ` [PATCH 8/8] drm: mxsfb: Add support for the bus-width DT property Laurent Pinchart
2020-08-16 7:46 ` Sam Ravnborg
2020-08-17 0:29 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816063933.GC1201814@ravnborg.org \
--to=sam@ravnborg.org \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).