devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, "Marek Vasut" <marex@denx.de>,
	devicetree@vger.kernel.org, "Guido Günther" <agx@sigxcpu.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/8] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock
Date: Sun, 16 Aug 2020 09:28:58 +0200	[thread overview]
Message-ID: <20200816072858.GH1201814@ravnborg.org> (raw)
In-Reply-To: <20200813012910.13576-8-laurent.pinchart@ideasonboard.com>

On Thu, Aug 13, 2020 at 04:29:09AM +0300, Laurent Pinchart wrote:
> The LCDIF disp_axi clock is not mandatory in the DT binding and not
> required by the driver. Remove it when it points to a dummy clock.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  arch/arm/boot/dts/imx6sl.dtsi  | 5 ++---
>  arch/arm/boot/dts/imx6sll.dtsi | 5 ++---
>  arch/arm/boot/dts/imx6ul.dtsi  | 5 ++---
>  3 files changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index deeb647ffc3f..a4d74216c9f4 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -773,9 +773,8 @@ lcdif: lcdif@20f8000 {
>  				reg = <0x020f8000 0x4000>;
>  				interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
> -					 <&clks IMX6SL_CLK_LCDIF_AXI>,
> -					 <&clks IMX6SL_CLK_DUMMY>;
> -				clock-names = "pix", "axi", "disp_axi";
> +					 <&clks IMX6SL_CLK_LCDIF_AXI>;
> +				clock-names = "pix", "axi";
>  				status = "disabled";
>  				power-domains = <&pd_disp>;
>  			};
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index c51072bb43ba..55775318559b 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -648,9 +648,8 @@ lcdif: lcd-controller@20f8000 {
>  				reg = <0x020f8000 0x4000>;
>  				interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>,
> -					 <&clks IMX6SLL_CLK_LCDIF_APB>,
> -					 <&clks IMX6SLL_CLK_DUMMY>;
> -				clock-names = "pix", "axi", "disp_axi";
> +					 <&clks IMX6SLL_CLK_LCDIF_APB>;
> +				clock-names = "pix", "axi";
>  				status = "disabled";
>  			};
>  
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index b16cce1680a9..35df39cc85a4 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -982,9 +982,8 @@ lcdif: lcdif@21c8000 {
>  				reg = <0x021c8000 0x4000>;
>  				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6UL_CLK_LCDIF_PIX>,
> -					 <&clks IMX6UL_CLK_LCDIF_APB>,
> -					 <&clks IMX6UL_CLK_DUMMY>;
> -				clock-names = "pix", "axi", "disp_axi";
> +					 <&clks IMX6UL_CLK_LCDIF_APB>;
> +				clock-names = "pix", "axi";
>  				status = "disabled";
>  			};
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-08-16  7:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13  1:29 [PATCH 0/8] drm: mxsfb: Allow overriding bus width Laurent Pinchart
2020-08-13  1:29 ` [PATCH 1/8] dt-bindings: display: mxsfb: Convert binding to YAML Laurent Pinchart
2020-08-16  6:22   ` Sam Ravnborg
2020-08-17  0:00     ` Laurent Pinchart
2020-08-24 23:59   ` Rob Herring
2020-08-13  1:29 ` [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings Laurent Pinchart
2020-08-16  6:39   ` Sam Ravnborg
2020-08-17  0:04     ` Laurent Pinchart
2020-08-24 23:57       ` Rob Herring
2020-08-21 14:53   ` Stefan Agner
2020-08-23 23:26     ` Laurent Pinchart
2020-08-24 14:19       ` Stefan Agner
2020-10-07  1:12         ` Laurent Pinchart
2020-08-13  1:29 ` [PATCH 3/8] dt-bindings: display: mxsfb: Add a bus-width endpoint property Laurent Pinchart
2020-08-15 21:28   ` Guido Günther
2020-08-17  0:09     ` Laurent Pinchart
2020-08-16  7:25   ` Sam Ravnborg
2020-08-17  0:17     ` Laurent Pinchart
2020-08-13  1:29 ` [PATCH 4/8] dt-bindings: display: mxsfb: Rename to fsl,lcdif.yaml Laurent Pinchart
2020-08-16  7:27   ` Sam Ravnborg
2020-08-21 14:55   ` Stefan Agner
2020-08-23 23:27     ` Laurent Pinchart
2020-08-13  1:29 ` [PATCH 5/8] ARM: dts: imx: Fix LCDIF compatible strings Laurent Pinchart
2020-08-16  7:28   ` Sam Ravnborg
2020-08-13  1:29 ` [PATCH 6/8] arm64: dts: imx8mq: " Laurent Pinchart
2020-08-16  7:28   ` Sam Ravnborg
2020-08-13  1:29 ` [PATCH 7/8] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock Laurent Pinchart
2020-08-16  7:28   ` Sam Ravnborg [this message]
2020-08-13  1:29 ` [PATCH 8/8] drm: mxsfb: Add support for the bus-width DT property Laurent Pinchart
2020-08-16  7:46   ` Sam Ravnborg
2020-08-17  0:29     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200816072858.GH1201814@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=agx@sigxcpu.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).