* [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups
@ 2020-09-10 16:12 Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 1/8] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski
` (8 more replies)
0 siblings, 9 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
Hi,
Changes since v2:
1. Fix dtschema ID after rename (patch 1/8).
2. Apply patch 9/9 (defconfig change).
Changes since v1:
1. Rename dtschema file and add additionalProperties:false, as Rob
suggested,
2. Add Marek's tested-by,
3. New patches: #4, #5, #6, #7 and #9.
Best regards,
Krzysztof
Krzysztof Kozlowski (8):
dt-bindings: net: nfc: s3fwrn5: Convert to dtschema
dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs
nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs
nfc: s3fwrn5: Remove unneeded 'ret' variable
nfc: s3fwrn5: Add missing CRYPTO_HASH dependency
nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified
MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove
Robert
arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433
TM2
CREDITS | 4 +
.../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 73 +++++++++++++++++++
MAINTAINERS | 5 +-
.../dts/exynos/exynos5433-tm2-common.dtsi | 4 +-
drivers/nfc/s3fwrn5/Kconfig | 1 +
drivers/nfc/s3fwrn5/firmware.c | 4 +-
drivers/nfc/s3fwrn5/firmware.h | 2 +-
drivers/nfc/s3fwrn5/i2c.c | 24 +++---
9 files changed, 101 insertions(+), 41 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt
create mode 100644 Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 1/8] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 2/8] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs Krzysztof Kozlowski
` (7 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema.
This is conversion only so it includes properties with invalid prefixes
(s3fwrn5,en-gpios) which should be addressed later.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
.../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 --------
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 61 +++++++++++++++++++
MAINTAINERS | 1 +
3 files changed, 62 insertions(+), 25 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt
create mode 100644 Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt
deleted file mode 100644
index f02f6fb7f81c..000000000000
--- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-* Samsung S3FWRN5 NCI NFC Controller
-
-Required properties:
-- compatible: Should be "samsung,s3fwrn5-i2c".
-- reg: address on the bus
-- interrupts: GPIO interrupt to which the chip is connected
-- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the chip
-- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and
- sleep/wakeup control
-
-Example:
-
-&hsi2c_4 {
- s3fwrn5@27 {
- compatible = "samsung,s3fwrn5-i2c";
-
- reg = <0x27>;
-
- interrupt-parent = <&gpa1>;
- interrupts = <3 0 0>;
-
- s3fwrn5,en-gpios = <&gpf1 4 0>;
- s3fwrn5,fw-gpios = <&gpj0 2 0>;
- };
-};
diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
new file mode 100644
index 000000000000..f43d31a2d94b
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/nfc/samsung,s3fwrn5.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung S3FWRN5 NCI NFC Controller
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+ - Krzysztof Opasiak <k.opasiak@samsung.com>
+
+properties:
+ compatible:
+ const: samsung,s3fwrn5-i2c
+
+ interrupts:
+ maxItems: 1
+
+ reg:
+ maxItems: 1
+
+ s3fwrn5,en-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used for enabling/disabling the chip
+
+ s3fwrn5,fw-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used to enter firmware mode and sleep/wakeup control
+
+additionalProperties: false
+
+required:
+ - compatible
+ - interrupts
+ - reg
+ - s3fwrn5,en-gpios
+ - s3fwrn5,fw-gpios
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ s3fwrn5@27 {
+ compatible = "samsung,s3fwrn5-i2c";
+ reg = <0x27>;
+
+ interrupt-parent = <&gpa1>;
+ interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
+
+ s3fwrn5,en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
+ s3fwrn5,fw-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index ac79fdbdf8d0..ec4f1d9cb3dc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15273,6 +15273,7 @@ M: Robert Baldyga <r.baldyga@samsung.com>
M: Krzysztof Opasiak <k.opasiak@samsung.com>
L: linux-nfc@lists.01.org (moderated for non-subscribers)
S: Supported
+F: Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
F: drivers/nfc/s3fwrn5
SAMSUNG S5C73M3 CAMERA DRIVER
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 2/8] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 1/8] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 3/8] " Krzysztof Kozlowski
` (6 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
The device tree property prefix describes the vendor, which in case of
S3FWRN5 chip is Samsung. Therefore the "s3fwrn5" prefix for "en-gpios"
and "fw-gpios" is not correct and should be deprecated. Introduce
properly named properties for these GPIOs and rename the fw-gpios" to
"wake-gpios" to better describe its purpose.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 24 ++++++++++++++-----
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
index f43d31a2d94b..cb0b8a560282 100644
--- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
@@ -14,30 +14,42 @@ properties:
compatible:
const: samsung,s3fwrn5-i2c
+ en-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used for enabling/disabling the chip
+
interrupts:
maxItems: 1
reg:
maxItems: 1
+ wake-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used to enter firmware mode and sleep/wakeup control
+
s3fwrn5,en-gpios:
maxItems: 1
+ deprecated: true
description:
- Output GPIO pin used for enabling/disabling the chip
+ Use en-gpios
s3fwrn5,fw-gpios:
maxItems: 1
+ deprecated: true
description:
- Output GPIO pin used to enter firmware mode and sleep/wakeup control
+ Use wake-gpios
additionalProperties: false
required:
- compatible
+ - en-gpios
- interrupts
- reg
- - s3fwrn5,en-gpios
- - s3fwrn5,fw-gpios
+ - wake-gpios
examples:
- |
@@ -55,7 +67,7 @@ examples:
interrupt-parent = <&gpa1>;
interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
- s3fwrn5,en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
- s3fwrn5,fw-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
+ en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 3/8] nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 1/8] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 2/8] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable Krzysztof Kozlowski
` (5 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
The device tree property prefix describes the vendor, which in case of
S3FWRN5 chip is Samsung. Therefore the "s3fwrn5" prefix for "en-gpios"
and "fw-gpios" is not correct and should be deprecated. Introduce
properly named properties for these GPIOs but still support deprecated
ones.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/nfc/s3fwrn5/i2c.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index b4eb926d220a..557279492503 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -200,13 +200,21 @@ static int s3fwrn5_i2c_parse_dt(struct i2c_client *client)
if (!np)
return -ENODEV;
- phy->gpio_en = of_get_named_gpio(np, "s3fwrn5,en-gpios", 0);
- if (!gpio_is_valid(phy->gpio_en))
- return -ENODEV;
+ phy->gpio_en = of_get_named_gpio(np, "en-gpios", 0);
+ if (!gpio_is_valid(phy->gpio_en)) {
+ /* Support also deprecated property */
+ phy->gpio_en = of_get_named_gpio(np, "s3fwrn5,en-gpios", 0);
+ if (!gpio_is_valid(phy->gpio_en))
+ return -ENODEV;
+ }
- phy->gpio_fw_wake = of_get_named_gpio(np, "s3fwrn5,fw-gpios", 0);
- if (!gpio_is_valid(phy->gpio_fw_wake))
- return -ENODEV;
+ phy->gpio_fw_wake = of_get_named_gpio(np, "wake-gpios", 0);
+ if (!gpio_is_valid(phy->gpio_fw_wake)) {
+ /* Support also deprecated property */
+ phy->gpio_fw_wake = of_get_named_gpio(np, "s3fwrn5,fw-gpios", 0);
+ if (!gpio_is_valid(phy->gpio_fw_wake))
+ return -ENODEV;
+ }
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
` (2 preceding siblings ...)
2020-09-10 16:12 ` [PATCH v3 3/8] " Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 5/8] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency Krzysztof Kozlowski
` (4 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
The local variable 'ret' can be removed:
drivers/nfc/s3fwrn5/i2c.c:167:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index 557279492503..dc995286be84 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -164,7 +164,6 @@ static int s3fwrn5_i2c_read(struct s3fwrn5_i2c_phy *phy)
static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
{
struct s3fwrn5_i2c_phy *phy = phy_id;
- int ret = 0;
if (!phy || !phy->ndev) {
WARN_ON_ONCE(1);
@@ -179,10 +178,9 @@ static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
switch (phy->mode) {
case S3FWRN5_MODE_NCI:
case S3FWRN5_MODE_FW:
- ret = s3fwrn5_i2c_read(phy);
+ s3fwrn5_i2c_read(phy);
break;
case S3FWRN5_MODE_COLD:
- ret = -EREMOTEIO;
break;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 5/8] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
` (3 preceding siblings ...)
2020-09-10 16:12 ` [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 6/8] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified Krzysztof Kozlowski
` (3 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
The driver uses crypto hash functions so it needs to select CRYPTO_HASH.
This fixes build errors:
arc-linux-ld: drivers/nfc/s3fwrn5/firmware.o: in function `s3fwrn5_fw_download':
firmware.c:(.text+0x152): undefined reference to `crypto_alloc_shash'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nfc/s3fwrn5/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nfc/s3fwrn5/Kconfig b/drivers/nfc/s3fwrn5/Kconfig
index af9d18690afe..3f8b6da58280 100644
--- a/drivers/nfc/s3fwrn5/Kconfig
+++ b/drivers/nfc/s3fwrn5/Kconfig
@@ -2,6 +2,7 @@
config NFC_S3FWRN5
tristate
select CRYPTO
+ select CRYPTO_HASH
help
Core driver for Samsung S3FWRN5 NFC chip. Contains core utilities
of chip. It's intended to be used by PHYs to avoid duplicating lots
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 6/8] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
` (4 preceding siblings ...)
2020-09-10 16:12 ` [PATCH v3 5/8] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 7/8] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert Krzysztof Kozlowski
` (2 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
Two functions accept pointer to struct s3fwrn5_fw_info but do not
modify the contents. Make them const so the code is a little bit safer.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nfc/s3fwrn5/firmware.c | 4 ++--
drivers/nfc/s3fwrn5/firmware.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index 69857f080704..ec930ee2c847 100644
--- a/drivers/nfc/s3fwrn5/firmware.c
+++ b/drivers/nfc/s3fwrn5/firmware.c
@@ -348,7 +348,7 @@ static int s3fwrn5_fw_get_base_addr(
}
static inline bool
-s3fwrn5_fw_is_custom(struct s3fwrn5_fw_cmd_get_bootinfo_rsp *bootinfo)
+s3fwrn5_fw_is_custom(const struct s3fwrn5_fw_cmd_get_bootinfo_rsp *bootinfo)
{
return !!bootinfo->hw_version[2];
}
@@ -399,7 +399,7 @@ int s3fwrn5_fw_setup(struct s3fwrn5_fw_info *fw_info)
return ret;
}
-bool s3fwrn5_fw_check_version(struct s3fwrn5_fw_info *fw_info, u32 version)
+bool s3fwrn5_fw_check_version(const struct s3fwrn5_fw_info *fw_info, u32 version)
{
struct s3fwrn5_fw_version *new = (void *) &fw_info->fw.version;
struct s3fwrn5_fw_version *old = (void *) &version;
diff --git a/drivers/nfc/s3fwrn5/firmware.h b/drivers/nfc/s3fwrn5/firmware.h
index cf1a83a5a525..3c83e6730d30 100644
--- a/drivers/nfc/s3fwrn5/firmware.h
+++ b/drivers/nfc/s3fwrn5/firmware.h
@@ -91,7 +91,7 @@ struct s3fwrn5_fw_info {
void s3fwrn5_fw_init(struct s3fwrn5_fw_info *fw_info, const char *fw_name);
int s3fwrn5_fw_setup(struct s3fwrn5_fw_info *fw_info);
-bool s3fwrn5_fw_check_version(struct s3fwrn5_fw_info *fw_info, u32 version);
+bool s3fwrn5_fw_check_version(const struct s3fwrn5_fw_info *fw_info, u32 version);
int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info);
void s3fwrn5_fw_cleanup(struct s3fwrn5_fw_info *fw_info);
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 7/8] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
` (5 preceding siblings ...)
2020-09-10 16:12 ` [PATCH v3 6/8] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 8/8] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2 Krzysztof Kozlowski
2020-09-10 22:22 ` [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups David Miller
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
Robert Bałdyga's email does not work (bounces) since 2016 so remove it.
Additionally there are no review/ack/tested tags from Krzysztof Opasiak
so it looks like the driver is not supported.
As a maintainer of Samsung ARM/ARM64 SoC, I can take care about this
driver and provide some review. However clearly driver is not in
supported mode as I do not work in Samsung anymore.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
CREDITS | 4 ++++
MAINTAINERS | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/CREDITS b/CREDITS
index 32ee70a7562e..1df63cdf71df 100644
--- a/CREDITS
+++ b/CREDITS
@@ -191,6 +191,10 @@ N: Krishna Balasubramanian
E: balasub@cis.ohio-state.edu
D: Wrote SYS V IPC (part of standard kernel since 0.99.10)
+B: Robert Baldyga
+E: r.baldyga@hackerion.com
+D: Samsung S3FWRN5 NCI NFC Controller
+
N: Chris Ball
E: chris@printf.net
D: Former maintainer of the MMC/SD/SDIO subsystem.
diff --git a/MAINTAINERS b/MAINTAINERS
index ec4f1d9cb3dc..6888bd851caf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15269,10 +15269,10 @@ F: drivers/media/platform/s3c-camif/
F: include/media/drv-intf/s3c_camif.h
SAMSUNG S3FWRN5 NFC DRIVER
-M: Robert Baldyga <r.baldyga@samsung.com>
+M: Krzysztof Kozlowski <krzk@kernel.org>
M: Krzysztof Opasiak <k.opasiak@samsung.com>
L: linux-nfc@lists.01.org (moderated for non-subscribers)
-S: Supported
+S: Maintained
F: Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
F: drivers/nfc/s3fwrn5
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 8/8] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
` (6 preceding siblings ...)
2020-09-10 16:12 ` [PATCH v3 7/8] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert Krzysztof Kozlowski
@ 2020-09-10 16:12 ` Krzysztof Kozlowski
2020-09-10 22:22 ` [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups David Miller
8 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-10 16:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Rob Herring,
Krzysztof Kozlowski, Krzysztof Opasiak, Kukjin Kim, linux-kernel,
netdev, devicetree, linux-nfc, linux-arm-kernel,
linux-samsung-soc
Since "s3fwrn5" is not a valid vendor prefix, use new GPIO properties
instead of the deprecated.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 250fc01de78d..24aab3ea3f52 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -795,8 +795,8 @@
reg = <0x27>;
interrupt-parent = <&gpa1>;
interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
- s3fwrn5,en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
- s3fwrn5,fw-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
+ en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
` (7 preceding siblings ...)
2020-09-10 16:12 ` [PATCH v3 8/8] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2 Krzysztof Kozlowski
@ 2020-09-10 22:22 ` David Miller
2020-09-11 6:08 ` Krzysztof Kozlowski
8 siblings, 1 reply; 11+ messages in thread
From: David Miller @ 2020-09-10 22:22 UTC (permalink / raw)
To: krzk
Cc: kuba, robh+dt, k.opasiak, kgene, linux-kernel, netdev,
devicetree, linux-nfc, linux-arm-kernel, linux-samsung-soc
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Thu, 10 Sep 2020 18:12:11 +0200
> Changes since v2:
> 1. Fix dtschema ID after rename (patch 1/8).
> 2. Apply patch 9/9 (defconfig change).
>
> Changes since v1:
> 1. Rename dtschema file and add additionalProperties:false, as Rob
> suggested,
> 2. Add Marek's tested-by,
> 3. New patches: #4, #5, #6, #7 and #9.
Seires applied to net-next, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups
2020-09-10 22:22 ` [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups David Miller
@ 2020-09-11 6:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-11 6:08 UTC (permalink / raw)
To: David Miller
Cc: kuba, robh+dt, k.opasiak, kgene, linux-kernel, netdev,
devicetree, linux-nfc, linux-arm-kernel, linux-samsung-soc
On Fri, 11 Sep 2020 at 00:22, David Miller <davem@davemloft.net> wrote:
>
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Date: Thu, 10 Sep 2020 18:12:11 +0200
>
> > Changes since v2:
> > 1. Fix dtschema ID after rename (patch 1/8).
> > 2. Apply patch 9/9 (defconfig change).
> >
> > Changes since v1:
> > 1. Rename dtschema file and add additionalProperties:false, as Rob
> > suggested,
> > 2. Add Marek's tested-by,
> > 3. New patches: #4, #5, #6, #7 and #9.
>
> Seires applied to net-next, thanks.
Thanks. The DTS should go separate - via samsung-soc/arm-soc tree.
However if it is too late, then no problem.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-09-11 6:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 1/8] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 2/8] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 3/8] " Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 5/8] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 6/8] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 7/8] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 8/8] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2 Krzysztof Kozlowski
2020-09-10 22:22 ` [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups David Miller
2020-09-11 6:08 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).