From: Rob Herring <robh@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Daniel Campello <campello@chromium.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Evan Green <evgreen@chromium.org>
Subject: Re: [PATCH] dt-bindings: iio: sx9310: Add various settings as DT properties
Date: Mon, 14 Sep 2020 15:00:47 -0600 [thread overview]
Message-ID: <20200914210047.GA232617@bogus> (raw)
In-Reply-To: <20200903221828.3657250-1-swboyd@chromium.org>
On Thu, Sep 03, 2020 at 03:18:28PM -0700, Stephen Boyd wrote:
> We need to set various bits in the hardware registers for this device to
> operate properly depending on how it is installed. Add a handful of DT
> properties to configure these things.
>
> Cc: Daniel Campello <campello@chromium.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: <devicetree@vger.kernel.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Gwendal Grignou <gwendal@chromium.org>
> Cc: Evan Green <evgreen@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>
> I haven't written any code to handle these properties yet. I'd rather do
> that once the binding patch is reviewed. Patch based on iio.git testing
> branch.
>
> .../iio/proximity/semtech,sx9310.yaml | 182 ++++++++++++++++++
> 1 file changed, 182 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
> index 5739074d3592..e74b81483c14 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
> @@ -40,6 +40,169 @@ properties:
> "#io-channel-cells":
> const: 1
>
> + semtech,cs0-ground:
> + description: Indicates the CS0 sensor is connected to ground.
> + type: boolean
> +
> + semtech,combined-sensors:
> + allOf:
> + - $ref: /schemas/types.yaml#definitions/uint32
> + - enum: [0, 1, 2, 3]
> + default: 0
> + description:
> + Which sensors are combined. 0 for CS3, 1 for CS0+CS1, 2 for CS1+CS2,
> + and 3 for all sensors.
> +
> + semtech,cs0-gain-factor:
> + allOf:
> + - $ref: /schemas/types.yaml#definitions/uint32
> + - enum: [1, 2, 4, 8]
> + default: 1
> + description:
> + Gain factor for CS0 (and combined if any) sensor.
> +
> + semtech,cs1-gain-factor:
> + allOf:
> + - $ref: /schemas/types.yaml#definitions/uint32
> + - enum: [1, 2, 4, 8]
Now that everyone is trained on 'allOf', you can drop it. json-schema
draft8 changed this behavior.
Rob
next prev parent reply other threads:[~2020-09-14 21:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 22:18 [PATCH] dt-bindings: iio: sx9310: Add various settings as DT properties Stephen Boyd
2020-09-06 14:02 ` Jonathan Cameron
2020-09-09 6:18 ` Stephen Boyd
2020-09-09 11:15 ` Jonathan Cameron
2020-09-23 23:25 ` Stephen Boyd
2020-09-24 7:57 ` Stephen Boyd
2020-09-25 12:47 ` Jonathan Cameron
2020-09-25 12:46 ` Jonathan Cameron
2020-09-26 1:17 ` Stephen Boyd
2020-09-26 15:50 ` Jonathan Cameron
2020-09-14 21:00 ` Rob Herring [this message]
2020-09-22 21:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914210047.GA232617@bogus \
--to=robh@kernel.org \
--cc=campello@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).