* [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute
[not found] <20200907073402.26674-1-narmstrong@baylibre.com>
@ 2020-09-07 7:34 ` Neil Armstrong
2020-09-08 19:48 ` [PATCH 1/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: " Rob Herring
2020-09-08 19:50 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: " Rob Herring
2020-09-07 7:34 ` [PATCH 2/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove phy cell parameter Neil Armstrong
1 sibling, 2 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-09-07 7:34 UTC (permalink / raw)
To: kishon, repk, devicetree
Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd
node like the axg-clkc node.
Thus the reg attribute is not needed.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
index 18c1ec5e19ad..a9040aa387cf 100644
--- a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
+++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
@@ -13,15 +13,11 @@ properties:
compatible:
const: amlogic,axg-mipi-pcie-analog-phy
- reg:
- maxItems: 1
-
"#phy-cells":
const: 1
required:
- compatible
- - reg
- "#phy-cells"
additionalProperties: false
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove phy cell parameter
[not found] <20200907073402.26674-1-narmstrong@baylibre.com>
2020-09-07 7:34 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute Neil Armstrong
@ 2020-09-07 7:34 ` Neil Armstrong
2020-09-15 15:29 ` [PATCH 2/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: " Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2020-09-07 7:34 UTC (permalink / raw)
To: kishon, repk, devicetree
Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
The Amlogic AXG MIPI + PCIe Analog PHY provides function for both PCIe and
MIPI DSI at the same time, and is not exclusive.
Thus remove the invalid phy cell parameter.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
index a9040aa387cf..148618b51b24 100644
--- a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
+++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
@@ -14,7 +14,7 @@ properties:
const: amlogic,axg-mipi-pcie-analog-phy
"#phy-cells":
- const: 1
+ const: 0
required:
- compatible
@@ -27,5 +27,5 @@ examples:
mpphy: phy@0 {
compatible = "amlogic,axg-mipi-pcie-analog-phy";
reg = <0x0 0xc>;
- #phy-cells = <1>;
+ #phy-cells = <0>;
};
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: remove reg attribute
2020-09-07 7:34 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute Neil Armstrong
@ 2020-09-08 19:48 ` Rob Herring
2020-09-08 19:50 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: " Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-09-08 19:48 UTC (permalink / raw)
To: Neil Armstrong
Cc: kishon, linux-amlogic, repk, devicetree, linux-arm-kernel, linux-kernel
On Mon, 07 Sep 2020 09:34:00 +0200, Neil Armstrong wrote:
> The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd
> node like the axg-clkc node.
>
> Thus the reg attribute is not needed.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.example.dt.yaml: phy@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
See https://patchwork.ozlabs.org/patch/1358643
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute
2020-09-07 7:34 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute Neil Armstrong
2020-09-08 19:48 ` [PATCH 1/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: " Rob Herring
@ 2020-09-08 19:50 ` Rob Herring
2020-09-09 7:31 ` Neil Armstrong
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2020-09-08 19:50 UTC (permalink / raw)
To: Neil Armstrong
Cc: kishon, repk, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel
On Mon, Sep 07, 2020 at 09:34:00AM +0200, Neil Armstrong wrote:
> The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd
> node like the axg-clkc node.
>
> Thus the reg attribute is not needed.
If the phy registers have an address then it should remain even if Linux
happens to not care. The exception is if the registers are all
interleaved with other stuff.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> index 18c1ec5e19ad..a9040aa387cf 100644
> --- a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> @@ -13,15 +13,11 @@ properties:
> compatible:
> const: amlogic,axg-mipi-pcie-analog-phy
>
> - reg:
> - maxItems: 1
> -
> "#phy-cells":
> const: 1
>
> required:
> - compatible
> - - reg
> - "#phy-cells"
>
> additionalProperties: false
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute
2020-09-08 19:50 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: " Rob Herring
@ 2020-09-09 7:31 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-09-09 7:31 UTC (permalink / raw)
To: Rob Herring
Cc: kishon, repk, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel
Hi,
On 08/09/2020 21:50, Rob Herring wrote:
> On Mon, Sep 07, 2020 at 09:34:00AM +0200, Neil Armstrong wrote:
>> The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd
>> node like the axg-clkc node.
>>
>> Thus the reg attribute is not needed.
>
> If the phy registers have an address then it should remain even if Linux
> happens to not care. The exception is if the registers are all
> interleaved with other stuff.
This is not really a question about linux using it or not.
The PHY registers happens to be at the beginning of a large zone containing
interleaved system registers (mainly clocks, power management, PHY control..).
The goal is to model it the same way as the other "features" of this zone,
like Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
and Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml
and have a coherent bindings scheme.
Neil
>
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
>> index 18c1ec5e19ad..a9040aa387cf 100644
>> --- a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
>> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
>> @@ -13,15 +13,11 @@ properties:
>> compatible:
>> const: amlogic,axg-mipi-pcie-analog-phy
>>
>> - reg:
>> - maxItems: 1
>> -
>> "#phy-cells":
>> const: 1
>>
>> required:
>> - compatible
>> - - reg
>> - "#phy-cells"
>>
>> additionalProperties: false
>> --
>> 2.22.0
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: remove phy cell parameter
2020-09-07 7:34 ` [PATCH 2/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove phy cell parameter Neil Armstrong
@ 2020-09-15 15:29 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-09-15 15:29 UTC (permalink / raw)
To: Neil Armstrong
Cc: kishon, linux-amlogic, linux-kernel, linux-arm-kernel, repk, devicetree
On Mon, 07 Sep 2020 09:34:01 +0200, Neil Armstrong wrote:
> The Amlogic AXG MIPI + PCIe Analog PHY provides function for both PCIe and
> MIPI DSI at the same time, and is not exclusive.
>
> Thus remove the invalid phy cell parameter.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-15 22:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200907073402.26674-1-narmstrong@baylibre.com>
2020-09-07 7:34 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute Neil Armstrong
2020-09-08 19:48 ` [PATCH 1/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: " Rob Herring
2020-09-08 19:50 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: " Rob Herring
2020-09-09 7:31 ` Neil Armstrong
2020-09-07 7:34 ` [PATCH 2/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove phy cell parameter Neil Armstrong
2020-09-15 15:29 ` [PATCH 2/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: " Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).