* [PATCH v5] dt-bindings: media: imx214: Convert to json-schema
@ 2020-09-10 16:20 Jacopo Mondi
2020-09-11 6:28 ` Ricardo Ribalda Delgado
2020-09-15 20:10 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Jacopo Mondi @ 2020-09-10 16:20 UTC (permalink / raw)
To: robh+dt, devicetree, linux-media, Ricardo Ribalda
Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
laurent.pinchart, linux-renesas-soc
Convert the imx214 bindings document to json-schema and update
the MAINTAINERS file accordingly.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
.../bindings/media/i2c/sony,imx214.txt | 53 -------
.../bindings/media/i2c/sony,imx214.yaml | 133 ++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 134 insertions(+), 54 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt b/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
deleted file mode 100644
index f11f28a5fda4..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor
-
-The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor with
-an active array size of 4224H x 3200V. It is programmable through an I2C
-interface.
-Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a maximum
-throughput of 1.2Gbps/lane.
-
-
-Required Properties:
-- compatible: Shall be "sony,imx214".
-- reg: I2C bus address of the device. Depending on how the sensor is wired,
- it shall be <0x10> or <0x1a>;
-- enable-gpios: GPIO descriptor for the enable pin.
-- vdddo-supply: Chip digital IO regulator (1.8V).
-- vdda-supply: Chip analog regulator (2.7V).
-- vddd-supply: Chip digital core regulator (1.12V).
-- clocks: Reference to the xclk clock.
-- clock-frequency: Frequency of the xclk clock.
-
-Optional Properties:
-- flash-leds: See ../video-interfaces.txt
-- lens-focus: See ../video-interfaces.txt
-
-The imx214 device node shall contain one 'port' child node with
-an 'endpoint' subnode. For further reading on port node refer to
-Documentation/devicetree/bindings/media/video-interfaces.txt.
-
-Required Properties on endpoint:
-- data-lanes: check ../video-interfaces.txt
-- link-frequencies: check ../video-interfaces.txt
-- remote-endpoint: check ../video-interfaces.txt
-
-Example:
-
- camera-sensor@1a {
- compatible = "sony,imx214";
- reg = <0x1a>;
- vdddo-supply = <&pm8994_lvs1>;
- vddd-supply = <&camera_vddd_1v12>;
- vdda-supply = <&pm8994_l17>;
- lens-focus = <&ad5820>;
- enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
- clocks = <&mmcc CAMSS_MCLK0_CLK>;
- clock-frequency = <24000000>;
- port {
- imx214_ep: endpoint {
- data-lanes = <1 2 3 4>;
- link-frequencies = /bits/ 64 <480000000>;
- remote-endpoint = <&csiphy0_ep>;
- };
- };
- };
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
new file mode 100644
index 000000000000..0f5e25fa4e9d
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
@@ -0,0 +1,133 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx214.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony 1/3.06-Inch 13.13MP CMOS Digital Image Sensor
+
+maintainers:
+ - Ricardo Ribalda <ribalda@kernel.org>
+
+description: |
+ The Sony IMX214 is a 1/3.06-inch CMOS active pixel digital image sensor with
+ an active array size of 4224H x 3200V. It is programmable through an I2C
+ interface. Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a
+ maximum throughput of 1.2Gbps/lane.
+
+properties:
+ compatible:
+ const: sony,imx214
+
+ reg:
+ enum:
+ - 0x10
+ - 0x1a
+
+ clocks:
+ description: Reference to the xclk clock.
+ maxItems: 1
+
+ clock-frequency:
+ description: Frequency of the xclk clock in Hz.
+
+ enable-gpios:
+ description: GPIO descriptor for the enable pin.
+ maxItems: 1
+
+ vdddo-supply:
+ description: Chip digital IO regulator (1.8V).
+ maxItems: 1
+
+ vdda-supply:
+ description: Chip analog regulator (2.7V).
+ maxItems: 1
+
+ vddd-supply:
+ description: Chip digital core regulator (1.12V).
+ maxItems: 1
+
+ flash-leds:
+ description: See ../video-interfaces.txt
+
+ lens-focus:
+ description: See ../video-interfaces.txt
+
+ port:
+ type: object
+ description: |
+ Video output port. See ../video-interfaces.txt.
+
+ properties:
+ endpoint:
+ type: object
+
+ properties:
+ data-lanes:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description: See ../video-interfaces.txt
+ anyOf:
+ - items:
+ - const: 1
+ - const: 2
+ - items:
+ - const: 1
+ - const: 2
+ - const: 3
+ - const: 4
+
+ link-frequencies:
+ $ref: /schemas/types.yaml#/definitions/uint64-array
+ description: See ../video-interfaces.txt
+
+ required:
+ - data-lanes
+ - link-frequencies
+
+ unevaluatedProperties: false
+
+ additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-frequency
+ - enable-gpios
+ - vdddo-supply
+ - vdda-supply
+ - vddd-supply
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera-sensor@1a {
+ compatible = "sony,imx214";
+ reg = <0x1a>;
+ vdddo-supply = <&pm8994_lvs1>;
+ vddd-supply = <&camera_vddd_1v12>;
+ vdda-supply = <&pm8994_l17>;
+ lens-focus = <&ad5820>;
+ enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
+ clocks = <&camera_clk>;
+ clock-frequency = <24000000>;
+
+ port {
+ imx214_ep: endpoint {
+ data-lanes = <1 2 3 4>;
+ link-frequencies = /bits/ 64 <480000000>;
+ remote-endpoint = <&csiphy0_ep>;
+ };
+ };
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 2c9393a7e1ba..cad34960d5ca 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16127,7 +16127,7 @@ M: Ricardo Ribalda <ribalda@kernel.org>
L: linux-media@vger.kernel.org
S: Maintained
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
+F: Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
F: drivers/media/i2c/imx214.c
SONY IMX219 SENSOR DRIVER
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v5] dt-bindings: media: imx214: Convert to json-schema
2020-09-10 16:20 [PATCH v5] dt-bindings: media: imx214: Convert to json-schema Jacopo Mondi
@ 2020-09-11 6:28 ` Ricardo Ribalda Delgado
2020-10-01 20:06 ` Sakari Ailus
2020-09-15 20:10 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Ricardo Ribalda Delgado @ 2020-09-11 6:28 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Rob Herring, devicetree, linux-media, Mauro Carvalho Chehab,
Sakari Ailus, Hans Verkuil, Laurent Pinchart, linux-renesas-soc
Thanks for the port
On Thu, Sep 10, 2020 at 6:17 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
>
> Convert the imx214 bindings document to json-schema and update
> the MAINTAINERS file accordingly.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: Ricardo Ribalda <ribalda@kernel.org>
> ---
> .../bindings/media/i2c/sony,imx214.txt | 53 -------
> .../bindings/media/i2c/sony,imx214.yaml | 133 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 134 insertions(+), 54 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt b/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> deleted file mode 100644
> index f11f28a5fda4..000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> +++ /dev/null
> @@ -1,53 +0,0 @@
> -* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor
> -
> -The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor with
> -an active array size of 4224H x 3200V. It is programmable through an I2C
> -interface.
> -Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a maximum
> -throughput of 1.2Gbps/lane.
> -
> -
> -Required Properties:
> -- compatible: Shall be "sony,imx214".
> -- reg: I2C bus address of the device. Depending on how the sensor is wired,
> - it shall be <0x10> or <0x1a>;
> -- enable-gpios: GPIO descriptor for the enable pin.
> -- vdddo-supply: Chip digital IO regulator (1.8V).
> -- vdda-supply: Chip analog regulator (2.7V).
> -- vddd-supply: Chip digital core regulator (1.12V).
> -- clocks: Reference to the xclk clock.
> -- clock-frequency: Frequency of the xclk clock.
> -
> -Optional Properties:
> -- flash-leds: See ../video-interfaces.txt
> -- lens-focus: See ../video-interfaces.txt
> -
> -The imx214 device node shall contain one 'port' child node with
> -an 'endpoint' subnode. For further reading on port node refer to
> -Documentation/devicetree/bindings/media/video-interfaces.txt.
> -
> -Required Properties on endpoint:
> -- data-lanes: check ../video-interfaces.txt
> -- link-frequencies: check ../video-interfaces.txt
> -- remote-endpoint: check ../video-interfaces.txt
> -
> -Example:
> -
> - camera-sensor@1a {
> - compatible = "sony,imx214";
> - reg = <0x1a>;
> - vdddo-supply = <&pm8994_lvs1>;
> - vddd-supply = <&camera_vddd_1v12>;
> - vdda-supply = <&pm8994_l17>;
> - lens-focus = <&ad5820>;
> - enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
> - clocks = <&mmcc CAMSS_MCLK0_CLK>;
> - clock-frequency = <24000000>;
> - port {
> - imx214_ep: endpoint {
> - data-lanes = <1 2 3 4>;
> - link-frequencies = /bits/ 64 <480000000>;
> - remote-endpoint = <&csiphy0_ep>;
> - };
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> new file mode 100644
> index 000000000000..0f5e25fa4e9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> @@ -0,0 +1,133 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx214.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony 1/3.06-Inch 13.13MP CMOS Digital Image Sensor
> +
> +maintainers:
> + - Ricardo Ribalda <ribalda@kernel.org>
> +
> +description: |
> + The Sony IMX214 is a 1/3.06-inch CMOS active pixel digital image sensor with
> + an active array size of 4224H x 3200V. It is programmable through an I2C
> + interface. Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a
> + maximum throughput of 1.2Gbps/lane.
> +
> +properties:
> + compatible:
> + const: sony,imx214
> +
> + reg:
> + enum:
> + - 0x10
> + - 0x1a
> +
> + clocks:
> + description: Reference to the xclk clock.
> + maxItems: 1
> +
> + clock-frequency:
> + description: Frequency of the xclk clock in Hz.
> +
> + enable-gpios:
> + description: GPIO descriptor for the enable pin.
> + maxItems: 1
> +
> + vdddo-supply:
> + description: Chip digital IO regulator (1.8V).
> + maxItems: 1
> +
> + vdda-supply:
> + description: Chip analog regulator (2.7V).
> + maxItems: 1
> +
> + vddd-supply:
> + description: Chip digital core regulator (1.12V).
> + maxItems: 1
> +
> + flash-leds:
> + description: See ../video-interfaces.txt
> +
> + lens-focus:
> + description: See ../video-interfaces.txt
> +
> + port:
> + type: object
> + description: |
> + Video output port. See ../video-interfaces.txt.
> +
> + properties:
> + endpoint:
> + type: object
> +
> + properties:
> + data-lanes:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description: See ../video-interfaces.txt
> + anyOf:
> + - items:
> + - const: 1
> + - const: 2
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> +
> + link-frequencies:
> + $ref: /schemas/types.yaml#/definitions/uint64-array
> + description: See ../video-interfaces.txt
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> + unevaluatedProperties: false
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-frequency
> + - enable-gpios
> + - vdddo-supply
> + - vdda-supply
> + - vddd-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera-sensor@1a {
> + compatible = "sony,imx214";
> + reg = <0x1a>;
> + vdddo-supply = <&pm8994_lvs1>;
> + vddd-supply = <&camera_vddd_1v12>;
> + vdda-supply = <&pm8994_l17>;
> + lens-focus = <&ad5820>;
> + enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
> + clocks = <&camera_clk>;
> + clock-frequency = <24000000>;
> +
> + port {
> + imx214_ep: endpoint {
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <480000000>;
> + remote-endpoint = <&csiphy0_ep>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2c9393a7e1ba..cad34960d5ca 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16127,7 +16127,7 @@ M: Ricardo Ribalda <ribalda@kernel.org>
> L: linux-media@vger.kernel.org
> S: Maintained
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> +F: Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> F: drivers/media/i2c/imx214.c
>
> SONY IMX219 SENSOR DRIVER
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] dt-bindings: media: imx214: Convert to json-schema
2020-09-10 16:20 [PATCH v5] dt-bindings: media: imx214: Convert to json-schema Jacopo Mondi
2020-09-11 6:28 ` Ricardo Ribalda Delgado
@ 2020-09-15 20:10 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-09-15 20:10 UTC (permalink / raw)
To: Jacopo Mondi
Cc: linux-renesas-soc, mchehab, robh+dt, devicetree, hverkuil-cisco,
laurent.pinchart, Ricardo Ribalda, sakari.ailus, linux-media
On Thu, 10 Sep 2020 18:20:30 +0200, Jacopo Mondi wrote:
> Convert the imx214 bindings document to json-schema and update
> the MAINTAINERS file accordingly.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> .../bindings/media/i2c/sony,imx214.txt | 53 -------
> .../bindings/media/i2c/sony,imx214.yaml | 133 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 134 insertions(+), 54 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] dt-bindings: media: imx214: Convert to json-schema
2020-09-11 6:28 ` Ricardo Ribalda Delgado
@ 2020-10-01 20:06 ` Sakari Ailus
0 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2020-10-01 20:06 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Jacopo Mondi, Rob Herring, devicetree, linux-media,
Mauro Carvalho Chehab, Sakari Ailus, Hans Verkuil,
Laurent Pinchart, linux-renesas-soc
Hi Ricardo,
On Fri, Sep 11, 2020 at 08:28:40AM +0200, Ricardo Ribalda Delgado wrote:
> Thanks for the port
>
>
> On Thu, Sep 10, 2020 at 6:17 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> >
> > Convert the imx214 bindings document to json-schema and update
> > the MAINTAINERS file accordingly.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Signed-off-by: Ricardo Ribalda <ribalda@kernel.org>
Sob or Acked-by?
--
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-01 20:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 16:20 [PATCH v5] dt-bindings: media: imx214: Convert to json-schema Jacopo Mondi
2020-09-11 6:28 ` Ricardo Ribalda Delgado
2020-10-01 20:06 ` Sakari Ailus
2020-09-15 20:10 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).