devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property
@ 2020-10-02 23:06 Rob Herring
  2020-10-05  8:08 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2020-10-02 23:06 UTC (permalink / raw)
  To: devicetree
  Cc: linux-kernel, Roger Quadros, Tero Kristo, Lee Jones,
	Kishon Vijay Abraham I

Pattern properties go under 'patternProperties', not 'properties'.
Otherwise, the pattern is treated as a literal string.

A corresponding meta-schema check has been added to catch bad DT property
names like this.

Fixes: e0f946915b23 ("dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller")
Cc: Roger Quadros <rogerq@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
index c8fd5d3e3071..da3d9ab758b9 100644
--- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
@@ -38,8 +38,8 @@ properties:
 
   ranges: true
 
-# Optional children
-
+patternProperties:
+  # Optional children
   "^serdes-ln-ctrl@[0-9a-f]+$":
     type: object
     description: |
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property
  2020-10-02 23:06 [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property Rob Herring
@ 2020-10-05  8:08 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-10-05  8:08 UTC (permalink / raw)
  To: Rob Herring
  Cc: devicetree, linux-kernel, Roger Quadros, Tero Kristo,
	Kishon Vijay Abraham I

On Fri, 02 Oct 2020, Rob Herring wrote:

> Pattern properties go under 'patternProperties', not 'properties'.
> Otherwise, the pattern is treated as a literal string.
> 
> A corresponding meta-schema check has been added to catch bad DT property
> names like this.
> 
> Fixes: e0f946915b23 ("dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller")
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml   | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-05  8:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 23:06 [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property Rob Herring
2020-10-05  8:08 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).