* [PATCH v2 0/1] Add macro definition for the upcoming new OST driver.
@ 2020-10-16 16:56 周琰杰 (Zhou Yanjie)
2020-10-16 16:56 ` [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie)
0 siblings, 1 reply; 4+ messages in thread
From: 周琰杰 (Zhou Yanjie) @ 2020-10-16 16:56 UTC (permalink / raw)
To: robh+dt; +Cc: linux-kernel, devicetree
Add new macro definition to "ingenic,sysost.h", exchange the original
ABI values of OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER, prepare
for the upcoming new OST driver.
I'm sure that exchanging the ABI values of OST_CLK_PERCPU_TIMER and
OST_CLK_GLOBAL_TIMER will not affect the existing related drivers and
the SoCs whitch using these drivers, so we should be able to exchange
them safely.
v1->v2:
Rewrite the commit message so that each line is less than 80 characters.
周琰杰 (Zhou Yanjie) (1):
dt-bindings: timer: Add new OST support for the upcoming new driver.
include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver.
2020-10-16 16:56 [PATCH v2 0/1] Add macro definition for the upcoming new OST driver 周琰杰 (Zhou Yanjie)
@ 2020-10-16 16:56 ` 周琰杰 (Zhou Yanjie)
2020-10-26 13:13 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: 周琰杰 (Zhou Yanjie) @ 2020-10-16 16:56 UTC (permalink / raw)
To: robh+dt; +Cc: linux-kernel, devicetree
The new OST has one global timer and two or four percpu timers, so there
will be three combinations in the upcoming new OST driver: the original
GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and
GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition
about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the
combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER
and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any
combinations, the clock can be registered (by calling clk_hw_register())
from index 0.
Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
---
Notes:
v1->v2:
Rewrite the commit message so that each line is less than 80 characters.
include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h
index 9ac88e90babf..063791b01ab3 100644
--- a/include/dt-bindings/clock/ingenic,sysost.h
+++ b/include/dt-bindings/clock/ingenic,sysost.h
@@ -1,12 +1,16 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
- * This header provides clock numbers for the ingenic,tcu DT binding.
+ * This header provides clock numbers for the Ingenic OST DT binding.
*/
#ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__
#define __DT_BINDINGS_CLOCK_INGENIC_OST_H__
-#define OST_CLK_PERCPU_TIMER 0
-#define OST_CLK_GLOBAL_TIMER 1
+#define OST_CLK_PERCPU_TIMER 1
+#define OST_CLK_GLOBAL_TIMER 0
+#define OST_CLK_PERCPU_TIMER0 1
+#define OST_CLK_PERCPU_TIMER1 2
+#define OST_CLK_PERCPU_TIMER2 3
+#define OST_CLK_PERCPU_TIMER3 4
#endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver.
2020-10-16 16:56 ` [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie)
@ 2020-10-26 13:13 ` Rob Herring
2020-10-26 14:36 ` Zhou Yanjie
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2020-10-26 13:13 UTC (permalink / raw)
To: 周琰杰 (Zhou Yanjie); +Cc: linux-kernel, devicetree
On Sat, Oct 17, 2020 at 12:56:02AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> The new OST has one global timer and two or four percpu timers, so there
> will be three combinations in the upcoming new OST driver: the original
> GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and
> GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition
> about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the
> combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER
> and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any
> combinations, the clock can be registered (by calling clk_hw_register())
> from index 0.
You need to state why breaking the ABI is okay.
>
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> ---
>
> Notes:
> v1->v2:
> Rewrite the commit message so that each line is less than 80 characters.
>
> include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h
> index 9ac88e90babf..063791b01ab3 100644
> --- a/include/dt-bindings/clock/ingenic,sysost.h
> +++ b/include/dt-bindings/clock/ingenic,sysost.h
> @@ -1,12 +1,16 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * This header provides clock numbers for the ingenic,tcu DT binding.
> + * This header provides clock numbers for the Ingenic OST DT binding.
> */
>
> #ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__
> #define __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>
> -#define OST_CLK_PERCPU_TIMER 0
> -#define OST_CLK_GLOBAL_TIMER 1
> +#define OST_CLK_PERCPU_TIMER 1
> +#define OST_CLK_GLOBAL_TIMER 0
> +#define OST_CLK_PERCPU_TIMER0 1
> +#define OST_CLK_PERCPU_TIMER1 2
> +#define OST_CLK_PERCPU_TIMER2 3
> +#define OST_CLK_PERCPU_TIMER3 4
>
> #endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver.
2020-10-26 13:13 ` Rob Herring
@ 2020-10-26 14:36 ` Zhou Yanjie
0 siblings, 0 replies; 4+ messages in thread
From: Zhou Yanjie @ 2020-10-26 14:36 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel, devicetree
Hi Rob,
在 2020/10/26 下午9:13, Rob Herring 写道:
> On Sat, Oct 17, 2020 at 12:56:02AM +0800, 周琰杰 (Zhou Yanjie) wrote:
>> The new OST has one global timer and two or four percpu timers, so there
>> will be three combinations in the upcoming new OST driver: the original
>> GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and
>> GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition
>> about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the
>> combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER
>> and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any
>> combinations, the clock can be registered (by calling clk_hw_register())
>> from index 0.
> You need to state why breaking the ABI is okay.
Sorry, I did not understand correctly before, I will add it to the
commit message in the next version.
Thanks and best regards!
>> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> ---
>>
>> Notes:
>> v1->v2:
>> Rewrite the commit message so that each line is less than 80 characters.
>>
>> include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h
>> index 9ac88e90babf..063791b01ab3 100644
>> --- a/include/dt-bindings/clock/ingenic,sysost.h
>> +++ b/include/dt-bindings/clock/ingenic,sysost.h
>> @@ -1,12 +1,16 @@
>> /* SPDX-License-Identifier: GPL-2.0 */
>> /*
>> - * This header provides clock numbers for the ingenic,tcu DT binding.
>> + * This header provides clock numbers for the Ingenic OST DT binding.
>> */
>>
>> #ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>> #define __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>>
>> -#define OST_CLK_PERCPU_TIMER 0
>> -#define OST_CLK_GLOBAL_TIMER 1
>> +#define OST_CLK_PERCPU_TIMER 1
>> +#define OST_CLK_GLOBAL_TIMER 0
>> +#define OST_CLK_PERCPU_TIMER0 1
>> +#define OST_CLK_PERCPU_TIMER1 2
>> +#define OST_CLK_PERCPU_TIMER2 3
>> +#define OST_CLK_PERCPU_TIMER3 4
>>
>> #endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */
>> --
>> 2.11.0
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-26 14:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 16:56 [PATCH v2 0/1] Add macro definition for the upcoming new OST driver 周琰杰 (Zhou Yanjie)
2020-10-16 16:56 ` [PATCH v2 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie)
2020-10-26 13:13 ` Rob Herring
2020-10-26 14:36 ` Zhou Yanjie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).