From: "Pali Rohár" <pali@kernel.org>
To: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Andre Heider" <a.heider@gmail.com>,
"Gérald Kerma" <gerald@gk2.net>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
Date: Mon, 19 Oct 2020 10:04:08 +0200 [thread overview]
Message-ID: <20201019080408.iv7vmj63cgt2i6vg@pali> (raw)
In-Reply-To: <20201006124455.16617-1-pali@kernel.org>
Hello! Gregory, I would like to remind you following patch.
Andre, if you have a time, could you test it too?
On Tuesday 06 October 2020 14:44:55 Pali Rohár wrote:
> LED2 is connected to MPP1_2 pin. It is working only on V7 boards.
> V5 boards have hw bug which cause that LED2 is non-working.
>
> So enable LED2 only for Espressobin V7 boards.
>
> Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to
> power supply. Therefore on Espressobin board only LED2 can be controlled
> directly from the host. LED1 is possible to control via WiFi card inserted
> in miniPCIe slot if driver for particular card supports it.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Tested-by: Gérald Kerma <gerald@gk2.net>
>
> ---
>
> Previous version of this patch was sent by Uwe in March 2018, but it did
> not work on any tested V5 board. Now we know it was due to V5 HW bug.
>
> https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@pengutronix.de/
> ---
> .../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 4 ++++
> .../boot/dts/marvell/armada-3720-espressobin-v7.dts | 4 ++++
> .../boot/dts/marvell/armada-3720-espressobin.dtsi | 13 +++++++++++++
> 3 files changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 4775a7eda481..75401eab4d42 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -39,3 +39,7 @@
> &sdhci0 {
> status = "okay";
> };
> +
> +&led2 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index c47a93978386..48a7f50fb427 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -34,3 +34,7 @@
> &switch0port3 {
> label = "wan";
> };
> +
> +&led2 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 8a1c678bea5f..daffe136c523 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -41,6 +41,19 @@
> 3300000 0x0>;
> enable-active-high;
> };
> +
> + led2: gpio-led2 {
> + /* led2 is working only on v7 board */
> + status = "disabled";
> +
> + compatible = "gpio-leds";
> +
> + led2 {
> + label = "led2";
> + gpios = <&gpionb 2 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> };
>
> /* J9 */
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-10-19 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 12:44 [PATCH] arm64: dts: marvell: espressobin: Add support for LED2 Pali Rohár
2020-10-19 8:04 ` Pali Rohár [this message]
2020-10-19 12:25 ` Andrew Lunn
2020-11-13 10:24 ` Pali Rohár
2020-10-21 15:01 ` Andre Heider
2020-10-21 16:15 ` Pali Rohár
2020-11-29 11:11 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019080408.iv7vmj63cgt2i6vg@pali \
--to=pali@kernel.org \
--cc=a.heider@gmail.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gerald@gk2.net \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).