devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs
Date: Fri, 30 Oct 2020 08:10:38 +0800	[thread overview]
Message-ID: <20201030001038.GU28755@dragon> (raw)
In-Reply-To: <20200925132503.30206-6-ioana.ciornei@nxp.com>

On Fri, Sep 25, 2020 at 04:24:59PM +0300, Ioana Ciornei wrote:
> Annotate the EMDIO1 node and describe the 4 10GBASER PHYs found on the
> LS2088ARDB board. Also, add phy-handles for DPMACs 1-4 to their
> associated PHY.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
>  .../boot/dts/freescale/fsl-ls2088a-rdb.dts    | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> index f6b4d75a258b..0d1935fcd201 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> @@ -22,3 +22,44 @@ chosen {
>  		stdout-path = "serial1:115200n8";
>  	};
>  };
> +
> +&dpmac1 {
> +	phy-handle = <&mdio1_phy1>;
> +};
> +
> +&dpmac2 {
> +	phy-handle = <&mdio1_phy2>;
> +};
> +
> +&dpmac3 {
> +	phy-handle = <&mdio1_phy3>;
> +};
> +
> +&dpmac4 {
> +	phy-handle = <&mdio1_phy4>;
> +};
> +
> +&emdio1 {
> +	status = "okay";
> +
> +	mdio1_phy1: emdio1_phy@1 {
> +		compatible = "ethernet-phy-id13e5.1002";
> +		reg = <0x10>;
> +		phy-connection-type = "10gbase-r";
> +	};

Please have a newline between nodes.

Shawn

> +	mdio1_phy2: emdio1_phy@2 {
> +		compatible = "ethernet-phy-id13e5.1002";
> +		reg = <0x11>;
> +		phy-connection-type = "10gbase-r";
> +	};
> +	mdio1_phy3: emdio1_phy@3 {
> +		compatible = "ethernet-phy-id13e5.1002";
> +		reg = <0x12>;
> +		phy-connection-type = "10gbase-r";
> +	};
> +	mdio1_phy4: emdio1_phy@4 {
> +		compatible = "ethernet-phy-id13e5.1002";
> +		reg = <0x13>;
> +		phy-connection-type = "10gbase-r";
> +	};
> +};
> -- 
> 2.25.1
> 

  reply	other threads:[~2020-10-30  0:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 13:24 [PATCH 0/9] arm64: dts: layerscape: update MAC nodes with PHY information Ioana Ciornei
2020-09-25 13:24 ` [PATCH 1/9] arm64: dts: ls1088a: add external MDIO device nodes Ioana Ciornei
2020-10-30  0:01   ` Shawn Guo
2020-10-30  9:26     ` Ioana Ciornei
2020-09-25 13:24 ` [PATCH 2/9] arm64: dts: ls1088ardb: add QSGMII PHY nodes Ioana Ciornei
2020-10-30  0:07   ` Shawn Guo
2020-10-30  9:32     ` Ioana Ciornei
2020-09-25 13:24 ` [PATCH 3/9] arm64: dts: ls1088ardb: add necessary DTS nodes for DPMAC2 Ioana Ciornei
2020-09-25 13:24 ` [PATCH 4/9] arm64: dts: ls208xa: add the external MDIO nodes Ioana Ciornei
2020-09-25 13:24 ` [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs Ioana Ciornei
2020-10-30  0:10   ` Shawn Guo [this message]
2020-10-30  9:40     ` Ioana Ciornei
2020-09-25 13:25 ` [PATCH 6/9] arm64: dts: ls2088ardb: add PHY nodes for the AQR405 PHYs Ioana Ciornei
2020-09-25 13:25 ` [PATCH 7/9] arm64: dts: ls208xa: add PCS MDIO and PCS PHY nodes Ioana Ciornei
2020-09-25 13:25 ` [PATCH 8/9] arm64: dts: lx2160a: " Ioana Ciornei
2020-09-25 13:25 ` [PATCH 9/9] arm64: dts: lx2160ardb: add nodes for the AQR107 PHYs Ioana Ciornei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030001038.GU28755@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).