From: Jonathan Cameron <jic23@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 16/29] dt-bindings:iio:dac:ti,dac082s085 yaml conversion
Date: Sat, 31 Oct 2020 18:11:55 +0000 [thread overview]
Message-ID: <20201031181155.08e0288d@archlinux> (raw)
In-Reply-To: <20201031165836.GA12341@wunner.de>
On Sat, 31 Oct 2020 17:58:36 +0100
Lukas Wunner <lukas@wunner.de> wrote:
> On Sat, Oct 31, 2020 at 01:40:57PM +0000, Jonathan Cameron wrote:
> > + spi-cpha: true
> > + spi-cpol:
> > + description:
> > + Should be either spi-cpha, or spi-cpol but not both.
>
> Do the YAML files follow RFC 2119 terminology? If so, this is a
> "must", not a "should". (As it was in the txt file.)
I'll fix that whilst applying if it is all we have outstanding.
This is an information comment only as the actual enforcement is
below.
>
>
> > +required:
> > + - compatible
> > + - reg
> > + - vref-supply
>
> This is missing "spi-cpha xor spi-cpol", not sure if it can be
> specified here using the xor YAML trick.
It has to be specified in a separate block as far as I can tell.
That is done further down the file. I've tested all the combinations
and xor is enforced.
+allOf:
+ - $ref: '#/definitions/cpolXORcpha'
+
+definitions:
+ cpolXORcpha:
+ not:
+ required: [spi-cpha, spi-cpol]
+ oneOf:
+ - required:
+ - spi-cpha
+ - required:
+ - spi-cpol
+
>
> Thanks,
>
> Lukas
next prev parent reply other threads:[~2020-10-31 18:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 13:40 [PATCH v2 00/29] dt-bindings:iio: Another set of yaml conversions Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 01/29] dt-bindings:iio:humidity:hdc100x Drop separate doc + add to trivial-devices Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 02/29] dt-bindings:iio:humidity:htu21 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 03/29] dt-bindings:iio:humidity:st,hts221 yaml conversion Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 04/29] dt-bindings:iio:humidity:dht11 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 05/29] dt-bindings:iio:pressure:ms5637 Drop separate doc + add to trivial-devices Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 06/29] dt-bindings:iio:pressure:murata,zpa2326 yaml conversion Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 07/29] dt-bindings:iio:pressure:meas,ms5611 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 08/29] dt-bindings:iio:pressure:hoperf,hp03 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 09/29] dt-bindings:iio:proximity:semtech,sx9500 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 10/29] dt-bindings:iio:proximity:st,vl53l0x " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 11/29] dt-bindings:iio:proximity:ams,as3935 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 12/29] dt-bindings:iio:dac:ti,dac5571 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 13/29] dt-bindings:iio:dac:ti,dac7311 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 14/29] dt-bindings:iio:dac:ti,dac7512 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 15/29] dt-bindings:iio:dac:ti,dac7612 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 16/29] dt-bindings:iio:dac:ti,dac082s085 " Jonathan Cameron
2020-10-31 16:58 ` Lukas Wunner
2020-10-31 18:11 ` Jonathan Cameron [this message]
2020-11-03 2:21 ` Rob Herring
2020-11-08 16:34 ` Jonathan Cameron
2021-03-14 19:07 ` Jonathan Cameron
2021-03-14 19:23 ` Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 17/29] dt-bindings:iio:dac:adi,ad7303 " Jonathan Cameron
2020-10-31 13:40 ` [PATCH v2 18/29] dt-bindings:iio:dac:maxim,ds4424 " Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 19/29] dt-bindings:iio:dac:fsl,vf610-dac " Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 20/29] dt-bindings:iio:dac:microchip,mcp4725 " Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 21/29] dt-bindings:iio:dac:maxim,max5821 " Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 22/29] dt-bindings:iio:dac:nxp,lpc1850-dac " Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 23/29] dt-bindings:iio:dac:adi,ad5758 " Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 24/29] dt-bindings:iio:temperature:melexis,mlx90614 " Jonathan Cameron
2020-11-02 9:12 ` Crt Mori
2020-11-02 17:39 ` Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 25/29] dt-bindings:iio:temperature:melexis,mlx90632 conversion to yaml Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 26/29] dt-bindings:iio:temperature:meas,tsys01 move to trivial-devices.yaml Jonathan Cameron
2020-11-01 15:25 ` Manivannan Sadhasivam
2020-10-31 13:41 ` [PATCH v2 27/29] dt-bindings:iio:temperature:maxim,max31856 yaml conversion Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 28/29] dt-bindings:iio:temperature:maxim_thermocouple.txt to maxim,max31855k.yaml Jonathan Cameron
2020-10-31 13:41 ` [PATCH v2 29/29] dt-bindings:iio:temperature:ti,tmp07 yaml conversion Jonathan Cameron
2020-11-16 20:17 ` [PATCH v2 00/29] dt-bindings:iio: Another set of yaml conversions Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031181155.08e0288d@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).