* [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet
@ 2020-11-01 7:26 Jernej Skrabec
2020-11-01 9:21 ` [linux-sunxi] " Code Kipper
2020-11-02 9:25 ` Maxime Ripard
0 siblings, 2 replies; 3+ messages in thread
From: Jernej Skrabec @ 2020-11-01 7:26 UTC (permalink / raw)
To: mripard, wens
Cc: robh+dt, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
ethernet node.
Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
index fceb298bfd53..29a081e72a9b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
@@ -27,7 +27,7 @@ reg_gmac_3v3: gmac-3v3 {
&emac {
pinctrl-names = "default";
pinctrl-0 = <&ext_rgmii_pins>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-handle = <&ext_rgmii_phy>;
phy-supply = <®_gmac_3v3>;
allwinner,rx-delay-ps = <200>;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet
2020-11-01 7:26 [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet Jernej Skrabec
@ 2020-11-01 9:21 ` Code Kipper
2020-11-02 9:25 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Code Kipper @ 2020-11-01 9:21 UTC (permalink / raw)
To: Jernej Škrabec
Cc: Maxime Ripard, Chen-Yu Tsai, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
On Sun, 1 Nov 2020 at 08:20, Jernej Skrabec <jernej.skrabec@siol.net> wrote:
>
> RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
> ethernet node.
>
> Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Hi Jernej,
Tested-by: Marcus Cooper <codekipper@gmail.com>
BR,
CK
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> index fceb298bfd53..29a081e72a9b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> @@ -27,7 +27,7 @@ reg_gmac_3v3: gmac-3v3 {
> &emac {
> pinctrl-names = "default";
> pinctrl-0 = <&ext_rgmii_pins>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> phy-handle = <&ext_rgmii_phy>;
> phy-supply = <®_gmac_3v3>;
> allwinner,rx-delay-ps = <200>;
> --
> 2.29.2
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201101072609.1681891-1-jernej.skrabec%40siol.net.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet
2020-11-01 7:26 [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet Jernej Skrabec
2020-11-01 9:21 ` [linux-sunxi] " Code Kipper
@ 2020-11-02 9:25 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2020-11-02 9:25 UTC (permalink / raw)
To: Jernej Skrabec
Cc: wens, robh+dt, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On Sun, Nov 01, 2020 at 08:26:09AM +0100, Jernej Skrabec wrote:
> RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
> ethernet node.
>
> Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Applied. It's not clear yet whether it's the best way forward (the PR
got rejected), so it might need some extra work in the future.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 7:26 [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet Jernej Skrabec
2020-11-01 9:21 ` [linux-sunxi] " Code Kipper
2020-11-02 9:25 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).