devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: allwinner: h6: PineH64 model B: Add wifi
@ 2020-10-30 17:25 Jernej Skrabec
  2020-10-31 21:12 ` [linux-sunxi] " Corentin Labbe
  2020-11-02 10:23 ` Maxime Ripard
  0 siblings, 2 replies; 3+ messages in thread
From: Jernej Skrabec @ 2020-10-30 17:25 UTC (permalink / raw)
  To: mripard, wens
  Cc: robh+dt, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

PineH64 model B contains RTL8723CS wifi+bt combo module.

Since bluetooth support is not yet squared away, only wifi is enabled
for now.

Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
Changes from v1:
- added Chen-Yu tag
- added vqmmc-supply

 .../dts/allwinner/sun50i-h6-pine-h64-model-b.dts  | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
index f4c8966a6497..7fea1e4e2d49 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
@@ -10,6 +10,12 @@ / {
 	compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6";
 
 	/delete-node/ reg_gmac_3v3;
+
+	wifi_pwrseq: wifi_pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */
+		post-power-on-delay-ms = <200>;
+	};
 };
 
 &hdmi_connector {
@@ -19,3 +25,12 @@ &hdmi_connector {
 &emac {
 	phy-supply = <&reg_aldo2>;
 };
+
+&mmc1 {
+	vmmc-supply = <&reg_cldo3>;
+	vqmmc-supply = <&reg_aldo1>;
+	mmc-pwrseq = <&wifi_pwrseq>;
+	bus-width = <4>;
+	non-removable;
+	status = "okay";
+};
-- 
2.29.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [linux-sunxi] [PATCH v2] arm64: dts: allwinner: h6: PineH64 model B: Add wifi
  2020-10-30 17:25 [PATCH v2] arm64: dts: allwinner: h6: PineH64 model B: Add wifi Jernej Skrabec
@ 2020-10-31 21:12 ` Corentin Labbe
  2020-11-02 10:23 ` Maxime Ripard
  1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2020-10-31 21:12 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: mripard, wens, robh+dt, devicetree, linux-arm-kernel,
	linux-kernel, linux-sunxi

On Fri, Oct 30, 2020 at 06:25:30PM +0100, Jernej Skrabec wrote:
> PineH64 model B contains RTL8723CS wifi+bt combo module.
> 
> Since bluetooth support is not yet squared away, only wifi is enabled
> for now.
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
> Changes from v1:
> - added Chen-Yu tag
> - added vqmmc-supply
> 
>  .../dts/allwinner/sun50i-h6-pine-h64-model-b.dts  | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
> index f4c8966a6497..7fea1e4e2d49 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts
> @@ -10,6 +10,12 @@ / {
>  	compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6";
>  
>  	/delete-node/ reg_gmac_3v3;
> +
> +	wifi_pwrseq: wifi_pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&r_pio 1 3 GPIO_ACTIVE_LOW>; /* PM3 */
> +		post-power-on-delay-ms = <200>;
> +	};
>  };
>  
>  &hdmi_connector {
> @@ -19,3 +25,12 @@ &hdmi_connector {
>  &emac {
>  	phy-supply = <&reg_aldo2>;
>  };
> +
> +&mmc1 {
> +	vmmc-supply = <&reg_cldo3>;
> +	vqmmc-supply = <&reg_aldo1>;
> +	mmc-pwrseq = <&wifi_pwrseq>;
> +	bus-width = <4>;
> +	non-removable;
> +	status = "okay";
> +};
> -- 

Hello

Tested-by: <clabbe.montjoie@gmail.com>
RTL8723CS driver probe and related iwlist commands works. (like listing availlable channels)
But connecting to a wireless network was not successfully tested yet. (I need to set a test network).

Regards

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: dts: allwinner: h6: PineH64 model B: Add wifi
  2020-10-30 17:25 [PATCH v2] arm64: dts: allwinner: h6: PineH64 model B: Add wifi Jernej Skrabec
  2020-10-31 21:12 ` [linux-sunxi] " Corentin Labbe
@ 2020-11-02 10:23 ` Maxime Ripard
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2020-11-02 10:23 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: wens, robh+dt, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

On Fri, Oct 30, 2020 at 06:25:30PM +0100, Jernej Skrabec wrote:
> PineH64 model B contains RTL8723CS wifi+bt combo module.
> 
> Since bluetooth support is not yet squared away, only wifi is enabled
> for now.
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Applied, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-02 10:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 17:25 [PATCH v2] arm64: dts: allwinner: h6: PineH64 model B: Add wifi Jernej Skrabec
2020-10-31 21:12 ` [linux-sunxi] " Corentin Labbe
2020-11-02 10:23 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).