* [PATCH 0/5] Add Ethernet interface description for Odroid boards
[not found] <CGME20201103124620eucas1p169f37e0bd1f30222cdc88de0675adf60@eucas1p1.samsung.com>
@ 2020-11-03 12:46 ` Łukasz Stelmach
[not found] ` <CGME20201103124620eucas1p14e76afe9fd53184f1a689b5a654e7e1e@eucas1p1.samsung.com>
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Łukasz Stelmach @ 2020-11-03 12:46 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, Krzysztof Kozlowski, Anand Moon,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski,
Łukasz Stelmach
Add devicetree description of Ethernet devices on Odroid boards. These
descriptions enable setting MAC addresses with a bootloader.
Łukasz Stelmach (5):
ARM: dts: exynos: Fix ethernet description for Odroid XU3
ARM: dts: exynos: Add Ethernet interface description for Odroid X3
Lite
ARM: dts: exynos: Add Ethernet interface description for Odroid XU
ARM: dts: exynos: Add Ethernet interface description for Odroid U3
ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2
arch/arm/boot/dts/exynos4412-odroidu3.dts | 12 ++++++++
arch/arm/boot/dts/exynos4412-odroidx.dts | 28 +++++++++++++++++++
arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 ++++++++++
.../boot/dts/exynos5422-odroidxu3-lite.dts | 22 +++++++++++++++
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++--
5 files changed, 83 insertions(+), 2 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3
[not found] ` <CGME20201103124620eucas1p14e76afe9fd53184f1a689b5a654e7e1e@eucas1p1.samsung.com>
@ 2020-11-03 12:46 ` Łukasz Stelmach
2020-11-03 16:36 ` Krzysztof Kozlowski
2020-11-03 16:36 ` Krzysztof Kozlowski
0 siblings, 2 replies; 14+ messages in thread
From: Łukasz Stelmach @ 2020-11-03 12:46 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, Krzysztof Kozlowski, Anand Moon,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski,
Łukasz Stelmach
Create ethernet alias and assign appropriate compatible properties.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index d0f6ac5fa79d..2a4153484664 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -15,6 +15,10 @@
/ {
model = "Hardkernel Odroid XU3";
compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
+
+ aliases {
+ ethernet = ðernet;
+ };
};
&i2c_0 {
@@ -76,13 +80,13 @@ &usbhost2 {
#size-cells = <0>;
hub@1 {
- compatible = "usb8087,0024";
+ compatible = "usb0424,9514";
reg = <1>;
#address-cells = <1>;
#size-cells = <0>;
ethernet: usbether@1 {
- compatible = "usb0c45,6310";
+ compatible = "usb0424,ec00";
reg = <1>;
local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
};
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X3 Lite
[not found] ` <CGME20201103124621eucas1p1e447d6d2eb3f29ecd657f0705f15960d@eucas1p1.samsung.com>
@ 2020-11-03 12:46 ` Łukasz Stelmach
2020-11-03 16:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Łukasz Stelmach @ 2020-11-03 12:46 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, Krzysztof Kozlowski, Anand Moon,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski,
Łukasz Stelmach
Add Ethernet interface description for Odroid X3 Lite.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
.../boot/dts/exynos5422-odroidxu3-lite.dts | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 98feecad5489..62c5928aa994 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -16,6 +16,10 @@
/ {
model = "Hardkernel Odroid XU3 Lite";
compatible = "hardkernel,odroid-xu3-lite", "samsung,exynos5800", "samsung,exynos5";
+
+ aliases {
+ ethernet = ðernet;
+ };
};
&arm_a7_pmu {
@@ -103,3 +107,21 @@ &pwm {
&usbdrd_dwc3_1 {
dr_mode = "peripheral";
};
+
+&usbhost2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub@1 {
+ compatible = "usb0424,9514";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet: usbether@1 {
+ compatible = "usb0424,ec00";
+ reg = <1>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+ };
+ };
+};
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU
[not found] ` <CGME20201103124621eucas1p23bae6351a79c0e271b68223a35dbd7f7@eucas1p2.samsung.com>
@ 2020-11-03 12:46 ` Łukasz Stelmach
2020-11-03 16:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Łukasz Stelmach @ 2020-11-03 12:46 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, Krzysztof Kozlowski, Anand Moon,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski,
Łukasz Stelmach
Add Ethernet interface description for Odroid XU.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 75b4150c26d7..882d9296fa5d 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -19,6 +19,10 @@ / {
model = "Hardkernel Odroid XU";
compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
+ aliases {
+ ethernet = ðernet;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x7ea00000>;
@@ -653,3 +657,14 @@ &usbdrd3_1 {
vdd33-supply = <&ldo12_reg>;
vdd10-supply = <&ldo15_reg>;
};
+
+&usbhost2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet: usbether@2 {
+ compatible = "usb0424,9730";
+ reg = <2>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+ };
+};
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/5] ARM: dts: exynos: Add Ethernet interface description for Odroid U3
[not found] ` <CGME20201103124621eucas1p1a65f4d88466206a9646e139eaac3e1ed@eucas1p1.samsung.com>
@ 2020-11-03 12:46 ` Łukasz Stelmach
0 siblings, 0 replies; 14+ messages in thread
From: Łukasz Stelmach @ 2020-11-03 12:46 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, Krzysztof Kozlowski, Anand Moon,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski,
Łukasz Stelmach
Add Ethernet interface description for Odroid U3.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
arch/arm/boot/dts/exynos4412-odroidu3.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index b8549d846f86..b503f04db923 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -16,6 +16,10 @@ / {
model = "Hardkernel ODROID-U3 board based on Exynos4412";
compatible = "hardkernel,odroid-u3", "samsung,exynos4412", "samsung,exynos4";
+ aliases {
+ ethernet = ðernet;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x7FF00000>;
@@ -101,8 +105,16 @@ &usb3503 {
};
&ehci {
+ #address-cells = <1>;
+ #size-cells = <0>;
phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>;
phy-names = "hsic0", "hsic1";
+
+ ethernet: usbether@2 {
+ compatible = "usb0424,9730";
+ reg = <2>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+ };
};
&sound {
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2
[not found] ` <CGME20201103124622eucas1p25be1feaf9194a0e6b183d041a574b406@eucas1p2.samsung.com>
@ 2020-11-03 12:46 ` Łukasz Stelmach
2020-11-03 16:44 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Łukasz Stelmach @ 2020-11-03 12:46 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, Krzysztof Kozlowski, Anand Moon,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski,
Łukasz Stelmach
Add Ethernet interface description for Odroid X/X2.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 3ea2a0101e80..8f154f431f6c 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -15,6 +15,10 @@ / {
model = "Hardkernel ODROID-X board based on Exynos4412";
compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
+ aliases {
+ ethernet = ðernet;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x3FF00000>;
@@ -72,8 +76,32 @@ &buck8_reg {
};
&ehci {
+ #address-cells = <1>;
+ #size-cells = <0>;
phys = <&exynos_usbphy 2>;
phy-names = "hsic0";
+
+ hub@2 {
+ compatible = "usb0424,3503";
+ reg = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub@1 {
+ compatible = "usb0424:9514";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet: usbether@1 {
+ compatible = "usb0424,ec00";
+ reg = <1>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+ };
+ };
+ };
+
+
};
&mshc_0 {
--
2.26.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3
2020-11-03 12:46 ` [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3 Łukasz Stelmach
@ 2020-11-03 16:36 ` Krzysztof Kozlowski
[not found] ` <CGME20201103174153eucas1p1bde36909139c5662249eb5a1586504d7@eucas1p1.samsung.com>
2020-11-03 16:36 ` Krzysztof Kozlowski
1 sibling, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-03 16:36 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote:
> Create ethernet alias
Your commit msg should explain why.
> and assign appropriate compatible properties.
Then what was before? Indeed they do not look like anything
reasonable... old VID do not appear on any of Odroid boards.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
Best regards,
Krzysztof
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index d0f6ac5fa79d..2a4153484664 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -15,6 +15,10 @@
> / {
> model = "Hardkernel Odroid XU3";
> compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
> +
> + aliases {
> + ethernet = ðernet;
> + };
> };
>
> &i2c_0 {
> @@ -76,13 +80,13 @@ &usbhost2 {
> #size-cells = <0>;
>
> hub@1 {
> - compatible = "usb8087,0024";
> + compatible = "usb0424,9514";
> reg = <1>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> ethernet: usbether@1 {
> - compatible = "usb0c45,6310";
> + compatible = "usb0424,ec00";
> reg = <1>;
> local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
> };
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3
2020-11-03 12:46 ` [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3 Łukasz Stelmach
2020-11-03 16:36 ` Krzysztof Kozlowski
@ 2020-11-03 16:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-03 16:36 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote:
> Create ethernet alias and assign appropriate compatible properties.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index d0f6ac5fa79d..2a4153484664 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -15,6 +15,10 @@
> / {
> model = "Hardkernel Odroid XU3";
> compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
> +
> + aliases {
> + ethernet = ðernet;
Ahh, and one more thing - these are two separate issues to fix, so two
patches.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X3 Lite
2020-11-03 12:46 ` [PATCH 2/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X3 Lite Łukasz Stelmach
@ 2020-11-03 16:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-03 16:38 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
On Tue, Nov 03, 2020 at 01:46:15PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid X3 Lite.
Odroid XU3 Lite.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU
2020-11-03 12:46 ` [PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU Łukasz Stelmach
@ 2020-11-03 16:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-03 16:40 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
On Tue, Nov 03, 2020 at 01:46:16PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid XU.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index 75b4150c26d7..882d9296fa5d 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -19,6 +19,10 @@ / {
> model = "Hardkernel Odroid XU";
> compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
>
> + aliases {
> + ethernet = ðernet;
Just like with patch 1/5 - please explain in commit msg why do you need
this.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2
2020-11-03 12:46 ` [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2 Łukasz Stelmach
@ 2020-11-03 16:44 ` Krzysztof Kozlowski
[not found] ` <CGME20201103171326eucas1p25d2ea836878fb2e4f56f31c166243c40@eucas1p2.samsung.com>
0 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-03 16:44 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid X/X2.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> index 3ea2a0101e80..8f154f431f6c 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> @@ -15,6 +15,10 @@ / {
> model = "Hardkernel ODROID-X board based on Exynos4412";
> compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>
> + aliases {
> + ethernet = ðernet;
> + };
> +
> memory@40000000 {
> device_type = "memory";
> reg = <0x40000000 0x3FF00000>;
> @@ -72,8 +76,32 @@ &buck8_reg {
> };
>
> &ehci {
> + #address-cells = <1>;
> + #size-cells = <0>;
> phys = <&exynos_usbphy 2>;
> phy-names = "hsic0";
> +
> + hub@2 {
> + compatible = "usb0424,3503";
> + reg = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hub@1 {
> + compatible = "usb0424:9514";
Does not look like correct compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2
[not found] ` <CGME20201103171326eucas1p25d2ea836878fb2e4f56f31c166243c40@eucas1p2.samsung.com>
@ 2020-11-03 17:12 ` Lukasz Stelmach
2020-11-03 17:22 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Lukasz Stelmach @ 2020-11-03 17:12 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]
It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
>> Add Ethernet interface description for Odroid X/X2.
>>
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> index 3ea2a0101e80..8f154f431f6c 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
>> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> @@ -15,6 +15,10 @@ / {
>> model = "Hardkernel ODROID-X board based on Exynos4412";
>> compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>>
>> + aliases {
>> + ethernet = ðernet;
>> + };
>> +
>> memory@40000000 {
>> device_type = "memory";
>> reg = <0x40000000 0x3FF00000>;
>> @@ -72,8 +76,32 @@ &buck8_reg {
>> };
>>
>> &ehci {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> phys = <&exynos_usbphy 2>;
>> phy-names = "hsic0";
>> +
>> + hub@2 {
>> + compatible = "usb0424,3503";
>> + reg = <2>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + hub@1 {
>> + compatible = "usb0424:9514";
>
> Does not look like correct compatible.
As odd as it may seem (and considering my mistakes) this is correct.
--8<---------------cut here---------------start------------->8---
root@target:~# cat /proc/device-tree/compatible ; echo
hardkernel,odroid-x2samsung,exynos4412samsung,exynos4
root@target:~# lsusb -t
/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=exynos-ehci/3p, 480M
|__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/3p, 480M
|__ Port 1: Dev 3, If 0, Class=Hub, Driver=hub/5p, 480M
|__ Port 1: Dev 4, If 0, Class=Vendor Specific Class, Driver=smsc95xx, 480M
root@target:~# lsusb
Bus 001 Device 004: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 003: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
--8<---------------cut here---------------end--------------->8---
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2
2020-11-03 17:12 ` Lukasz Stelmach
@ 2020-11-03 17:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-03 17:22 UTC (permalink / raw)
To: Lukasz Stelmach
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
On Tue, 3 Nov 2020 at 18:13, Lukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> > On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> >> Add Ethernet interface description for Odroid X/X2.
> >>
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> >> ---
> >> arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> index 3ea2a0101e80..8f154f431f6c 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> @@ -15,6 +15,10 @@ / {
> >> model = "Hardkernel ODROID-X board based on Exynos4412";
> >> compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
> >>
> >> + aliases {
> >> + ethernet = ðernet;
> >> + };
> >> +
> >> memory@40000000 {
> >> device_type = "memory";
> >> reg = <0x40000000 0x3FF00000>;
> >> @@ -72,8 +76,32 @@ &buck8_reg {
> >> };
> >>
> >> &ehci {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> phys = <&exynos_usbphy 2>;
> >> phy-names = "hsic0";
> >> +
> >> + hub@2 {
> >> + compatible = "usb0424,3503";
> >> + reg = <2>;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + hub@1 {
> >> + compatible = "usb0424:9514";
> >
> > Does not look like correct compatible.
>
> As odd as it may seem (and considering my mistakes) this is correct.
Not the numbers, the format. Comma is needed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3
[not found] ` <CGME20201103174153eucas1p1bde36909139c5662249eb5a1586504d7@eucas1p1.samsung.com>
@ 2020-11-03 17:41 ` Lukasz Stelmach
0 siblings, 0 replies; 14+ messages in thread
From: Lukasz Stelmach @ 2020-11-03 17:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Kukjin Kim, Anand Moon, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel,
Bartłomiej Żolnierkiewicz, Marek Szyprowski
[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]
It was <2020-11-03 wto 17:36>, when Krzysztof Kozlowski wrote:
> On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote:
>> Create ethernet alias
>
> Your commit msg should explain why.
>
OK. (And a separate patch - ack)
>> and assign appropriate compatible properties.
>
> Then what was before? Indeed they do not look like anything
> reasonable... old VID do not appear on any of Odroid boards.
>
The first is acutally an Intel hub, the second is a webcam. Where did
I found them? I can't be sure today.
In case of USB devices the kernel uses topology information to match
devices instead of compatible properties and u-boot uses
aliases. Therefore, bad IDs don't break anything.
>>
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
>
> Best regards,
> Krzysztof
>
>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index d0f6ac5fa79d..2a4153484664 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -15,6 +15,10 @@
>> / {
>> model = "Hardkernel Odroid XU3";
>> compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
>> +
>> + aliases {
>> + ethernet = ðernet;
>> + };
>> };
>>
>> &i2c_0 {
>> @@ -76,13 +80,13 @@ &usbhost2 {
>> #size-cells = <0>;
>>
>> hub@1 {
>> - compatible = "usb8087,0024";
>> + compatible = "usb0424,9514";
>> reg = <1>;
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> ethernet: usbether@1 {
>> - compatible = "usb0c45,6310";
>> + compatible = "usb0424,ec00";
>> reg = <1>;
>> local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
>> };
>> --
>> 2.26.2
>>
>
>
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-11-03 17:42 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20201103124620eucas1p169f37e0bd1f30222cdc88de0675adf60@eucas1p1.samsung.com>
2020-11-03 12:46 ` [PATCH 0/5] Add Ethernet interface description for Odroid boards Łukasz Stelmach
[not found] ` <CGME20201103124620eucas1p14e76afe9fd53184f1a689b5a654e7e1e@eucas1p1.samsung.com>
2020-11-03 12:46 ` [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3 Łukasz Stelmach
2020-11-03 16:36 ` Krzysztof Kozlowski
[not found] ` <CGME20201103174153eucas1p1bde36909139c5662249eb5a1586504d7@eucas1p1.samsung.com>
2020-11-03 17:41 ` Lukasz Stelmach
2020-11-03 16:36 ` Krzysztof Kozlowski
[not found] ` <CGME20201103124621eucas1p1e447d6d2eb3f29ecd657f0705f15960d@eucas1p1.samsung.com>
2020-11-03 12:46 ` [PATCH 2/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X3 Lite Łukasz Stelmach
2020-11-03 16:38 ` Krzysztof Kozlowski
[not found] ` <CGME20201103124621eucas1p23bae6351a79c0e271b68223a35dbd7f7@eucas1p2.samsung.com>
2020-11-03 12:46 ` [PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU Łukasz Stelmach
2020-11-03 16:40 ` Krzysztof Kozlowski
[not found] ` <CGME20201103124621eucas1p1a65f4d88466206a9646e139eaac3e1ed@eucas1p1.samsung.com>
2020-11-03 12:46 ` [PATCH 4/5] ARM: dts: exynos: Add Ethernet interface description for Odroid U3 Łukasz Stelmach
[not found] ` <CGME20201103124622eucas1p25be1feaf9194a0e6b183d041a574b406@eucas1p2.samsung.com>
2020-11-03 12:46 ` [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2 Łukasz Stelmach
2020-11-03 16:44 ` Krzysztof Kozlowski
[not found] ` <CGME20201103171326eucas1p25d2ea836878fb2e4f56f31c166243c40@eucas1p2.samsung.com>
2020-11-03 17:12 ` Lukasz Stelmach
2020-11-03 17:22 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).