* [PATCH v2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml
@ 2020-12-04 2:24 Dmitry Baryshkov
2020-12-07 16:43 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2020-12-04 2:24 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring; +Cc: linux-arm-msm, devicetree
Convert soc/qcom/qcom,smem.txt bindings to YAML format.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/soc/qcom/qcom,smem.txt | 57 ---------------
.../bindings/soc/qcom/qcom,smem.yaml | 73 +++++++++++++++++++
2 files changed, 73 insertions(+), 57 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
deleted file mode 100644
index 9326cdf6e1b1..000000000000
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
+++ /dev/null
@@ -1,57 +0,0 @@
-Qualcomm Shared Memory Manager binding
-
-This binding describes the Qualcomm Shared Memory Manager, used to share data
-between various subsystems and OSes in Qualcomm platforms.
-
-- compatible:
- Usage: required
- Value type: <stringlist>
- Definition: must be:
- "qcom,smem"
-
-- memory-region:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: handle to memory reservation for main SMEM memory region.
-
-- qcom,rpm-msg-ram:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: handle to RPM message memory resource
-
-- hwlocks:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: reference to a hwspinlock used to protect allocations from
- the shared memory
-
-= EXAMPLE
-The following example shows the SMEM setup for MSM8974, with a main SMEM region
-at 0xfa00000 and the RPM message ram at 0xfc428000:
-
- reserved-memory {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- smem_region: smem@fa00000 {
- reg = <0xfa00000 0x200000>;
- no-map;
- };
- };
-
- smem@fa00000 {
- compatible = "qcom,smem";
-
- memory-region = <&smem_region>;
- qcom,rpm-msg-ram = <&rpm_msg_ram>;
-
- hwlocks = <&tcsr_mutex 3>;
- };
-
- soc {
- rpm_msg_ram: memory@fc428000 {
- compatible = "qcom,rpm-msg-ram";
- reg = <0xfc428000 0x4000>;
- };
- };
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
new file mode 100644
index 000000000000..867640c09932
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,smem.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Shared Memory Manager binding
+
+maintainers:
+ - Andy Gross <agross@kernel.org>
+ - Bjorn Andersson <bjorn.andersson@linaro.org>
+
+description: |
+ This binding describes the Qualcomm Shared Memory Manager, used to share data
+ between various subsystems and OSes in Qualcomm platforms.
+
+properties:
+ compatible:
+ const: "qcom-smem"
+
+ memory-region:
+ maxItems: 1
+ description: handle to memory reservation for main SMEM memory region.
+
+ hwlocks:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: reference to a hwspinlock used to protect allocations from the shared memory
+
+ qcom,rpm-msg-ram:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: handle to RPM message memory resource
+
+required:
+ - compatible
+ - memory-region
+ - hwlocks
+
+additionalProperties: false
+
+examples:
+ - |
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ smem_region: smem@fa00000 {
+ reg = <0xfa00000 0x200000>;
+ no-map;
+ };
+ };
+
+ smem {
+ compatible = "qcom,smem";
+
+ memory-region = <&smem_region>;
+ qcom,rpm-msg-ram = <&rpm_msg_ram>;
+
+ hwlocks = <&tcsr_mutex 3>;
+ };
+
+ soc {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ rpm_msg_ram: memory@fc428000 {
+ compatible = "qcom,rpm-msg-ram";
+ reg = <0xfc428000 0x4000>;
+ };
+ };
+
+...
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml
2020-12-04 2:24 [PATCH v2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Dmitry Baryshkov
@ 2020-12-07 16:43 ` Rob Herring
2020-12-10 11:38 ` Dmitry Baryshkov
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2020-12-07 16:43 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, linux-arm-msm, devicetree, Rob Herring, Bjorn Andersson
On Fri, 04 Dec 2020 05:24:01 +0300, Dmitry Baryshkov wrote:
> Convert soc/qcom/qcom,smem.txt bindings to YAML format.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/soc/qcom/qcom,smem.txt | 57 ---------------
> .../bindings/soc/qcom/qcom,smem.yaml | 73 +++++++++++++++++++
> 2 files changed, 73 insertions(+), 57 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,smem.example.dt.yaml: memory@fc428000: 'device_type' is a required property
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/memory.yaml
See https://patchwork.ozlabs.org/patch/1410768
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml
2020-12-07 16:43 ` Rob Herring
@ 2020-12-10 11:38 ` Dmitry Baryshkov
2020-12-10 22:22 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2020-12-10 11:38 UTC (permalink / raw)
To: Rob Herring
Cc: Andy Gross, open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Bjorn Andersson
On Mon, 7 Dec 2020 at 19:43, Rob Herring <robh@kernel.org> wrote:
>
> On Fri, 04 Dec 2020 05:24:01 +0300, Dmitry Baryshkov wrote:
> > Convert soc/qcom/qcom,smem.txt bindings to YAML format.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > .../bindings/soc/qcom/qcom,smem.txt | 57 ---------------
> > .../bindings/soc/qcom/qcom,smem.yaml | 73 +++++++++++++++++++
> > 2 files changed, 73 insertions(+), 57 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,smem.example.dt.yaml: memory@fc428000: 'device_type' is a required property
> From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/memory.yaml
Rob, Bjorn, this opens a question for me: do we have to specify
device_type for the following device node? Or is it a false positive?
/ {
soc {
#address-cells = <1>;
#size-cells = <1>;
ranges;
rpm_msg_ram: memory@fc428000 {
compatible = "qcom,rpm-msg-ram";
reg = <0xfc428000 0x4000>;
};
};
};
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml
2020-12-10 11:38 ` Dmitry Baryshkov
@ 2020-12-10 22:22 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-12-10 22:22 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Bjorn Andersson
On Thu, Dec 10, 2020 at 5:38 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Mon, 7 Dec 2020 at 19:43, Rob Herring <robh@kernel.org> wrote:
> >
> > On Fri, 04 Dec 2020 05:24:01 +0300, Dmitry Baryshkov wrote:
> > > Convert soc/qcom/qcom,smem.txt bindings to YAML format.
> > >
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > ---
> > > .../bindings/soc/qcom/qcom,smem.txt | 57 ---------------
> > > .../bindings/soc/qcom/qcom,smem.yaml | 73 +++++++++++++++++++
> > > 2 files changed, 73 insertions(+), 57 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
> > >
> >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,smem.example.dt.yaml: memory@fc428000: 'device_type' is a required property
> > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/memory.yaml
>
> Rob, Bjorn, this opens a question for me: do we have to specify
> device_type for the following device node? Or is it a false positive?
Well, 'memory' nodes should be 'main memory' that the OS manages. This
looks more like onchip SRAM, so 'sram@fc428000' perhaps.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-10 23:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-04 2:24 [PATCH v2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Dmitry Baryshkov
2020-12-07 16:43 ` Rob Herring
2020-12-10 11:38 ` Dmitry Baryshkov
2020-12-10 22:22 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).